X-Authentication-Warning:	delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient:	geda-user AT delorie DOT com
X-Original-DKIM-Signature:	v=1; a=rsa-sha256; c=simple; d=mail.ud03.udmedia.de; h=
	subject:to:references:from:message-id:date:mime-version
	:in-reply-to:content-type:content-transfer-encoding; s=beta; bh=
	5DZT6Izs49L77FRzduuN6Yt+ZEoJj2JIes4/sYe7plw=; b=bb4fiIZAu/tVPf5W
	z/jXlol80BHubmOIsQXcvUtuEri/OHLvedI0t0Pv8KhYhQvEx2StQRurJZC/UZhj
	//QOSGjdXFb5q/rQuk8bCsYar+QffMVlw68JITAtqI+08NxSRH5bk/l6yqTd3lnG
	QkXqM+MHTMPYnrnygur00QMkvZ4=
Subject:	Re: [geda-user] DRC violation discovery order fix options
To:	geda-user AT delorie DOT com
References:	<CAC4O8c-84zCCvrgRz0gJN3xxe4d+NNcP4m1aX6cj-gi8r+vQmQ AT mail DOT gmail DOT com>
	<55FFCE93 DOT 7070004 AT jump-ing DOT de>
	<CAC4O8c-bZ8F_C9Yt6uspYBQCA+WpA5qfssOhktwrGegsCQVhmw AT mail DOT gmail DOT com>
	<560257D0 DOT 9050906 AT jump-ing DOT de>
	<CAC4O8c8uavK0JyZ_bQfGnrZMnxGGYbn7XjYuwsmxdSPwubZCqg AT mail DOT gmail DOT com>
	<5606C24E DOT 1070102 AT jump-ing DOT de>
	<CAC4O8c92VPa81JEqdyHT7qkFfuqPf-hxNtyqqeSSFwZV7xy_WQ AT mail DOT gmail DOT com>
From:	"Markus Hitter (mah AT jump-ing DOT de) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
X-Enigmail-Draft-Status:	N1110
Message-ID:	<5609AA31.7010701@jump-ing.de>
Date:	Mon, 28 Sep 2015 22:59:29 +0200
User-Agent:	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
	Thunderbird/38.2.0
MIME-Version:	1.0
In-Reply-To:	<CAC4O8c92VPa81JEqdyHT7qkFfuqPf-hxNtyqqeSSFwZV7xy_WQ@mail.gmail.com>
Reply-To:	geda-user AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	geda-user AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

Am 28.09.2015 um 00:21 schrieb Britton Kerin:
> On Sat, Sep 26, 2015 at 8:05 AM, Markus Hitter wrote:
> 
>> In pan_common() in gtkhid-main.c you remove two coordinate conversions.
>> It appears to be unrelated to your other work. The person putting these
>> conversions there likely had a reason to do so. If you're sure this can
>> be removed it'd be nice to put this into a separate commit and to
>> describe the reason.
> 
> They don't do anything.

Fine. I took the liberty to split this commit into one with this change
and one with the remaining part.

Other than that I tested the branch and found it to work fine. I think
it's now reasonably in line with general Gtk applications.

The whole branch forwarded to master. Thank you very much for your work.

A few ideas about refactoring in this area came to mind, I've put them
into the bug report:

https://bugs.launchpad.net/geda-project/+bug/1500042


Markus

-- 
- - - - - - - - - - - - - - - - - - -
Dipl. Ing. (FH) Markus Hitter
http://www.jump-ing.de/

- Raw text -