X-Authentication-Warning:	delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient:	geda-user AT delorie DOT com
X-Original-DKIM-Signature:	v=1; a=rsa-sha256; c=simple; d=mail.ud03.udmedia.de; h=
	subject:to:references:from:message-id:date:mime-version
	:in-reply-to:content-type:content-transfer-encoding; s=beta; bh=
	jJ6e4WkynLBcmy97l8wjoEnJ09cGQlN6KOO63paYKhQ=; b=QNG38K88/mYXrebK
	wjxO8gm5wbH2bCFghAwl9w4D90x+R1S9TlD50VkY9+Ds4i1GV997b5SVs8QMjUkJ
	psV5XGS4JCl1r+/TknzMJq3TrSmTJ3Ww0j2JblwlO835m/iIcEcnx4hvEOOEOIGh
	oQnDO270gA8oUP3gfcfOjWmBB14=
Subject:	Re: [geda-user] DRC violation discovery order fix options
To:	geda-user AT delorie DOT com
References:	<CAC4O8c-84zCCvrgRz0gJN3xxe4d+NNcP4m1aX6cj-gi8r+vQmQ AT mail DOT gmail DOT com>
	<55FFCE93 DOT 7070004 AT jump-ing DOT de>
	<CAC4O8c-bZ8F_C9Yt6uspYBQCA+WpA5qfssOhktwrGegsCQVhmw AT mail DOT gmail DOT com>
	<560257D0 DOT 9050906 AT jump-ing DOT de>
	<CAC4O8c8uavK0JyZ_bQfGnrZMnxGGYbn7XjYuwsmxdSPwubZCqg AT mail DOT gmail DOT com>
From:	"Markus Hitter (mah AT jump-ing DOT de) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
X-Enigmail-Draft-Status:	N1110
Message-ID:	<5606C24E.1070102@jump-ing.de>
Date:	Sat, 26 Sep 2015 18:05:34 +0200
User-Agent:	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
	Thunderbird/38.2.0
MIME-Version:	1.0
In-Reply-To:	<CAC4O8c8uavK0JyZ_bQfGnrZMnxGGYbn7XjYuwsmxdSPwubZCqg@mail.gmail.com>
Reply-To:	geda-user AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	geda-user AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

Am 24.09.2015 um 00:57 schrieb Britton Kerin:

> Ok spaces and C++ style comments are gone.

Thanks. Squashed these two commits and put them onto branch LP1500042 to
allow both of us to edit the branch. After squashing it became visible
what the intentions are. :-)

Also opened a bug for it: https://bugs.launchpad.net/bugs/1500042

In pan_common() in gtkhid-main.c you remove two coordinate conversions.
It appears to be unrelated to your other work. The person putting these
conversions there likely had a reason to do so. If you're sure this can
be removed it'd be nice to put this into a separate commit and to
describe the reason.

So I built and tried. Uhm, nothing happens. Clicking on a DRC violation
in the DRC window makes the track/pin in question pink, but neither the
crosshair nor the mouse pointer moves a single pixel. This is identical
to what I have before the commit. Is there a setting required to have
this effect?


> The things that's gonna strike you as
> strange is the gdk_window_process_all_updates() in pan_common().  It's
> because the ghid_invalidate_all() in gtkhid-gl.c is super weird, it has a
> timer so doesn't process updates as expected for us.  The worst consequence
> is maybe a small efficiency loss.  It could perhaps be done from
> ghid_set_crosshair() if that's a concern.  It could perhaps also go in
> ghid_port_ranges_changed(), but for all I know the weird timer is intended
> specifically to make viewport scrolling smooth.  I dunno on this.

This doesn't exactly sound like you understand what you're doing :-)

A strategy I use often to find out about unknown code paths is to
disable them. Or make them ten times slower. Then one can usually see
what happens (or no longer happens).


Even if the above looks like a lot of nagging, it's close already.


Markus

-- 
- - - - - - - - - - - - - - - - - - -
Dipl. Ing. (FH) Markus Hitter
http://www.jump-ing.de/

- Raw text -