X-Authentication-Warning:	delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient:	geda-user AT delorie DOT com
X-Original-DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:content-type;
	bh=W236ZKU/lAYokf4jbURQO/YajEKGRKIRDUDAa9IlFNM=;
	b=epcYix1T31KCKxa314fOmqjigzLEUxZOf1OLUZFqmZvqat0bgOFI1Z8BB2vziG5Fqf
	nI0JoyittCGf/K+Bsc+Y0OOFb2w/nwbX3yzl1FBwtrvf7J/TpSbqHE9e23rZhZ3uPjef
	JYYXUeKhp6fF5mfmuuMTEjhOiM5EdLLZENO/CqYuRQtTz5Rj/jptvmlH2mhnDNY8LzYu
	D0qLyTf+jemuIMU5iLgEf32zc+P9NdYR+V7oLDcVbN6clNy0bywE8E8VW7PZr6NR7yts
	yylvBxuwnm0N8lJqa639PW8koA7cUXAtHTTss9ZB3+lcHaJR+MhiVKhcFQXSZh1hAJgS
	QSJQ==
MIME-Version:	1.0
X-Received:	by 10.180.187.227 with SMTP id fv3mr6186759wic.57.1443049026152;
	Wed, 23 Sep 2015 15:57:06 -0700 (PDT)
In-Reply-To:	<560257D0.9050906@jump-ing.de>
References:	<CAC4O8c-84zCCvrgRz0gJN3xxe4d+NNcP4m1aX6cj-gi8r+vQmQ AT mail DOT gmail DOT com>
	<55FFCE93 DOT 7070004 AT jump-ing DOT de>
	<CAC4O8c-bZ8F_C9Yt6uspYBQCA+WpA5qfssOhktwrGegsCQVhmw AT mail DOT gmail DOT com>
	<560257D0 DOT 9050906 AT jump-ing DOT de>
Date:	Wed, 23 Sep 2015 14:57:06 -0800
Message-ID:	<CAC4O8c8uavK0JyZ_bQfGnrZMnxGGYbn7XjYuwsmxdSPwubZCqg@mail.gmail.com>
Subject:	Re: [geda-user] DRC violation discovery order fix options
From:	"Britton Kerin (britton DOT kerin AT gmail DOT com) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
To:	geda-user AT delorie DOT com
Reply-To:	geda-user AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	geda-user AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

--001a11c25cd698ec650520720883
Content-Type: text/plain; charset=UTF-8

On Tue, Sep 22, 2015 at 11:42 PM, Markus Hitter (mah AT jump-ing DOT de) [via
geda-user AT delorie DOT com] <geda-user AT delorie DOT com> wrote:

> Am 23.09.2015 um 00:43 schrieb Britton Kerin:
> >> - Lots of whitespace editing (removal of whitespace at line ends).
> >> >
> > I can go back and fix this, I agree it can be annoying.
>
> [...]
>
> > The gui-drc-window.c could be considered separate, though without it
> things
> > might not work gracefully at all in some window managers.
> [...]
>
> > Besides fixing spaces how would you change it?
>
> After the above have been fixed I'll take another look. Usually I review
> only until I've found two or three misalignments, then stop. Glad to see
> you want small, easily understandable commits, too.
>

Ok spaces and C++ style comments are gone.

Thanks for doing code review.  The things that's gonna strike you as
strange is the gdk_window_process_all_updates() in pan_common().  It's
because the ghid_invalidate_all() in gtkhid-gl.c is super weird, it has a
timer so doesn't process updates as expected for us.  The worst consequence
is maybe a small efficiency loss.  It could perhaps be done from
ghid_set_crosshair() if that's a concern.  It could perhaps also go in
ghid_port_ranges_changed(), but for all I know the weird timer is intended
specifically to make viewport scrolling smooth.  I dunno on this.  The real
fix would be to make ghid_invalidate_all() less weird but presumably it has
a reason for being what it is.

Britton

--001a11c25cd698ec650520720883
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><div class=3D"gmail_quote">=
On Tue, Sep 22, 2015 at 11:42 PM, Markus Hitter (<a href=3D"mailto:mah AT jump=
-ing.de">mah AT jump-ing DOT de</a>) [via <a href=3D"mailto:geda-user AT delorie DOT com"=
>geda-user AT delorie DOT com</a>] <span dir=3D"ltr">&lt;<a href=3D"mailto:geda-us=
er AT delorie DOT com" target=3D"_blank">geda-user AT delorie DOT com</a>&gt;</span> wrot=
e:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-l=
eft:1px #ccc solid;padding-left:1ex"><span class=3D"">Am 23.09.2015 um 00:4=
3 schrieb Britton Kerin:<br>
&gt;&gt; - Lots of whitespace editing (removal of whitespace at line ends).=
<br>
&gt;&gt; &gt;<br>
&gt; I can go back and fix this, I agree it can be annoying.<br>
<br>
</span>[...]<br>
<span class=3D""><br>
&gt; The gui-drc-window.c could be considered separate, though without it t=
hings<br>
&gt; might not work gracefully at all in some window managers.<br>
</span>[...]<br>
<span class=3D""><br>
&gt; Besides fixing spaces how would you change it?<br>
<br>
</span>After the above have been fixed I&#39;ll take another look. Usually =
I review<br>
only until I&#39;ve found two or three misalignments, then stop. Glad to se=
e<br>
you want small, easily understandable commits, too.<br></blockquote><div><b=
r></div><div style=3D"">Ok spaces and C++ style comments are gone.</div><di=
v style=3D""><br></div><div style=3D"">Thanks for doing code review.=C2=A0 =
The things that&#39;s gonna strike you as strange is the gdk_window_process=
_all_updates() in pan_common().=C2=A0 It&#39;s because the ghid_invalidate_=
all() in gtkhid-gl.c is super weird, it has a timer so doesn&#39;t process =
updates as expected for us.=C2=A0 The worst consequence is maybe a small ef=
ficiency loss.=C2=A0 It could perhaps be done from ghid_set_crosshair() if =
that&#39;s a concern.=C2=A0 It could perhaps also go in ghid_port_ranges_ch=
anged(), but for all I know the weird timer is intended specifically to mak=
e viewport scrolling smooth.=C2=A0 I dunno on this.=C2=A0 The real fix woul=
d be to make ghid_invalidate_all() less weird but presumably it has a reaso=
n for being what it is.</div><div><br></div><div style=3D"">Britton</div><d=
iv><br></div></div></div></div>

--001a11c25cd698ec650520720883--

- Raw text -