www.delorie.com/archives/browse.cgi   search  
Mail Archives: geda-user/2015/09/23/03:42:29

X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=mail.ud03.udmedia.de; h=
subject:to:references:from:message-id:date:mime-version
:in-reply-to:content-type:content-transfer-encoding; s=beta; bh=
XSBsbpu44Cd+UUk9AwtpFLJGns853wJkQhxnLET6Ijw=; b=LApx8iMHN5ezYPIm
z2OLmnnBwKcor+xPoNUpvQ5IKo4GxWfFjMmqEb92/CToM9mRe3vSu5GaWRxdTvlt
yr476UMYKOFmr0sRYmOkYNBn4VqMCz2Mtxk7ydT9eANIy51L6wFubAQ4QhjQL3Qo
EVa2XjPD1+DGpXaKz2uIDyj62VE=
Subject: Re: [geda-user] DRC violation discovery order fix options
To: geda-user AT delorie DOT com
References: <CAC4O8c-84zCCvrgRz0gJN3xxe4d+NNcP4m1aX6cj-gi8r+vQmQ AT mail DOT gmail DOT com>
<55FFCE93 DOT 7070004 AT jump-ing DOT de>
<CAC4O8c-bZ8F_C9Yt6uspYBQCA+WpA5qfssOhktwrGegsCQVhmw AT mail DOT gmail DOT com>
From: "Markus Hitter (mah AT jump-ing DOT de) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
Message-ID: <560257D0.9050906@jump-ing.de>
Date: Wed, 23 Sep 2015 09:42:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <CAC4O8c-bZ8F_C9Yt6uspYBQCA+WpA5qfssOhktwrGegsCQVhmw@mail.gmail.com>
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com

Am 23.09.2015 um 00:43 schrieb Britton Kerin:
>> - Lots of whitespace editing (removal of whitespace at line ends).
>> >
> I can go back and fix this, I agree it can be annoying.

[...]

> The gui-drc-window.c could be considered separate, though without it things
> might not work gracefully at all in some window managers.
[...]

> Besides fixing spaces how would you change it?

After the above have been fixed I'll take another look. Usually I review
only until I've found two or three misalignments, then stop. Glad to see
you want small, easily understandable commits, too.


Markus

-- 
- - - - - - - - - - - - - - - - - - -
Dipl. Ing. (FH) Markus Hitter
http://www.jump-ing.de/

- Raw text -


  webmaster     delorie software   privacy  
  Copyright © 2019   by DJ Delorie     Updated Jul 2019