X-Authentication-Warning:	delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient:	geda-user AT delorie DOT com
X-Original-DKIM-Signature:	v=1; a=rsa-sha256; c=simple; d=mail.ud03.udmedia.de; h=
	to:from:subject:message-id:date:mime-version:content-type
	:content-transfer-encoding; s=beta; bh=CuV90FcTutUoIXAoT1lBIbETZ
	g59dkhFO6QLQ/o6yxs=; b=majKG3VVy9adLRqSUt1QxuLjk4LtxUF6swrjrZMP+
	ukmU05JCjcmiiUN/M7PUzP+XZIzTlmQ3Dm34TaLATzw3V/EVuJ8icHTrp+PcX7qk
	hF4VHXr3d9cB1Yklf66979Vhle24O9daYvz8+VG9Mvrmnc6NJ5aJhUMalJhKRs6g
	Po=
To:	geda-user AT delorie DOT com
From:	"Markus Hitter (mah AT jump-ing DOT de) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
Subject:	[geda-user] Notice to pcb developers: 'make distcheck' and regression tests
Message-ID:	<55F9E09F.7090804@jump-ing.de>
Date:	Wed, 16 Sep 2015 23:35:27 +0200
User-Agent:	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
	Thunderbird/38.2.0
MIME-Version:	1.0
Reply-To:	geda-user AT delorie DOT com

Hello developers,

as of today, a 'make distcheck' works for pcb again. This is not only a
check, it also builds a distribution package. It goes like this:

  ./autogen.sh && ./configure && make
  make distcheck
  ./autogen.sh && ./configure && make
  make distcheck

Double work? Well, a bug, see
https://bugs.launchpad.net/pcb/+bug/1496105

Usually I wouldn't write to the list just because a number of bugs got
fixed. I write because this was apparently a long standing issue and
nobody noticed. Which leads to the topic of regression testing.

So far I did a

  ./autogen.sh && ./configure && make
  make check

and if this succeeded, I pushed to master.

Apparently not enough. 'make distcheck' builds into a separate build
directory, so files get copied over to there. And it happened that not
everything got copied, which is why a distcheck failed.

As far as I can see, this is the best procedure we have to make sure
there are no regressions:

  ./autogen.sh && ./configure && make
  make distcheck

A distcheck includes a normal check. It takes quite a while, still it's
necessary after adding files, removing files, changing something in
configure.ac or one of the Makefile.am's. This is what one should see at
the end:

  ===========================================
  pcb-1.99z archives ready for distribution:
  pcb-1.99z.tar.gz
  ===========================================

More regression tests are always welcome, of course, for examples see
src/pcb_printf.c (unit tests) and the tests/ directory (exports, actions).


Happy hacking,
Markus

-- 
- - - - - - - - - - - - - - - - - - -
Dipl. Ing. (FH) Markus Hitter
http://www.jump-ing.de/

- Raw text -