X-Authentication-Warning:	delorie.com: mail set sender to djgpp-workers-bounces using -f
Date:	Wed, 29 Oct 2003 18:16:24 +0300 (MSK)
From:	"Alexander Aganichev" <aaganichev AT yandex DOT ru>
Sender:	aaganichev AT yandex DOT ru
Message-Id:	<3F9FD9C8.000003.05203@ariel.yandex.ru>
MIME-Version:	1.0
X-Mailer:	Yamail [ http://yandex.ru ]
To:	djgpp-workers AT delorie DOT com
Subject:	Re: locale fixes
In-Reply-To:	<3F9EC775.41795CD0@phekda.freeserve.co.uk>
References:	<3F9E3836 DOT 000008 DOT 02793 AT soapbox DOT yandex DOT ru> <3F9EC775 DOT 41795CD0 AT phekda DOT freeserve DOT co DOT uk>
X-source-ip:	208.248.82.254
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

Hi!

>I don't have time to review them properly, but they basically look OK to me.
>I'll review them properly on Sunday, hopefully.
>
>Do you have any test programs for these functions?
>
>If there are any existing tests, do they still pass, after applying your
>patches?

In general, without new setlocale() all locale patches should do nothing more then all those functions currently do. They only add the possibility to modify the behaviour of these functions from external modules.

For decimal point fixes I'll write the test cases where decimal_point is set from the application to some odd character (like comma or even ampersend) and test that conversion from ASCII and to ASCII still stable.

For strcoll and strftime it is possible to modify static data and test that the result is also changed. I tested it with new setlocale() on Russian locale.

I'll post these test cases before the end of this week.

I have no good idea how to check fix for the realloc() in regex. I did it by the visual examination of code.

-- 
Alexander Aganichev

url: http://aaganichev.narod.ru
e-mail: aaganichev AT yandex DOT ru
gsm: +7-095-786-1339

- Raw text -