Sender:	rich AT phekda DOT freeserve DOT co DOT uk
Message-ID:	<3DE6778F.108A69D1@phekda.freeserve.co.uk>
Date:	Thu, 28 Nov 2002 20:07:43 +0000
From:	Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
X-Mailer:	Mozilla 4.77 [en] (X11; U; Linux 2.2.19 i586)
X-Accept-Language:	de,fr
MIME-Version:	1.0
To:	djgpp-workers AT delorie DOT com
Subject:	Re: _Exit function [PATCH]
References:	<10211281801 DOT AA13105 AT clio DOT rice DOT edu>
Reply-To:	djgpp-workers AT delorie DOT com

Hello.

Charles Sandmann wrote:
>
> Looks good to me.  Only one comment (library space and efficiency):
> include/libc/stubs.h is used to create "aliases" similar to this
> that we use for namespace fixes.  Should we also use this to create
> simple jump stubs like this one?
> 
> added to include/libc/stubs.h:
> 
> #define _Exit _exit
> 
> It would be a new use (abuse?) of libc/stubs.h

Yuck. 8)

We could just write the stub in assembler. There are a couple of functions
like that already - stricmp assembler stub calls strcasecmp (or maybe
vice-versa). Of course (ab)using include/libc/stubs.h would get this written
automatically.
 
> It does make finding the "source" harder, but it makes smaller libraries
> and executables, and we don't need a source module for "_Exit" - it's
> automatically written.  And no need to modify a makefile either.

I think I prefer the explicitly-written stub. Hmmm, maybe I should rewrite
_Exit to use an assembler stub like stricmp/strcasecmp.

> > OK to commit?
> 
> Fine with me, I just thought I would bring the above issue up (it's
> not the first time, and probably not the last ...

Bye, Rich =]

-- 
Richard Dawe [ http://www.phekda.freeserve.co.uk/richdawe/ ]

- Raw text -