X-Authentication-Warning:	delorie.com: mailnull set sender to djgpp-workers-bounces using -f
From:	pavenis AT lanet DOT lv
To:	pavenis AT lanet DOT lv, Zack Weinberg <zack AT codesourcery DOT com>
Date:	Thu, 9 May 2002 19:11:12 +0300
MIME-Version:	1.0
Subject:	Re: RFA: Ignore DOS end-of-line characters (ctrl-Z) unless -W
Cc:	Andris Pavenis <pavenis AT latnet DOT lv>, djgpp-workers AT delorie DOT com,
	Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>,
	Nick Clifton <nickc AT cambridge DOT redhat DOT com>, gcc-patches AT gcc DOT gnu DOT org
Message-ID:	<3CDAC9D0.15538.1E838FC@localhost>
In-reply-to:	<20020509154208.GB2285@codesourcery.com>
References:	<3CDA764D DOT 1410 DOT A1F3EA AT localhost>
X-mailer:	Pegasus Mail for Windows (v4.01)
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

On 9 May 2002 at 8:42, Zack Weinberg wrote:

> On Thu, May 09, 2002 at 01:14:53PM +0300, pavenis AT lanet DOT lv wrote:
> > 
> > OK. Here it is (tested for DJGPP with 3.1 branch)
> 
> O_TEXT, not O_BINARY.  Also, based on other discussion with Eli, the
> check should apply to all file descriptors, not just stdin, so please
> move it below the call to open.
> 

I don't think so.

With O_TEXT we will run into another trouble as length of data in memory will 
be smaller than one in file. As result read_include_file() will complain that
input file is shorter than expected.

So unless we want to remove that check, O_BINARY must stay there.

Current patch changes mode to O_BINARY in rather specific case when
one is feeding source in gcc from pipe. For example 
	cat foo.c | gcc -c -x c -o foo.o -
In this case file is opened in text mode by default, and I'm getting a warning 
I mentioned above.

Andris

- Raw text -