www.delorie.com/archives/browse.cgi | search |
X-Authentication-Warning: | delorie.com: mailnull set sender to djgpp-workers-bounces using -f |
From: | sandmann AT clio DOT rice DOT edu (Charles Sandmann) |
Message-Id: | <10201091632.AA14478@clio.rice.edu> |
Subject: | Re: Proposed lstat.c patch for Win2000/XP device bit fix |
To: | eliz AT is DOT elta DOT co DOT il |
Date: | Wed, 9 Jan 2002 10:32:11 -0600 (CST) |
Cc: | djgpp-workers AT delorie DOT com |
In-Reply-To: | <6137-Wed09Jan2002181142+0200-eliz@is.elta.co.il> from "Eli Zaretskii" at Jan 09, 2002 06:11:43 PM |
X-Mailer: | ELM [version 2.5 PL2] |
Mime-Version: | 1.0 |
Reply-To: | djgpp-workers AT delorie DOT com |
Errors-To: | nobody AT delorie DOT com |
X-Mailing-List: | djgpp-workers AT delorie DOT com |
X-Unsubscribes-To: | listserv AT delorie DOT com |
> > stat_assist already uses the exact same strcmp() call elsewhere in > > the program, so the string "LFN32" is already in the image. If we were > > obsessed with size and speed I'd say to use a cast and compare to > > "LFN3" as a long. But right now this is more understandable, rarely > > run, and similar to other code in the module. > > FWIW, I don't see any problem to have another "LFN32" in the image. > When constant strings are used by several library functions, we could > also use a global constant string instead. system.c uses such > method, for example. I should clarify - this strcmp() was added to stat_assist which already has one strcmp() of the same string - so it already exists in the same module (removing it doesn't gain much).
webmaster | delorie software privacy |
Copyright © 2019 by DJ Delorie | Updated Jul 2019 |