X-Authentication-Warning:	delorie.com: mailnull set sender to djgpp-workers-bounces using -f
From:	sandmann AT clio DOT rice DOT edu (Charles Sandmann)
Message-Id:	<10201091558.AA15635@clio.rice.edu>
Subject:	Re: Proposed lstat.c patch for Win2000/XP device bit fix
To:	djgpp-workers AT delorie DOT com
Date:	Wed, 9 Jan 2002 09:58:01 -0600 (CST)
In-Reply-To:	<200201091347.OAA11490@lws256.lu.erisoft.se> from "Martin Stromberg" at Jan 09, 2002 02:47:18 PM
X-Mailer:	ELM [version 2.5 PL2]
Mime-Version:	1.0
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

> > +           !strcmp(ff_blk.lfn_magic,"LFN32") &&
> 
> Isn't this code always included in the image. IIRC, the recommendation
> is to use ff_blk.lfn_magic[0] == 'F' && ff_blk.lfn_magic[0] == 'A' &&
> ... if so.

stat_assist already uses the exact same strcmp() call elsewhere in
the program, so the string "LFN32" is already in the image.  If we were
obsessed with size and speed I'd say to use a cast and compare to
"LFN3" as a long.  But right now this is more understandable, rarely
run, and similar to other code in the module.

- Raw text -