Message-Id:	<199905091641.QAA48022@out1.ibm.net>
From:	"Mark E." <snowball3 AT bigfoot DOT com>
To:	djgpp-workers AT delorie DOT com
Date:	Sun, 9 May 1999 12:42:12 -0400
MIME-Version:	1.0
Subject:	RE: v2.03: wrapping up
In-Reply-To:	<XFMail.990504151958.markus.oberhumer@jk.uni-linz.ac.at>
X-mailer:	Pegasus Mail for Win32 (v3.01d)
Reply-To:	djgpp-workers AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

> +         if (*p == '~')

I would suggest replacing uses of '~' with a constant variable so if it 
should become neccessary to once again change the delimiter, you 
only need change it in once place:

static const char env_delim = '~';

if (*p == env_delim)

etc.

It would also be nice if we could find a way to let '~'  be a valid first 
character of a default string since under the current scheme a default 
string with special meaning to Bash like '~/_inputrc' is disallowed. The 
only way to do that and keep '~' as the delimiter would be to not 
process '~~' as '~' in the variable name.

Mark

--- 
Mark Elbrecht, snowball3 AT bigfoot DOT com
http://snowball.frogspace.net/

- Raw text -