Mail Archives: cygwin-developers/2001/09/07/18:48:02
On Fri, Sep 07, 2001 at 05:38:23PM -0400, Christopher Faylor wrote:
> On Fri, Sep 07, 2001 at 07:09:51PM +0200, Corinna Vinschen wrote:
> >>>Did this patch work? It seems to for me.
> >>
> >>The last we heard, another similar patch to this one didn't work for
> >>Corinna.
> >>
> >>I'd like to get confirmation that this one works ok.
> >
> >Sorry, it doesn't work for me. I tried the plain version from CVS and
> >the same including the cygheap.cc patch which you've send here. My
> >testcase is a `make' in a Cygwin build tree. This testcase crashes now
> >on a regular basis in /bin/sh. I'm getting the following backtrace in
> >gdb with and without your yesterday's patch in cygheap.cc:
>
> The problem was, as I suspected, due to the zombies allocation. The
> problem is that allocating the zombies array only when needed caused the
> heap to grow while the program was in the process of forking. So,
> when the parent tried to copy the heap to the child during a fork, the
> heap was larger in the parent than in the child. Boom.
When I read the above description I got a bit pale first... heap grows
while program forks...
> AFAICT, this also had nothing to do with moving buckets to cygheap. I'm
> not sure how that would have affected anything unless the alignment in
> the data segment caused by having buckets there threw off the heap just
> enough so that it masked the fork problem.
Yeah, the reproducable bucket case was apparently just a coincidence.
> Corinna and Egor, can you verify if this checkin fixes things.
That looks awful good now.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Developer mailto:cygwin AT cygwin DOT com
Red Hat, Inc.
- Raw text -