Mailing-List:	contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-developers-subscribe AT sources DOT redhat DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin-developers/>
List-Post:	<mailto:cygwin-developers AT sources DOT redhat DOT com>
List-Help:	<mailto:cygwin-developers-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender:	cygwin-developers-owner AT sources DOT redhat DOT com
Delivered-To:	mailing list cygwin-developers AT sources DOT redhat DOT com
Date:	Thu, 7 Dec 2000 12:57:49 -0500
From:	Christopher Faylor <cgf AT redhat DOT com>
To:	cygwin-developers AT cygwin DOT com
Subject:	Re: cygcheck patch
Message-ID:	<20001207125749.C15956@redhat.com>
Reply-To:	cygwin-developers AT cygwin DOT com
Mail-Followup-To:	cygwin-developers AT cygwin DOT com
References:	<Pine DOT NEB DOT 4 DOT 10 DOT 10012061643320 DOT 23344-101000 AT cesium DOT clock DOT org> <200012071749 DOT MAA05135 AT envy DOT delorie DOT com>
Mime-Version:	1.0
User-Agent:	Mutt/1.3.11i
In-Reply-To:	<200012071749.MAA05135@envy.delorie.com>; from dj@delorie.com on Thu, Dec 07, 2000 at 12:49:29PM -0500

Also, please use cygwin-patches for cygwin patches.

Thanks,
cgf
(The Pedantic One)

On Thu, Dec 07, 2000 at 12:49:29PM -0500, DJ Delorie wrote:
>
>> From: Matt <matt AT use DOT net>
>
>> Changelog:
>
>Your patch is OK, but please format your Changelog Entry like all the
>rest.  Specifically, you don't disclose your full name, which is part
>of the ChangeLog, entries are indented with a tab, proper
>capitalization and punctuation is needed, you don't repeat the
>filename for multiple changes therein, and do include the function
>names.  Example:
>
>2000-12-07  Matt Someone  <matt AT use DOT net>
>
>	* utils/cygcheck.cc (keyeprint): Moved declaration before
>	other functions so it could be used by all functions to report
>	error messages.
>	(add_path): Check for NULL.
>	(find_on_path): Ditto.
>	(init_paths): Check for errors.
>	(track_down): Ditto, plus NULL.  Close memory leak.
>
>(etc)

- Raw text -