Mailing-List:	contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe:	<mailto:cygwin-developers-subscribe AT sources DOT redhat DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin-developers/>
List-Post:	<mailto:cygwin-developers AT sources DOT redhat DOT com>
List-Help:	<mailto:cygwin-developers-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender:	cygwin-developers-owner AT sources DOT redhat DOT com
Delivered-To:	mailing list cygwin-developers AT sources DOT redhat DOT com
Date:	Thu, 7 Dec 2000 12:40:09 -0500
Message-Id:	<200012071740.MAA05051@envy.delorie.com>
X-Authentication-Warning:	envy.delorie.com: dj set sender to dj AT envy DOT delorie DOT com using -f
From:	DJ Delorie <dj AT delorie DOT com>
To:	tailbert AT yahoo DOT com
CC:	cygwin-developers AT sources DOT redhat DOT com
In-reply-to:	<FMEOJCMLNIMPBKAPFPIHCEFCCFAA.tailbert@yahoo.com>
Subject:	Re: doctool.c patch
References:	<FMEOJCMLNIMPBKAPFPIHCEFCCFAA DOT tailbert AT yahoo DOT com>

> Enclosed is a patch for winsup/doc/doctool.c. I've extended it to allow
> symbolically linked files to be considered as valid source files. This
> allows doctool to find the correct files for those of us who check out the
> entire :/cvs/src tree and use the configure-target-winsup to compile winsup.

doctool specifically uses lstat to avoid symlinks.  Your patch undoes
that.  If this is really what you want, then you have to consider two
things:

1. The original code is there to avoid symlinks.  Why?  What problems
   could symlinks cause, that the original author already encountered
   and dealt with? (hint: symlinks to directories, symlinks causing
   duplication)

2. If you want symlinks treated as files, just take out the lstat/stat
   logic, and always use stat.

Plus, you dind't include a ChangeLog entry.

- Raw text -