Mailing-List:	contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Unsubscribe:	<mailto:cygwin-developers-unsubscribe-archive-cygwin-developers=delorie DOT com AT sourceware DOT cygnus DOT com>
List-Subscribe:	<mailto:cygwin-developers-subscribe AT sourceware DOT cygnus DOT com>
List-Archive:	<http://sourceware.cygnus.com/ml/cygwin-developers/>
List-Post:	<mailto:cygwin-developers AT sourceware DOT cygnus DOT com>
List-Help:	<mailto:cygwin-developers-help AT sourceware DOT cygnus DOT com>, <http://sourceware.cygnus.com/ml/#faqs>
Sender:	cygwin-developers-owner AT sourceware DOT cygnus DOT com
Delivered-To:	mailing list cygwin-developers AT sourceware DOT cygnus DOT com
From:	Chris Faylor <cgf AT cygnus DOT com>
Date:	Sat, 4 Dec 1999 21:08:12 -0500
To:	Mumit Khan <khan AT nanotech DOT wisc DOT edu>
Cc:	cygwin-developers AT sourceware DOT cygnus DOT com
Subject:	Re: (patch) winsup noncygwin mess cleanup
Message-ID:	<19991204210812.A9926@cygnus.com>
Mail-Followup-To:	Mumit Khan <khan AT nanotech DOT wisc DOT edu>,
	cygwin-developers AT sourceware DOT cygnus DOT com
References:	<199912050203 DOT UAA01202 AT mercury DOT xraylith DOT wisc DOT edu>
Mime-Version:	1.0
X-Mailer:	Mutt 1.0i
In-Reply-To:	<199912050203.UAA01202@mercury.xraylith.wisc.edu>; from khan@nanotech.wisc.edu on Sat, Dec 04, 1999 at 08:03:07PM -0600

On Sat, Dec 04, 1999 at 08:03:07PM -0600, Mumit Khan wrote:
>Here's a patch to current CVS tree to remove the gross hack that was
>there to load Cygwin DLL from a noncygwin app (eg., Java JNI, etc).

This is wicked cool!  Thank you!

Can I just make one minor stylistic suggestion?

I think I'd prefer just using the "dynamically_loaded" variable
directly rather than using the NON_CYGWIN_APP macro.  I think
that the "dynamically_loaded" variable is clearer, especially
when it is negated:

	if (!dynamically_loaded)
	  .
	  .
	  .

Otherwise, this all looks perfect.

cgf

- Raw text -