Mailing-List:	contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Unsubscribe:	<mailto:cygwin-developers-unsubscribe-archive-cygwin-developers=delorie DOT com AT sourceware DOT cygnus DOT com>
List-Subscribe:	<mailto:cygwin-developers-subscribe AT sourceware DOT cygnus DOT com>
List-Archive:	<http://sourceware.cygnus.com/ml/cygwin-developers/>
List-Post:	<mailto:cygwin-developers AT sourceware DOT cygnus DOT com>
List-Help:	<mailto:cygwin-developers-help AT sourceware DOT cygnus DOT com>, <http://sourceware.cygnus.com/ml/#faqs>
Sender:	cygwin-developers-owner AT sourceware DOT cygnus DOT com
Delivered-To:	mailing list cygwin-developers AT sourceware DOT cygnus DOT com
From:	Chris Faylor <cgf AT cygnus DOT com>
Date:	Wed, 24 Nov 1999 21:37:43 -0500
To:	Kazuhiro Fujieda <fujieda AT jaist DOT ac DOT jp>
Cc:	cygwin-developers AT sourceware DOT cygnus DOT com
Subject:	Re: cygwin_bind bug.
Message-ID:	<19991124213743.A16356@cygnus.com>
Mail-Followup-To:	Kazuhiro Fujieda <fujieda AT jaist DOT ac DOT jp>,
	cygwin-developers AT sourceware DOT cygnus DOT com
References:	<s1s903npgry DOT fsf AT jaist DOT ac DOT jp> <19991124192413 DOT A12159 AT cygnus DOT com> <s1s4sebpcyz DOT fsf AT jaist DOT ac DOT jp> <19991124205652 DOT B15777 AT cygnus DOT com> <s1s1z9fpand DOT fsf AT jaist DOT ac DOT jp>
Mime-Version:	1.0
X-Mailer:	Mutt 1.0i
In-Reply-To:	<s1s1z9fpand.fsf@jaist.ac.jp>; from fujieda@jaist.ac.jp on Thu, Nov 25, 1999 at 11:28:38AM +0900

On Thu, Nov 25, 1999 at 11:28:38AM +0900, Kazuhiro Fujieda wrote:
>>>> On Wed, 24 Nov 1999 20:56:52 -0500
>>>> Chris Faylor <cgf AT cygnus DOT com> said:
>
>> In that case, why even use an intermediate variable?  Why not just check
>> the results from bind and getsockname directly?
>
>There is no reason... I carelessly failed to notice there is
>no need of it.
>
>> Index: net.cc
>...
>>            else
>>              {
>>                _close (fd);
>>                chmod (un_addr->sun_path,
>>                  (S_IFSOCK | S_IRWXU | S_IRWXG | S_IRWXO) & ~myself->umask);
>> -              res = 0;
>>              }
>
>It is overkill. No one can set `res' to 0.

Hmm.  I wonder how I deleted that line.  The 'goto out' below it is also overkill.

cgf

- Raw text -