From:	noer AT cygnus DOT com (Geoffrey Noer)
Subject:	New winsup snapshot 3/25/98
25 Mar 1998 17:19:00 -0800 :
Message-ID:	<199803260103.RAA15583.cygnus.cygwin32.developers@rtl.cygnus.com>
To:	cygwin32-developers AT cygnus DOT com
Cc:	noer AT cygnus DOT com (Geoffrey Noer)

New winsup snapshot available for those of you who care.  :-)

Changes since the last one follow.  There are a couple of real bug
fixes at the end of this.  The rest is my cleaning up warnings
generated by compiling with -Wall.  They're not all gone yet but the
state of things is much better I think.

-- 
Geoffrey Noer
noer AT cygnus DOT com



Wed Mar 25 15:25:26 1998  Geoffrey Noer  <noer AT cygnus DOT com>

        And more:
        * {fhandler.cc, fhandler.h, tty.cc, net.cc, console.cc}: make
        ioctl calls' cmd arg unsigned, ditto for access arg of init calls.
        * console.cc (fhandler_console::fillin_info): add parens around
        assignment used as truth value.
        (FakeReadFile): make copied_chars a size_t
        (fhandler_console::read): make i in loop unsigned
        * environ.cc (setenv): make l_value unsigned, add parens around
        assignments used as truth values.
        * exceptions.cc (call_handler): supposed to return an int and
        wasn't at the end of control flow.  Now returns 1 there.
        * fhandler.h (~fhandler_base): destructor should be marked virtual
        * misc.cc (login): add parens around assignment used as truth
        value.
        * net.cc: cast INVALID_SOCKET to int in comparisons
        (fhandler_socket::ioctl): remove int cast to FIONBIO since cmd
        is now unsigned
        (get_win95_ifconf): add cast to signed vs unsigned int comparison.
        * ntea.cc (NTReadEA): add cast to signed vs unsigned int
        comparison.
        * path.cc (getcwd_inner): make len a size_t
        * pinfo.cc (cygwin32_winpid_to_pid): add comment
        * select.cc (cygwin32_select): make wait_ret an int
        * signal.cc (kill_worker): add parens around assignments used as
        truth values.
        * sigproc.cc (wait_sig): make rc a DWORD
        (sig_send): add parens around assignment used as truth value.
        * strace.cc: make inqueue global a static DWORD
        * tty.cc (do_output): add cast to signed vs unsigned int
        comparison.
        (fhandler_pty_master::open): remove unused handle nh

Tue Mar 24 18:03:59 1998  Geoffrey Noer  <noer AT cygnus DOT com>

        More spring cleaning:
        * net.cc: move LOAD macro definition out of winsock_init,
        correction to make it valid ANSI C++.
        * grp.cc (read_etc_group): pass default line directly to
        add_grp_line call

Mon Mar 23 19:21:00 1998  Geoffrey Noer  <noer AT cygnus DOT com>

        * include/Windows32/Defines.h: define MNC_CLOSE et al

        Spring cleaning with -Wall:
        * console.cc (fhandler_console::de_linearize): return int
        * dirsearch.cc (readdir): remove unused variable reason
        * dll_init.cc (DllListIterator::DllListIterator): reorder
        initializers to match declaration order
        * environ.cc (environ_init): remove unused variable cygix
        * exceptions.cc (__cygwin32_exception_handler): put parents
        around sizeof call
        * fhandler.cc (fhandler_base::read): remove unused variable i
        * fhandler.h: minor respacing
        * hinfo.cc: respacing
        (hinfo_vec::build_fhandler): remove unused label out
        * init.cc (dll_entry): remove unused variable p
        * passwd.cc: remove unused last_passwd struct
        (search_for): remove already commented out references to it
        * select.cc (fd_socket_map::create_arrays): return result
        of calling fd_set_map::create_arrays
        (fd_socket_map::add): return result of calling fd_set_map::add
        (auto_del_fd_set_map::add): return void, not int
        * sigproc.cc (proc_subproc): remove unused variables i, rcw
        (proc_terminate): remove unused variable r
        (sigproc_init): remove unused variable tid
        * spawn.cc (spawn_guts): remove unused variable magic[2]
        * syscalls.cc (system): remove unused variable pid
        (statfs): remove  unused variable err
        * tty.cc (fhandler_tty_master::init): return int
        (fhandler_tty_slave::linearize): return int
        (fhandler_tty_slave::de_linearize): return int
        (fhandler_pty_master::linearize): return int
        (fhandler_pty_master::de_linearize): return int

Mon Mar 23 19:21:00 1998  Geoffrey Noer  <noer AT cygnus DOT com>

        patch from sos AT prospect DOT com DOT ru (Sergey Okhapkin):
        * tty.cc (do_input): compare a char with current termios
        settings, but not with constants.
        (do_output): debug printf in a loop disabled.
        * environ.cc (parse_options): change struct to union to avoid
        references to uninitialized fields.

Mon Mar 23 19:21:00 1998  Geoffrey Noer  <noer AT cygnus DOT com>

        patch from cgf AT bbc DOT com (Christopher Faylor):
        * spawn.cc (spawn_guts): Don't call close_all_files if a cygwin
        process has been spawned.  Otherwise, we close tty handles twice.

- Raw text -