From:	ian AT cygnus DOT com (Ian Lance Taylor)
Subject:	Re: tty.cc fix.
15 Feb 1998 21:09:57 -0800 :
Message-ID:	<199802160509.AAA18362.cygnus.cygwin32.developers@subrogation.cygnus.com>
References:	<01BD3A48 DOT D8524AD0 AT sos>
Reply-To:	cygwin32-developers AT cygnus DOT com
To:	Sergey Okhapkin <sos AT buggy DOT prospect DOT com DOT ru>
Cc:	cygwin32-developers AT cygnus DOT com

   From: Sergey Okhapkin <sos AT buggy DOT prospect DOT com DOT ru>
   Date: Sun, 15 Feb 1998 19:35:16 +0300

   tty.cc	(fhandler_tty_slave::open): call DuplicateHandle() instead of copying.

This patch looks wrong.  It looks like it will break the EOF handling.
You have to remember that the whole point of the handle manipulation
in tty.cc is so that when the slave is closed, the pipe is closed.  If
there is somewhere I need to add comments, please let me know.

Ian

- Raw text -