Mailing-List:	contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender:	cygwin-apps-owner AT cygwin DOT com
List-Subscribe:	<mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin-apps/>
List-Post:	<mailto:cygwin-apps AT cygwin DOT com>
List-Help:	<mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Mail-Followup-To:	cygwin-apps AT cygwin DOT com
Delivered-To:	mailing list cygwin-apps AT cygwin DOT com
Subject:	RE: Checked branch setup.exe changes into trunk
Date:	Wed, 15 May 2002 16:53:36 +1000
Message-ID:	<FC169E059D1A0442A04C40F86D9BA7600C60B9@itdomain003.itdomain.net.au>
X-MS-Has-Attach:
MIME-Version:	1.0
X-MS-TNEF-Correlator:
From:	"Robert Collins" <robert DOT collins AT itdomain DOT com DOT au>
X-MimeOLE:	Produced By Microsoft Exchange V6.0.5762.3
content-class:	urn:content-classes:message
To:	<cygwin-apps AT cygwin DOT com>
X-MIME-Autoconverted:	from quoted-printable to 8bit by delorie.com id g4F6s1Z11017

> -----Original Message-----
> From: Christopher Faylor [mailto:cgf AT redhat DOT com] 
> Sent: Wednesday, May 15, 2002 1:05 PM
> To: cygwin-apps AT cygwin DOT com
> Subject: Checked branch setup.exe changes into trunk
> 
> 
> It looks like all of the changes I made to the branch are 
> applicable to the trunk as well.
> 
> I know that there was some talk of using something to fix the 
> strstr problem but I checked in my "fix" for that as well.
> 
> While doing this, I noticed that a variation of the strstr 
> problem still exists in one place.  The check_ini() function 
> can still match a trailing c:\foo\abcdefghijklmnopsetup.ini file.
> 
> I don't know/remember enough about what is going on there to 
> suggest a fix.  Probably just checking for "\\setup.ini" 
> would be adequate, though.
> 
> I won't be crushed if any or all of my fixes are reverted but 
> I thought I might as well check them in since AFAICT they 
> were applicable on the trunk.

They won't be reverted (I recall asking you to check them in if you had
time). Thanks again.

Checking for \\setup.ini should be enough as long as / is never returned
by the find function.  I'll do something like this in HEAD soon.

Rob

- Raw text -