From patchwork Tue Apr 30 20:05:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabi Falk X-Patchwork-Id: 89207 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CCB1A3858401 for ; Tue, 30 Apr 2024 20:06:43 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id 55A973858427 for ; Tue, 30 Apr 2024 20:05:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 55A973858427 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 55A973858427 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.227.17.20 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714507546; cv=none; b=jLj/AA2RKlfDIIc/vARNmqC/Mi3vnj8OMDFgBhXfPWaQkKIIQWfaa1yuoXkGwGnxLxJMlWv55k+hYSyYGuQYiihdEi9ofO760WZSu3IHNTZvqVOXOfyVdBONZhmkNzwc8fSoo/MMRjBYl85bUJk0cqZfVOeFiKehKueM5uMSz+Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714507546; c=relaxed/simple; bh=BLce9RS/uRrRvc8wzojnu7pHb0YYjrgeqX6TMCej83w=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ukZeLty0lNSYxs5xBgIZw7rwV7KEfj2X1YG2+eNTSAv3u9KjwFPhmuP8vTcgW6/JwHGlE3rzqIs8vmHk9J5yUDUI6+XoB+gqVxdFfeYD1uHAlAMjkUFssfUSzfOQmrZXbbY7wE7TSZciURabl9ud/LdyMe+XnJPOBBZ1mcqQp+M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.com; s=s31663417; t=1714507526; x=1715112326; i=gabifalk@gmx.com; bh=P03EJoJd/1LUqhNP4EXgG618xt3SYlpGZ5wyKh0lNG8=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=fWthVptX7hnw2+4H1eDvQ4RwoKBmvBYDi6edXBLL6XK6UT00LgN84uyOiNVYDb50 6ON8luawXIQYrkvTTleILfnZdz1iQhNxaCiXo8Wv3OOipiZGnnAJNvH6Rj5RY2/UL l+xze/Aib/EXktwJ1Jxd4xjf/NnjO5WDVRSxfKURkDFz2XWyXfjkVyzhgRe4qy09K a9bc/vanYT1EYMN/Hullj8o9TZXvqM5qsl2TY+oyBxAbz2BefcqpojfyIxA6UkvoA wMAqBEJZOpzSsc1IMAH4meW0SZ2YkWvsfgnlf8PGPC502IGkld0Ux3WG8+kMcVY7a s3Gr42yYM9AeEo1nQg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost ([46.120.23.13]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MNbox-1sHVbp0lyN-00PoSm; Tue, 30 Apr 2024 22:05:26 +0200 From: Gabi Falk To: libc-alpha@sourceware.org, "H.J. Lu" , Florian Weimer , "Dmitry V. Levin" , Sam James Cc: Gabi Falk Subject: [PATCH 3/3] Add a test to check for duplicate definitions in the static library Date: Tue, 30 Apr 2024 20:05:04 +0000 Message-ID: <20240430200506.2717717-4-gabifalk@gmx.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240430200506.2717717-1-gabifalk@gmx.com> References: <20240430200506.2717717-1-gabifalk@gmx.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:dzxrZLWy+yHFmSaHiGUpya13rQ9izlb2fT//9gyjwR2JJRQbn8f J4mQbZ4mXs1zqH9GCRELjgRTxa8wVGV888RauFNt44QDqw2FoVV9BOxiCXvjUZgs/HNa9NB P9cedHarsaA0MeNkmfefJNzR6w4mMht7paa+hxwwgu5t0u8vGv0xSOdzxvo7Hq7oM5v/Bh6 MMvfH0NVHb44s9SkfDF9A== UI-OutboundReport: notjunk:1;M01:P0:qf/VYTo1esg=;/xiAa63WuWm4zSRCzNrLfLaGDL0 JCJMAyBBkJeL4G2yK/P/OGGmypKFx6bv6qK0UktSOQIo2byMTyl0AqOo9R+gM75nuJCHKhxL8 Gw+p+xxnnmTxd3OKxHh+qnaSqP/mMwXdXE+/WLz1Q47jRhdndzORIOWZQ2rccaMKvBOOrrTDt uM7BTfbdgRoji/JKsH+9aCX2rT7uCNkFyfkqvKU2csF/1zYUgorKron4tuou5gqYzpjS1aDwv EjlMEDMZ3FksjWfArnttRigwodVVk9uOBXCuK7SHnlxeKjzuBQHRh1S2UUSHqsLdcO8SKrdap DnvAa/fxxXsbMxHGR6sgZaxHKKL+VWqDDzO5wtTm1fDZk8DIQkDe2ZtVgWG5WdcpY6lgF0aGg p7chuWjVpw2H2qIHl8f8UK1n0hr21TkUEBUug3WplHPAA+HhXe7E1hD8dpPUEFJnLExaW9LmG 7YAGlxW+DMk6nZs1zxILiSr3x13bDEgWEt6EqkpkpG2RY+yVmi6qnWWq1zFctVUdO5hupaEyr m2n0fHCMd5X0cxTDFtkbnEl00uKojTS+/TylOHs8y++F9XeLNBjO+9h8SW+VB77CJU3rMvJgt U1uTyaw4NtdbbweKumstTni9DqyjXeGNwqbo2zj1ADvKPb7mrs4kTFi27P7EJnlDiS4C1YuUm 2xk+7VbaI5sO9YtqVhA1tl/plGroaoa3sHO2Q8W9kPnqAkmcSVE3N8L0uzdRz9lRzAQIcackP K3R2uuweLeL/beKwf7s+pcPJbRvHkLPg09vgKJhKmZYMYE95CUuLt5dCmuU21oRoGTE6NgW24 thXPCQupgP9wmKiYgUoFn2bFvVvWlr6soIc/O28I6hV7w= X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org This change follows two previous fixes addressing multiple definitions of __memcpy_chk and __mempcpy_chk functions on i586, and __memmove_chk and __memset_chk functions on i686. The test is intended to prevent such issues from occurring in the future. Signed-off-by: Gabi Falk Reviewed-by: H.J. Lu Reviewed-by: H.J. Lu --- Makefile | 7 +++++++ 1 file changed, 7 insertions(+) -- gabi diff --git a/Makefile b/Makefile index b5ef98fb04..adf4749124 100644 --- a/Makefile +++ b/Makefile @@ -577,6 +577,13 @@ $(objpfx)lint-makefiles.out: scripts/lint-makefiles.sh $(SHELL) $< "$(PYTHON)" `pwd` > $@ ; \ $(evaluate-test) +# Link libc.a as a whole to verify that it does not contain multiple +# definitions of any symbols. +tests-special += $(objpfx)link-static-libc.out +$(objpfx)link-static-libc.out: + $(LINK.o) $(whole-archive) -r $(objpfx)libc.a -o /dev/null > $@ 2>&1; \ + $(evaluate-test) + # Print test summary for tests in $1 .sum file; # $2 is optional test identifier. # Fail if there are unexpected failures in the test results.