From patchwork Tue Dec 24 06:56:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitriy Chestnykh X-Patchwork-Id: 103662 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 310663858D1E for ; Tue, 24 Dec 2024 06:50:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 310663858D1E Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=nI+yAUCo X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id 57B073858D1E for ; Tue, 24 Dec 2024 06:50:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 57B073858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 57B073858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::229 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1735023011; cv=none; b=loL2mqzPbCheVF51ttjaYNDme7+4xMVnwJbIdizf3hSAUlt9SBaGA8dfsKQVUQV6dCtibgZG93pLyyHZL30NPSGUFCSka9lbmVW7sekrpp2xlCUwlMD3x8PQF2o1hfZxftqh7Iry+MzcVh/gWk0tkGKgrphDWsLa4GPu7tCNEMI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1735023011; c=relaxed/simple; bh=tU3S3oH43PDrEG/lDPW4Q/aQlVqkMlarLLy8zOzSl+0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=GdtQK1Oba0X/FoNgop6FT8bZVpnGKAlGYZZXqfl8AlI0ukvJffa/MUTF2Z/0rhV9OICGf3Q0INwbE/RgjZrU3wCi9piyz2iiBRVXSh4K0l8uzAzpV/kbUJRuWOJ1QLlef6g9povJlGHWBX5dKdmcPb8gOjqgEbctKrGfvolpV/I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 57B073858D1E Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2ffd6b7d77aso62511061fa.0 for ; Mon, 23 Dec 2024 22:50:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735023009; x=1735627809; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2vhFbFZeu7yrQKYooiOXgfi7Zy6KFRfLlB7EskAIvVI=; b=nI+yAUColNSZZOOrlZolD1q0Fru4kwYhK+EfMhSiS5gk2oQBhm3ei71c11CVbpDjuu ZCn4bGSlvVu1wpkA6solDa83wuAQgAssG28x0FYvojSz7kSgiNiy7z1n7PyuFe0i/4Lj DTneuVWSpflBcJid4ot0ZeieTNmmXveX3Vxq1PqNnrJkcOsb1kICyJUyv1BEFxGHsl2b j4ptsl9yZ1xEk2SpNZBJRS5kiTGtQaYEo2D04ZdZ0Ts5WJivnA6P3NCKftBYlhwqZLJB vakup44Uy4WAgLt2rUUsukp5KodQ3+SuEI/SAaMIHHcv/sRLfmBesg6VE1MWMjYTDuWN ScCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735023009; x=1735627809; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2vhFbFZeu7yrQKYooiOXgfi7Zy6KFRfLlB7EskAIvVI=; b=gfOPTwtviUEr0P+Sgs1kyeR/DCFE62q6jONpRQbNr2dc2eGo+XWj/JLJaAVbPIxvKB JF+yl3dB/osqUs82kSV9XBNbUGyf+5nqHWjy7Oi+cyG/U56equ+KhJvK+W1Sxmd30QFN SvUagv6ki5JWwDLm5vooKeWH7jXqXPEtOYn9rOLXsUw5cto6HD/UksMNWxAl3/vNO4sr NABC5n6wLVHfg2XxyKiV1PWC7eWMg8H2slYDSOgXfZzIdcink9Cu+umdLFxkINiKstSi dk8Q1ePD0a98Vls6iSE1xnR0cniYXE5syVfBaoLNd9ScW51n9oY7K6W6pPMbsWE5uQXC LO2A== X-Gm-Message-State: AOJu0Yxw8ischBFRK+MfdU8PPkA1iwhNFIoXA5c8QG548DUUf5FKmXGa cjiwoSE7MQOLhy6zzTaSpBFUTUGakUm7KaqkVbKMSgGAUd2SXG1kAFuk9w== X-Gm-Gg: ASbGncuuoSQuHlHBvzJiBExfKzRq7qgZyhULaifd0fh9F1NzoasXXch3NjqPSepRFH2 t6RtxzEpIbdFl+rKCtldYZEeZkgOIZjRzvhsRfBFYsWinN7VJAPFhpaMvuoAnRHtQssEplcCkEh 2iIGi2sCBkJAsM6sG837TrrP6nEVuZiQP23p7slA5fE36m0w4iIqtqU6nmXccF2Q7mIo8On/gyo asaHEDNI2ccG5MV+ZWzvOEMT6DLOrSe5xjJswOo7nivHQZRl/QRpPlmSECMdmSLC9QTJNtvUejE X-Google-Smtp-Source: AGHT+IEoBsoMGTQlpjBNiZPiT1ud6yHUhoI65Jh7h0xtnojWpH/Wk6a8CJr1VcXXvMogiAku8I12BQ== X-Received: by 2002:a05:6512:350f:b0:542:29a6:a067 with SMTP id 2adb3069b0e04-54229a6a09cmr3822531e87.6.1735023009094; Mon, 23 Dec 2024 22:50:09 -0800 (PST) Received: from localhost.localdomain ([2a00:1370:817a:504:a78b:6e1a:bd3c:9751]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54223602498sm1538598e87.91.2024.12.23.22.50.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Dec 2024 22:50:08 -0800 (PST) From: Dmitry Chestnykh To: libc-alpha@sourceware.org Cc: Dmitry Chestnykh Subject: [PATCH v2] stdio-common: Use clang with bugfix for bug28 Date: Tue, 24 Dec 2024 09:56:32 +0300 Message-ID: <20241224065632.241399-1-dm.chestnykh@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241223171112.40815-1-dm.chestnykh@gmail.com> References: <20241223171112.40815-1-dm.chestnykh@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org The issue that was the cause of hang was fixed in upstream Reviewed-by: H.J. Lu --- configure.ac | 15 +++++++++++++++ stdio-common/Makefile | 8 ++++---- 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index fc5ddb8561..5f60b523bb 100644 --- a/configure.ac +++ b/configure.ac @@ -665,6 +665,21 @@ LIBC_TRY_TEST_CXX_COMMAND([for clang++], ) LIBC_CONFIG_VAR([have-test-clangxx], [$libc_cv_test_clangxx]) +if test "$libc_cv_test_clang" = "yes"; then + conftest_code=" + #if __clang_major__ > 19 + #error clang version > 19 + #endif + " + LIBC_TRY_TEST_CC_COMMAND([for clang], + [$conftest_code], + [-c], + libc_cv_test_clang_19_or_less, + [libc_cv_test_clang_19_or_less=yes], [libc_cv_test_clang_19_or_less=no], + ) +fi +LIBC_CONFIG_VAR([have-test-clang-19-or-less], [$libc_cv_test_clang_19_or_less]) + LIBC_TRY_CC_AND_TEST_CC_OPTION([for -fstack-protector], [-Werror -fstack-protector], libc_cv_ssp, diff --git a/stdio-common/Makefile b/stdio-common/Makefile index 3f84de3e36..de9e883c03 100644 --- a/stdio-common/Makefile +++ b/stdio-common/Makefile @@ -317,10 +317,10 @@ tests := \ # tests # Clang 19 takes a very long time, it ran more than 27 minutes on Intel -# Core i7-1195G7 before the process was killed, to compile bug28.c: -# https://github.com/llvm/llvm-project/issues/120462 -# Exclude it when Clang is used for testing. -ifneq ($(have-test-clang),yes) +# Core i7-1195G7 before the process was killed, to compile bug28.c +# The issue was fixed in upstream but check if clang has the version that has the fix +# https://github.com/llvm/llvm-project/commit/99dddef340e566e9d303010f1219f7d7d6d37a11 +ifneq ($(have-test-clang-19-or-less),yes) tests += \ bug28 \ # tests