From patchwork Wed Dec 11 14:03:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cupertino Miranda X-Patchwork-Id: 102816 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A6B763857BA7 for ; Wed, 11 Dec 2024 14:04:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A6B763857BA7 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=oracle.com header.i=@oracle.com header.a=rsa-sha256 header.s=corp-2023-11-20 header.b=lQr99Y36; dkim=pass (1024-bit key, unprotected) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-oracle-onmicrosoft-com header.b=T7x9nM0C X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 740CA3858D33 for ; Wed, 11 Dec 2024 14:03:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 740CA3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 740CA3858D33 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1733925824; cv=pass; b=r79TnGrnqPENW2Q4gA4cP6lxijTKhsoPcyLFEfKY7wBgLIV+YIHpd7jyXkewbhlLPNSNp1R53sfoOuqvS3RLUtIz9Nhz8iJBYLakwdRyeB0SQ2u0CAjRaoH81uCd7VCOBN0EfbuNrp93BsS1pz8pMKHyzpZle9qrzWQhcbJZflw= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1733925824; c=relaxed/simple; bh=DEfnkpA1o5Xsyu5HRx9YLjyzZS5r4+ngWO9+zV2bLws=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-Id: MIME-Version; b=MX1YkACvwYULfWtkfgrSN9N05/ialxuZZ3tBVjNiq/oJRhBuc4i9xnEo/7h96mVWuCxqrjZPdtuTwLiDbmp1ewBT3oObaTof5vcOZa3Fds8dP2pcakPKBcccpgy4oZsxQufilGTS9n7ZavgTVQwjZuKQwTvq5neeIcHkzijgcu8= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 740CA3858D33 Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BB8RaIt019196; Wed, 11 Dec 2024 14:03:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=corp-2023-11-20; bh=vO0BjZRIWxfqTnDw OG1EI6fdxaWxw7orvEiyVEJlRz8=; b=lQr99Y36Ui39WpUYjanni/Fn+7hWmSw+ Dj9u2EPyvWIyjhjqtb006GNdTAVLxB6dqb4uCQYwos8q7uGF2BrU5cytJaC2aTvU By9CD6iZnQQo1WzksijqmBy6ozTEizEWFkn69jBBFaEDJtFieGubCqupw69Z3zo+ zqqzZLA9fc287RNjToKyQ2ejXEdW/u3dNig5sD3MrPeU2y0ARCcqWDzRNiify72B quKJzV62MeY3BKjMN6xm4m+KXDtIDku2osXNgsNnsgFTKkIbhuoYaYPnh1pqIvSp ZEaLB+fCxPfDx5josk+FuRCnZ90L5MleR0e488kYA98+A5RzZYF4HQ== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 43cd9arvbq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Dec 2024 14:03:40 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 4BBCOTrq020616; Wed, 11 Dec 2024 14:03:39 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2049.outbound.protection.outlook.com [104.47.55.49]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 43cct9rct2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Dec 2024 14:03:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eshOZtPl+epuD2x/6HOLB6l239sKs5DvhAvh0ex1uiHiuf8EquyQCM1D+ft3E/qE74g+p0dxlysqng847pe0R+gWHn7s2OMhTyR5vjSkycz4mKL8QJWg/Rl+vB/roOFHRWFKgORxuqZ5L+hrPhlx9rFdzLa8ZNpZOa30F6DQCWTZ1MYZvnJ43paeiZDB/Jh69hthyJG7fw4de4Mg69rpVPHC/MAauClhFkAHqPIp99pT3VrwH/LTPNdxxvF8wWfKM84iOeC1bC3Dq/Shk+Nln2uQTBk5TsjJnvSmTmjG06mBP8Y5UaEKjsUJIYOiJjHG2Cav+EN/2U39ef2ER4VSIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vO0BjZRIWxfqTnDwOG1EI6fdxaWxw7orvEiyVEJlRz8=; b=Chw5qINMisGhkaMB08SRyDVM6N5pWQWWLwycHDmQ6CcMq3T3ndylr9tGN+OP+bqE2mQEvhY12oENJVCsahUtf7yY1eyrd7V6VzAfDghZQ2wPJz6KOkQy5RBjqXA4J0XLQwJOtq4RTKa61hlcuIEmfcCUBL1tYtZ6wJL+HEzaiwHhUQm9Af314TwF1VleHqhcQl3yA5WGquga+hFTmWeskPF45fbncdY7nfI78E+Kq9TMFCD2pDJ7U+uEGIWzBTCc3O87pO24ZZ4/ueic7p7Sh8By4ApLcq5h/ZnZA4c5sih5M/1WdXarSu4iDiUutr9u8aYi5yBLJsn+LbgFAjLYvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vO0BjZRIWxfqTnDwOG1EI6fdxaWxw7orvEiyVEJlRz8=; b=T7x9nM0C95J5WTpMN1aBsnKg+CHPPnSlyvSNnW0aHYZjRPiwQhleoHw7yMcG6xN2mhyQAKem1bkhOtucSq638MQNjUWIjyVqrXMePnL9Lny1cuyvOGdYfUiZqzUsOEq1Z89DOhg9oSy/0GuXngyCMOrb2u3z4hBw/CW0K5jQgFA= Received: from MN2PR10MB4382.namprd10.prod.outlook.com (2603:10b6:208:1d7::13) by CH0PR10MB5068.namprd10.prod.outlook.com (2603:10b6:610:c7::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.15; Wed, 11 Dec 2024 14:03:13 +0000 Received: from MN2PR10MB4382.namprd10.prod.outlook.com ([fe80::5033:84a3:f348:fefb]) by MN2PR10MB4382.namprd10.prod.outlook.com ([fe80::5033:84a3:f348:fefb%6]) with mapi id 15.20.8230.016; Wed, 11 Dec 2024 14:03:13 +0000 From: Cupertino Miranda To: libc-alpha@sourceware.org Cc: jose.marchesi@oracle.com, elena.zannoni@oracle.com, Wilco.Dijkstra@arm.com, Cupertino Miranda Subject: [PATCH] malloc: replace _int_free by _int_free_chunk in sysmalloc. Date: Wed, 11 Dec 2024 14:03:04 +0000 Message-Id: <20241211140304.195483-1-cupertino.miranda@oracle.com> X-Mailer: git-send-email 2.30.2 X-ClientProxiedBy: AM0PR02CA0001.eurprd02.prod.outlook.com (2603:10a6:208:3e::14) To MN2PR10MB4382.namprd10.prod.outlook.com (2603:10b6:208:1d7::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB4382:EE_|CH0PR10MB5068:EE_ X-MS-Office365-Filtering-Correlation-Id: 65cca7b5-6f74-4902-3e47-08dd19ec8cf4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|376014|10070799003; X-Microsoft-Antispam-Message-Info: hs4sFWgDuFrpryaWYNdknV8luBvQQP1GFqwswiMo83DA7sk+RvqOfyMlNZ0xzoWTve2JAcZQPRS7eOyu0qLdbyeKMd2xSh/wz2xBNDAdkD91ek3EfUwVxV05+kzU4ppppxPzRP1HgHCsx7A/QF+8qqQ1ByJ+JNSe8HgT+axGgM3y59JKVmVbQsxXi2GOZHq/7t35ev7P7suYkQfH9rxPy6EKfCxJnpzJwjVpaY2EbBjLpGT1FKJd6PkqAaMzi1cXIauHqKvO+gN6NCT9KlNl0vrmhXs1vEL2tK+fKiVx/US3yTWXJCTu66sC1sFZh7HEblXc4budgNRQOyH8CkxcHaU548FFQw4gwBP4BLFMy5A6fyOS4RHoPh+Bc3nhq/mlEC9O0cRMkjmHGoYZh/QjJtg7gq1BefHlQSZob4wO0iTZ8QCre/1kgSmQvyOk22sQ+e0shKS8X3ltN5pRoooMuffWFrTpo1/+EqqH8+V8aEEF60gobzxiJV4W3IeLie7s2TuNf6mDtj+T1qBwLxRasprJR0QDmqcF/RGpwv4vhZWqgaH2XBCTL8bsUViOt6M0L8Lyri7CVcviu4Ig6Kkv7xfxeplzqLY06AbtPi+dMfbfxOpFQ68RY10jWLSaRxPcASm6ddnE67vT2+xE1ggvUaPlflAf46zkkYZL05RfoPMQ0Ig6qSo86qW+QPQUn3XWZTVDcVQnm860fChFedT9gfMwzd0g7FtPiSS5BW5kGiFtLLVIl2MNIlM6e/3pXI95T4ro1ysCQhVriM2h1k3CFeiCxu74nCk8xj/Xp/fUPECxi1B5+pA5czfWbHYVZL8S/idEZ6P5KtfJr2zffd9ollZPFvTieNENM1tRoCJa0fKohUC+3l4YR4b8jiekFUTnTJizYb5OsiDd628GI/+BmWdiX/oCvqa6guwRVA5AOEXofYCZriQs+SDs6ib6FgtJexJZCuvfaGRW4jChrMHNpvSeyrKZcmvQr6RL53vANnF4ZRc9mOlCZwk3pJ8PwDFGxko35SG1WLlhdJsXwrZiVCaQPSdaV3RoOK/BAoTA6f1EoKUwynOK3kbdohLJeCmpmJ5uSTH36+LJKoFaOOcfI415ZNCNb2YVNHiLURtbupU467PW2vyEbtxOcIzty0cNx2XFwEtcLFQ3FnQIV4kKlSs2FLp9oA6JK1JOS4e09+WRi/relmrb+QvkodVQR53FkuC0bkEiRjfMcSE0r2XL2WaYMGcOJvJ2POQDk6DbTmSj4zdXQ+p8kygZTEP6ah5tPJx6u3vznM1epFavnUNHTGSfzYg3SORkJ00n7w/CPWPqrtDWp1P7+52yQmJXcDpDzn5N1rlon07dtxB2EnLz3Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR10MB4382.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(10070799003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: IDcrhq0e+y09TVzn4LA53VaLN+eMFnFcR3uKsEf4v7K2CPgL/61vbFAUs+nhLnDvJ+B31nuL1RgFQJBnhmv+7TfV+8urc0zK8uiH5XXXUscRgC4gM7onRuBfYNEWE7+Q0r74RvvAKHETwP2L1QewKiv++Kd5Uprb3Rs5ELuZDoYD+gOxX6co+dRZGdqgaA7QLDF7k0foP0//W8F33/4m5G3zL8PB9YqHM5+nl1eVC3KDgybddcwA82g6LpMxKkHGT1Gr6zy+7dyhv+ddQ1ekk03srA/a63wRJYhQfYaGFf0V/u7d1yZ3QjMwAACvy7w4eX/jwwlPN6K8hkiOuCNLld5BRic+nyt51zOoIpxr4ALdt89FXWHcZVGdINVkMk/Cx3NaRa+zxz0U8cGFEIKqBFRmRWc5geVm+63jpQpFE25E891PvTalphGw97dGoBG1Yvj+9XP/3pBx2+5JPOpQ6+wyeyZmo38H1jT3njN4DdtcGHtgOzap1v0oHRBzqyD+IJAAxfhxZyctOk4WgShzdqVtyNoc2fKmA2dENjhTkKY8odTc4xfsrKeyYO41Z/vbbWeW4NEefrg09Qiu9a8gxbHBgVoBhNV05jrkIgJGQQvSer7A5/y7o9rA7haH6+E3tKtZxfMOuUN1SXwqHUsbZYqecbqof4U0XxWbKE/JK9Vbb/UMTi/VKbZJf/VswumILrVYtDXM0HWD9iheaK8oL8Kfjv6vVngzn6xtCS7hWeuJBNyW/g35n2fhGlmmlCnUguaRCoSHZyT4MetgSSUzegSYJtDUrrkDceUJAL/mqXpOFlZzj68V4v1jLvBqARTM0FXfHSxFxFDe0Q7ZneQw3vE1jsTAEMy1hBkpDXix5YD2goAapmdY7Yx9GowFCshuGrUz7eAX94H1+VVQeWTTvzpeJGLZ+IW2X471Tmf8mSOKUWKOESdATHRjvAZIBtrXtbpdqTGNNel+2zlIX8m/SRkqy1pzfaSqBqPpKnfqI+0Vqc3eExw8JSTaP5Ajcf86yprK/vyOV9zkYILLmmMz2DcUe0/JxJQ9T5YVqgPGAbVlx7gRVX0tCmwxV+FBMgX65kYV7Obg4kV3BU0AODTbr9wrI/10jqCPtGkRRsUMbwd03gLq0/qjFtRu+GM28QOMUfu9RUECtqrzmvp3E3/i1TvtWhHIxb2JP1TDfbgcW+FjcxuI+263ipGNbdwi7iowYb7OTpHJStOckSCDzqSKIJ8cHvOIUzYlO/2l2ADngEiS2kUuvrTxJ5Sshgp0HFuuG7P4M+dCUfADP7hu4B0tt2mALTt8UdBdkbFis3DsWWX1v8Lf5jCwwxQJ9+PwFuiGExxpcgwlqLGzkvfXNQSlxsb+VFT5tAzx6gMkphsQ34GyXLEkmRgXitrFdnSnRQd1LrO1CpGdP/8HqlgTsG9w/hvm2gCI2l37QmuC3cjMo309+y620QpHZxcExnEvFDmszp1dRFezFd8LPRRoj4pEWA99kMTolvTN2cIMfDIuuXajR3+yBCzVF5/YkUs9e+OQbs13tTUwYsixg9ORAX6c5EZA2yAfb9xQAVNM1NPTBiwN8Ns/JAmskcajrsBHtknMwY4/fso/ZKBiOv49S54fuKF7snoipf1bldx8CsIlNZo= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: EWWIZWk7y+rWAPOdKkA2zZoAP/CGccrIEex5gmvgKh/W8PW11XuwmnFKZex9rEahITnZ9Jmyo2muZkRnXmIvm6Lmlr4ikXYe/BFod3/9u/Mk3IvfbHx0V4G3ZmyksgV7bTm54uXZ80fWIS/zeKJhLDRhf29x8Kg5HCFsb8gDm2ezYEQyXcbEb2Q9KhA/ktf4sLYv6IUPMCq86L4lAOL8dx2VcajRWq/H8lxJOElMfR2SDMlfI085ljBeJiFjG02AWvz2PL5kTyCAnGGKdBp7e05GoOQg8ufklhwHb1ogFQEe8hwi5gCXy4dJXwAzu5tL6QkuYxCnO7fLzsT9vVJTH2ORLdzbswpuBlno/tLAoC3mQg4gVRjdOGvU60lGdGnk/gccbedOsbvDukcIMHmqMBCTkVEfrdhpy5GAvug9fViCJF0VuqHmYLkBRzO5qtHurpl2R6NzIPwsArlzJKBbNk23q3pAlpiwZXCziQvS/ERpEmep70Zv0ZdSZIKJ02KPBKrUG1GO3sznwtTWB/nPbxP8vTszduIbk+bvLag8D2ouOZgBTkQE9baupmSS6ziPdv2Q2nNyuyAnHWj97cqt2Hrpt2mHUtr/BYvihMOtcuA= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65cca7b5-6f74-4902-3e47-08dd19ec8cf4 X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB4382.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2024 14:03:12.9094 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PhgyMxnH44rJ3wglp6anEs4Bt5xMxxFm5JtsNq+rsIPUGji+RAtb8ZWUcDy8HYSAbDr2T/fLo0mDUTFm3o/MBhTGRRbhwso6bE/lsobURb0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5068 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2024-12-11_10,2024-12-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 adultscore=0 phishscore=0 suspectscore=0 spamscore=0 mlxlogscore=648 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2412110102 X-Proofpoint-GUID: gP0r9Mn77sKVr6mHntUfTTeQrCnpAW87 X-Proofpoint-ORIG-GUID: gP0r9Mn77sKVr6mHntUfTTeQrCnpAW87 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org Hi everyone, Wilco, As previously suggested, I have isolated this patch from the tcache improvements series. Looking forward for your review. Cheers, Cupertino sysmalloc calls to _int_free should not allow the freed chunks to be taken by tcache. These internal calls to free do not reflect any of the needs of the application, but rather chunk management. This code replaces those calls to _int_free by calls to _int_free_chunk. --- malloc/malloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/malloc/malloc.c b/malloc/malloc.c index f16f89d283..6f5e875f65 100644 --- a/malloc/malloc.c +++ b/malloc/malloc.c @@ -2646,7 +2646,7 @@ sysmalloc (INTERNAL_SIZE_T nb, mstate av) CHUNK_HDR_SZ | PREV_INUSE); set_foot (chunk_at_offset (old_top, old_size), CHUNK_HDR_SZ); set_head (old_top, old_size | PREV_INUSE | NON_MAIN_ARENA); - _int_free (av, old_top, 1); + _int_free_chunk (av, old_top, chunksize (old_top), 1); } else { @@ -2912,7 +2912,7 @@ sysmalloc (INTERNAL_SIZE_T nb, mstate av) /* If possible, release the rest. */ if (old_size >= MINSIZE) { - _int_free (av, old_top, 1); + _int_free_chunk (av, old_top, chunksize (old_top), 1); } } }