can't find file to patch at input line 141 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |From patchwork Wed Oct 20 20:22:41 2021 |Content-Type: text/plain; charset="utf-8" |MIME-Version: 1.0 |Content-Transfer-Encoding: 7bit |X-Patchwork-Submitter: Alejandro Colomar |X-Patchwork-Id: 46466 |Return-Path: |X-Original-To: patchwork@sourceware.org |Delivered-To: patchwork@sourceware.org |Received: from server2.sourceware.org (localhost [IPv6:::1]) | by sourceware.org (Postfix) with ESMTP id BBDBE3857C75 | for ; Wed, 20 Oct 2021 20:23:57 +0000 (GMT) |DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BBDBE3857C75 |DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; | s=default; t=1634761437; | bh=yK5Gm+fT7CHdXo7oAn9kPEc/l84vCob4Uc/ehHZArJk=; | h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: | List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: | From; | b=ncNHotsYwX/fz7rG9cMjfhs5Wj9SsXSubGZZf0wAxEWMy98ptb4z65kJP1OkktXuJ | 4E4iF+cMKNCxQ96uyURz9nQsjwSTsLhCAGqJxmfS/wtzBA7O40pF7eWx4/4+NA/gis | 9eiBWtZjHzI76HAQWPwMYrV79bR80jDGwNUKnlKc= |X-Original-To: libc-alpha@sourceware.org |Delivered-To: libc-alpha@sourceware.org |Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com | [IPv6:2a00:1450:4864:20::42d]) | by sourceware.org (Postfix) with ESMTPS id 8B4B33858409 | for ; Wed, 20 Oct 2021 20:22:49 +0000 (GMT) |DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8B4B33858409 |Received: by mail-wr1-x42d.google.com with SMTP id y3so49354581wrl.1 | for ; Wed, 20 Oct 2021 13:22:49 -0700 (PDT) |X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; | d=1e100.net; s=20210112; | h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to | :references:mime-version:content-transfer-encoding; | bh=yK5Gm+fT7CHdXo7oAn9kPEc/l84vCob4Uc/ehHZArJk=; | b=IwZ9CIrrL6wPSxfq4st+zb/ih/A7/O5KD4sC6MW8tCvXxhXzZl1LKSIYmGOmYuVzen | kQhr4X895L806ppRK2dQTdLnuZS5fJdrwz0ysU2Rg+sucqaN1de9saPHF7dwyX3lkE2Y | s2qMxA2o84HTcwvNcnm78XStHF9eLP/ld9jYRFKut8P3K//4kXgzcCiY8uaynm989oTe | rvXyeUBaKHCxSdML7yw3wK20GwismCcEZaWA0xIbkZHw0avZmInKrT9FiVNsTHTiHg1r | 49Mo93haEk6ymLEvg7BWIlyX1OmuKNIzbDoDfsbX8TogDMN6CoCtNWoxPAhQs+ENGj7M | o2AQ== |X-Gm-Message-State: AOAM532w5CEVFaiqz8EkGlgMDNDYeZj3GkbSOp2IbujdKt5gA8yNFIwa | wbCQGzFu+hvNFhFYHsAiESI= |X-Google-Smtp-Source: | ABdhPJwIFOc0/R3MDTIJkOmc7jPZI9TMCFtzc2HudhoUZTf7pAU1XrMJZClkzuKN/wtcF07YGj+/0g== |X-Received: by 2002:a05:6000:154b:: with SMTP id | 11mr1705520wry.422.1634761368653; | Wed, 20 Oct 2021 13:22:48 -0700 (PDT) |Received: from sqli.sqli.com ([195.53.121.100]) | by smtp.googlemail.com with ESMTPSA id n11sm2892949wrw.43.2021.10.20.13.22.47 | (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); | Wed, 20 Oct 2021 13:22:48 -0700 (PDT) |To: mtk.manpages@gmail.com |Subject: [PATCH 2/2] ctime.3, strftime.3, strptime.3, | timegm.3: Add [[gnu::nonnull]] to prototypes |Date: Wed, 20 Oct 2021 22:22:41 +0200 |Message-Id: <20211020202241.171180-2-alx.manpages@gmail.com> |X-Mailer: git-send-email 2.33.0 |In-Reply-To: <20211020202241.171180-1-alx.manpages@gmail.com> |References: <20211020202241.171180-1-alx.manpages@gmail.com> |MIME-Version: 1.0 |X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, | DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, | RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, | TXREP autolearn=ham autolearn_force=no version=3.4.4 |X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on | server2.sourceware.org |X-BeenThere: libc-alpha@sourceware.org |X-Mailman-Version: 2.1.29 |Precedence: list |List-Id: Libc-alpha mailing list |List-Unsubscribe: , | |List-Archive: |List-Post: |List-Help: |List-Subscribe: , | |X-Patchwork-Original-From: Alejandro Colomar via Libc-alpha | |From: Alejandro Colomar |Reply-To: Alejandro Colomar |Cc: Alejandro Colomar , linux-man@vger.kernel.org, | Jens Gustedt , Glibc |Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org |Sender: "Libc-alpha" | | |C2X changes the prototypes of functions that accept a |pointer that cannot be NULL, to use 'static', which clearly |denotes that passing NULL is Undefined Behavior. | |For example, 'time_t mktime(struct tm tm[static 1]);'. | |This change is backwards compatible, since array notation is just |syntactic sugar for pointers, and the Undefined Behavior in case |of a pointer already existed (in the wording); it just wasn't |clear from the prototype itself. | |However, that forces the use of VLA (array) notation for something |that is *not* an array. It is cofusing, probably too much for |some programmers not so familiar with the difference between an |array and a pointer, and that happens more than we would like. |Even for programmers that clearly know the difference between an |array and a pointer, this is at least misleading. | |That happens because the standard lacks a 'nonnull' attribute, and |only has that (VLA) way of expressing what GCC can express with |'[[gnu::nonnull]]' (a.k.a. '__attribute__((__nonnull__))'). | |Expressing that NULL pointers shall invoke Undefined Behavior in |the prototype of a function is *way* more readable than having to |read through the whole manual page text, so ideally we should also |follow the standard idea of expressing that. But we can make use |of more advanced techniques such as the GCC attribute, which help |keep the information that those pointers are actually pointers and |not arrays. | |From the 2 different attribute notations, let's use the "C++" one, |which will be part of the standard in C2X (unlike __attribute__), |and is also shorter, which helps keep the SYNOPSIS short (mostly |one-liner prototypes). | |See | |Signed-off-by: Alejandro Colomar |Cc: Jens Gustedt |Cc: Glibc |--- | man3/ctime.3 | 26 +++++++++++++------------- | man3/strftime.3 | 1 + | man3/strptime.3 | 1 + | man3/timegm.3 | 4 ++-- | 4 files changed, 17 insertions(+), 15 deletions(-) | |diff --git a/man3/ctime.3 b/man3/ctime.3 |index 0620741e9..42021a588 100644 |--- a/man3/ctime.3 |+++ b/man3/ctime.3 -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored can't find file to patch at input line 182 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |diff --git a/man3/strftime.3 b/man3/strftime.3 |index a24ea720b..715b30edb 100644 |--- a/man3/strftime.3 |+++ b/man3/strftime.3 -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored can't find file to patch at input line 194 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |diff --git a/man3/strptime.3 b/man3/strptime.3 |index d6595d4bf..c1b334d87 100644 |--- a/man3/strptime.3 |+++ b/man3/strptime.3 -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored can't find file to patch at input line 206 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |diff --git a/man3/timegm.3 b/man3/timegm.3 |index b848e83e1..18b6e4847 100644 |--- a/man3/timegm.3 |+++ b/man3/timegm.3 -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored