From patchwork Tue Apr 14 22:41:52 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 133056 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 4784E4BA543C for ; Tue, 14 Apr 2026 22:42:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4784E4BA543C X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by sourceware.org (Postfix) with ESMTPS id 009EF4BA2E04 for ; Tue, 14 Apr 2026 22:41:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 009EF4BA2E04 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bounce.ens-lyon.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 009EF4BA2E04 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.77.166.138 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776206517; cv=none; b=bpMSQddRZmM8CESDfjhSP2HkWuVOmtFlwHJ3Scnt4ySbgbBOjYp8IcyWW90LEU2pZoQ4du1p5l2Bte6HUNKZpTGiU5uMN3mwkoq7tYFSpZDk0nAtaX9eJwqjKnDfF2TdBUbNxEBwN/99DhhCSjx7rIpiEaegk/vK0qpiiMZt4aM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776206517; c=relaxed/simple; bh=pLyuGJX0rcEy+FHBHSIyNnFyB+1mjnWJQPW3YWttkic=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Uuh72l2iOkm+gt0NGHQ6GMtzaHPsa26XFEyF3+VVeVRirt9nzmaosTe3ad+hoItT+Vi0WHWzJObyAMwIawRQYzGlpSEIH/3DtsHYStGWBq7WBXEjlJbW3p46fqv3+LxixOv9jVqq1H6X2j0qpy8GK9XOsT/RIpZ0vx7mQJCk9W4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 009EF4BA2E04 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 69172A04F9; Wed, 15 Apr 2026 00:41:53 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O6MCIWQxszLw; Wed, 15 Apr 2026 00:41:53 +0200 (CEST) Received: from end (aamiens-653-1-40-48.w83-192.abo.wanadoo.fr [83.192.199.48]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 28E5EA04EA; Wed, 15 Apr 2026 00:41:53 +0200 (CEST) Received: from samy by end with local (Exim 4.99.1) (envelope-from ) id 1wCmS8-0000000322l-2ZJ0; Wed, 15 Apr 2026 00:41:52 +0200 From: Samuel Thibault To: libc-alpha@sourceware.org Cc: Samuel Thibault , commit-hurd@gnu.org Subject: [hurd,commited] hurd: Fix looking up /dev/tty/ (BZ 34070) Date: Wed, 15 Apr 2026 00:41:52 +0200 Message-ID: <20260414224152.722832-1-samuel.thibault@ens-lyon.org> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org We need to keep the heading / to properly get an ENOTDIR, and set file_name rather than change the retryname content. Also, *result is normally used for the startdir. --- hurd/lookup-retry.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hurd/lookup-retry.c b/hurd/lookup-retry.c index 94ff0e3222..2a5ea16cba 100644 --- a/hurd/lookup-retry.c +++ b/hurd/lookup-retry.c @@ -323,9 +323,12 @@ __hurd_file_name_lookup_retry (error_t (*use_init_port) err = opentty (result); goto out; case '/': - if (err = opentty (&startdir)) + if (*result != MACH_PORT_NULL) + __mach_port_deallocate (__mach_task_self (), *result); + if (err = opentty (result)) goto out; - memmove (retryname, &retryname[4], strlen(retryname + 4) + 1); + startdir = *result; + file_name = &retryname[3]; break; default: goto bad_magic;