From patchwork Sun Mar 8 10:42:09 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 131276 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id D42D34BA23C0 for ; Sun, 8 Mar 2026 10:42:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D42D34BA23C0 X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by sourceware.org (Postfix) with ESMTPS id 1E6304BA23C0 for ; Sun, 8 Mar 2026 10:42:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E6304BA23C0 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bounce.ens-lyon.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1E6304BA23C0 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.77.166.138 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772966532; cv=none; b=cX64n46mDevmc0Z0uz2SyP7TTog2boSId2GUgtz4reQF37JL4Pei8FAzJEM36Af4Kh+4WBWQP1NFC20d+qWHCqm8P736drwOrSYRNqvlkoxfrTHNfYz5+YGUIOzw11TIDb1A73VMkHgGoEc4Vel0X3FQmL2cCaP7EKVXwBq5iCw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772966532; c=relaxed/simple; bh=lKOmtNwUHSVS5DrxJD6uZwTGm+jWt/g0uXPVogZ0i+c=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=kXDNgX7+9f9xlfJ6tiB2s3wTM2GgDJbvhGzo7GNJp5WeVRpb8EyHEFAU31c4vpnPdicCkJYdW57RO904ody20UsDtINRIFRsYA65u54x1Kb6y+l+KbF/LWMHFXZB0pS4l+8iFxBTt46VaMNCfroOHDEqcomb5XnewyRU18OFv0I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1E6304BA23C0 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id D59D0A2062; Sun, 8 Mar 2026 11:42:10 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id avtBzIrTsOjs; Sun, 8 Mar 2026 11:42:10 +0100 (CET) Received: from end (aamiens-653-1-40-48.w83-192.abo.wanadoo.fr [83.192.199.48]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id AE2A1A0286; Sun, 8 Mar 2026 11:42:10 +0100 (CET) Received: from samy by end with local (Exim 4.99.1) (envelope-from ) id 1vzBaM-0000000G3Nl-0wIU; Sun, 08 Mar 2026 11:42:10 +0100 From: Samuel Thibault To: libc-alpha@sourceware.org Cc: Samuel Thibault , commit-hurd@gnu.org, Brent Baccala Subject: [hurd, commited] hurd: Check for _hurdsig_preempted_set with _hurd_siglock held Date: Sun, 8 Mar 2026 11:42:09 +0100 Message-ID: <20260308104209.3826242-1-samuel.thibault@ens-lyon.org> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org Without taking _hurd_siglock, we could be missing the addition of a global preemptor. Reported-by: Brent Baccala 's Claude assistant --- hurd/hurdsig.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hurd/hurdsig.c b/hurd/hurdsig.c index b202d1fdfc..cb3e04ec0d 100644 --- a/hurd/hurdsig.c +++ b/hurd/hurdsig.c @@ -765,10 +765,11 @@ post_signal (struct hurd_sigstate *ss, handler = ss->preemptors ? try_preemptor (ss->preemptors) : SIG_ERR; /* If no thread-specific preemptor, check for a global one. */ - if (handler == SIG_ERR && __sigismember (&_hurdsig_preempted_set, signo)) + if (handler == SIG_ERR) { __mutex_lock (&_hurd_siglock); - handler = try_preemptor (_hurdsig_preemptors); + if (__sigismember (&_hurdsig_preempted_set, signo)) + handler = try_preemptor (_hurdsig_preemptors); __mutex_unlock (&_hurd_siglock); } }