From patchwork Wed Feb 4 07:16:41 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 129540 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 1BAA14BA2E0A for ; Wed, 4 Feb 2026 07:17:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1BAA14BA2E0A X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by sourceware.org (Postfix) with ESMTPS id 795E04BA2E08 for ; Wed, 4 Feb 2026 07:16:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 795E04BA2E08 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bounce.ens-lyon.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 795E04BA2E08 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.77.166.138 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770189404; cv=none; b=xpXbp2V7cvc1AgJfWbnR0mO7hjWx6el9tGGKdM0GnbMqOlKJUUsSj8iMKAINzQkBIkTglMcgcmeTVZpzUJgZH1TaQgWn697bLuaP9ImdximzH8tAZNZND5sT3UjkQ7C0w+wmGy2fQtdErqBrUjgFKzDdk7I4jgrpIwAJDXNfUwE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770189404; c=relaxed/simple; bh=sNhAY4kx9tttOWWs5wobmQJUYs6oBKaCZV+HB0kafJM=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=lQjxr204cNF3Q4qMxjKgFBt0FUrhosecG+7gUwNvM2tj7WLe8EwuWrxcnsZVzbo5FFN1Q0Rp0+MOn5V+JrjIVx8IpkdfrZG4Pw9f0tpsaZMLNzR0solFlxRokuUAlwYslvIdO+FYVQGFi5xPrUqRTHE6AqXwsuKdD4f6CAle58o= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 795E04BA2E08 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 606C9A73BA; Wed, 4 Feb 2026 08:16:43 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vRp-GEUyCTZA; Wed, 4 Feb 2026 08:16:43 +0100 (CET) Received: from end (aamiens-653-1-40-48.w83-192.abo.wanadoo.fr [83.192.199.48]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 434F0A1B6B; Wed, 4 Feb 2026 08:16:43 +0100 (CET) Received: from samy by end with local (Exim 4.99.1) (envelope-from ) id 1vnX7y-00000003RD6-3WHR; Wed, 04 Feb 2026 08:16:42 +0100 From: Samuel Thibault To: libc-alpha@sourceware.org Cc: Samuel Thibault , commit-hurd@gnu.org Subject: [hurd, commited] hurd: Test FPU preservation on double-signal delivery Date: Wed, 4 Feb 2026 08:16:41 +0100 Message-ID: <20260204071641.819573-1-samuel.thibault@ens-lyon.org> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org This test was fixed by 826484111a ("hurd: handling pending signals could result in corruption of FPU state.") --- hurd/test-sig-xstate.c | 31 ++++++++++++++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/hurd/test-sig-xstate.c b/hurd/test-sig-xstate.c index 8ddfbebcd5..9e7c77b560 100644 --- a/hurd/test-sig-xstate.c +++ b/hurd/test-sig-xstate.c @@ -43,6 +43,7 @@ static volatile atomic_bool startflag = ATOMIC_VAR_INIT (false); static volatile atomic_bool loopflag = ATOMIC_VAR_INIT (true); +static volatile bool doublesig = false; void handler (int signum, siginfo_t *info, void *context) { @@ -53,7 +54,13 @@ void handler (int signum, siginfo_t *info, void *context) SET_MMXSTATE (mmxbuf3); SET_XSTATE (xbuf3); printf ("signal %d setting a different CPU state\n", signum); - atomic_store_explicit (&loopflag, false, memory_order_release); + if (doublesig) + { + doublesig = false; + TEST_COMPARE (kill (getpid (), SIGUSR1), 0); + } + else + atomic_store_explicit (&loopflag, false, memory_order_release); } /* Helper thread to send a signal to the main thread */ @@ -101,6 +108,28 @@ static int do_test (void) TEST_COMPARE_BLOB (xbuf1, sizeof (xbuf1), xbuf2, sizeof (xbuf2)); xpthread_join (thsender); + + /* Now retry with double signalling. */ + doublesig = true; + atomic_store_explicit (&startflag, false, memory_order_relaxed); + atomic_store_explicit (&loopflag, true, memory_order_relaxed); + + thsender = xpthread_create (NULL, signal_sender, NULL); + + SET_MMXSTATE (mmxbuf1); + SET_XSTATE (xbuf1); + + atomic_store_explicit (&startflag, true, memory_order_release); + while (atomic_load_explicit (&loopflag, memory_order_acquire)) + ; + + GET_MMXSTATE (mmxbuf2); + GET_XSTATE (xbuf2); + TEST_COMPARE_BLOB (mmxbuf1, sizeof (mmxbuf1), mmxbuf2, sizeof (mmxbuf2)); + TEST_COMPARE_BLOB (xbuf1, sizeof (xbuf1), xbuf2, sizeof (xbuf2)); + + xpthread_join (thsender); + return EXIT_SUCCESS; }