From patchwork Sun Jan 4 19:27:57 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 127364 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id E75CF4BA2E1D for ; Sun, 4 Jan 2026 19:28:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E75CF4BA2E1D X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by sourceware.org (Postfix) with ESMTPS id 09DF54BA2E04 for ; Sun, 4 Jan 2026 19:28:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 09DF54BA2E04 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bounce.ens-lyon.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 09DF54BA2E04 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.77.166.138 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767554880; cv=none; b=UeiiaiEnn1Soz8ilUOIYqN40z+jV9AU254MMkyqJyptTlnd0ZPzEK1hEx8VouEhdDd8QKHOC05YJL6EV5Gup31aOnjXbwUh2BT060RQ4JIZ4KsSU+M9thzODggR27fLi3p/HvC4w79dePzPm/AUgd1eMbajQoEmaU8dh74LBnwU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767554880; c=relaxed/simple; bh=7JyjPCYHgJA/2DohSfo0beENpVlYySavMVaoD2bDBDk=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=diG6sUhZI9A6WyhWZkXxJp1N0Ax+ANGZC6jvpNOlt+VvYqWDZMcs7bxhfirX2PKKoqhauXY9XfbmY7Q9e0QYiIgq2y4M60jLfCkSPasJNttH7hFCbMqoDwBqPOf9k4hhH2prqLhXd1bZxp4TlqCdqWVhrAfuIWzMd737siY8IeI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 09DF54BA2E04 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id ECE2EA01E9; Sun, 4 Jan 2026 20:27:58 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pEbme7ZG1j4X; Sun, 4 Jan 2026 20:27:58 +0100 (CET) Received: from end (aamiens-653-1-40-48.w83-192.abo.wanadoo.fr [83.192.199.48]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id B8462A017D; Sun, 4 Jan 2026 20:27:58 +0100 (CET) Received: from samy by end with local (Exim 4.99.1) (envelope-from ) id 1vcTle-0000000DJXZ-10j7; Sun, 04 Jan 2026 20:27:58 +0100 From: Samuel Thibault To: libc-alpha@sourceware.org Cc: Samuel Thibault , commit-hurd@gnu.org Subject: [hurd,commited] hurd: also test mmx state restoration Date: Sun, 4 Jan 2026 20:27:57 +0100 Message-ID: <20260104192758.3173350-1-samuel.thibault@ens-lyon.org> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org mmx registers are not the same as mmx, so better test them too --- hurd/test-sig-rpc-interrupted.c | 9 ++++++--- hurd/test-sig-xstate.c | 35 ++++++++++++++++++++++----------- hurd/test-xstate.h | 8 ++++++++ 3 files changed, 38 insertions(+), 14 deletions(-) diff --git a/hurd/test-sig-rpc-interrupted.c b/hurd/test-sig-rpc-interrupted.c index c272d9b4fd..ee3ab7cdcc 100644 --- a/hurd/test-sig-rpc-interrupted.c +++ b/hurd/test-sig-rpc-interrupted.c @@ -45,9 +45,12 @@ void handler (int signum, siginfo_t *info, void *context) { printf ("signal %d setting a different CPU state\n", signum); - char buf3[XSTATE_BUFFER_SIZE]; - memset (buf3, 0x77, XSTATE_BUFFER_SIZE); - SET_XSTATE (buf3); + char mmxbuf3[MMXSTATE_BUFFER_SIZE]; + char xbuf3[XSTATE_BUFFER_SIZE]; + memset (mmxbuf3, 0x77, MMXSTATE_BUFFER_SIZE); + memset (xbuf3, 0x77, XSTATE_BUFFER_SIZE); + SET_MMXSTATE (mmxbuf3); + SET_XSTATE (xbuf3); } static const mach_msg_type_t RetCodeCheck = { diff --git a/hurd/test-sig-xstate.c b/hurd/test-sig-xstate.c index c9265514b8..8ddfbebcd5 100644 --- a/hurd/test-sig-xstate.c +++ b/hurd/test-sig-xstate.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include @@ -40,15 +41,19 @@ #include "test-xstate.h" -static volatile bool loopflag = true; +static volatile atomic_bool startflag = ATOMIC_VAR_INIT (false); +static volatile atomic_bool loopflag = ATOMIC_VAR_INIT (true); void handler (int signum, siginfo_t *info, void *context) { - char buf3[XSTATE_BUFFER_SIZE]; - memset (buf3, 0x77, XSTATE_BUFFER_SIZE); - SET_XSTATE (buf3); + char mmxbuf3[MMXSTATE_BUFFER_SIZE]; + char xbuf3[XSTATE_BUFFER_SIZE]; + memset (mmxbuf3, 0x77, MMXSTATE_BUFFER_SIZE); + memset (xbuf3, 0x77, XSTATE_BUFFER_SIZE); + SET_MMXSTATE (mmxbuf3); + SET_XSTATE (xbuf3); printf ("signal %d setting a different CPU state\n", signum); - loopflag = false; + atomic_store_explicit (&loopflag, false, memory_order_release); } /* Helper thread to send a signal to the main thread */ @@ -59,6 +64,8 @@ void* signal_sender (void *arg) assert (! sigaddset (&ss, SIGUSR1)); assert (! sigprocmask (SIG_BLOCK, &ss, NULL)); + while (!atomic_load_explicit (&startflag, memory_order_acquire)) + ; TEST_COMPARE (kill (getpid (), SIGUSR1), 0); return NULL; @@ -76,16 +83,22 @@ static int do_test (void) pthread_t thsender = xpthread_create (NULL, signal_sender, NULL); - char buf1[XSTATE_BUFFER_SIZE], buf2[XSTATE_BUFFER_SIZE]; - memset (buf1, 0x33, XSTATE_BUFFER_SIZE); + char mmxbuf1[MMXSTATE_BUFFER_SIZE], mmxbuf2[MMXSTATE_BUFFER_SIZE]; + char xbuf1[XSTATE_BUFFER_SIZE], xbuf2[XSTATE_BUFFER_SIZE]; + memset (mmxbuf1, 0x33, MMXSTATE_BUFFER_SIZE); + memset (xbuf1, 0x33, XSTATE_BUFFER_SIZE); - SET_XSTATE (buf1); + SET_MMXSTATE (mmxbuf1); + SET_XSTATE (xbuf1); - while (loopflag) + atomic_store_explicit (&startflag, true, memory_order_release); + while (atomic_load_explicit (&loopflag, memory_order_acquire)) ; - GET_XSTATE (buf2); - TEST_COMPARE_BLOB (buf1, sizeof (buf1), buf2, sizeof (buf2)); + GET_MMXSTATE (mmxbuf2); + GET_XSTATE (xbuf2); + TEST_COMPARE_BLOB (mmxbuf1, sizeof (mmxbuf1), mmxbuf2, sizeof (mmxbuf2)); + TEST_COMPARE_BLOB (xbuf1, sizeof (xbuf1), xbuf2, sizeof (xbuf2)); xpthread_join (thsender); return EXIT_SUCCESS; diff --git a/hurd/test-xstate.h b/hurd/test-xstate.h index 3c3147be32..c032df1455 100644 --- a/hurd/test-xstate.h +++ b/hurd/test-xstate.h @@ -22,17 +22,25 @@ #if defined __x86_64__ || defined __i386__ #define XSTATE_HELPERS_SUPPORTED 1 +#define MMXSTATE_BUFFER_SIZE 8 #define XSTATE_BUFFER_SIZE 16 +#define SET_MMXSTATE(b) do { \ + asm volatile ("movq (%0),%%mm0" :: "r" (b)); \ + } while (0) #define SET_XSTATE(b) do { \ asm volatile ("movups (%0),%%xmm0" :: "r" (b)); \ } while (0) +#define GET_MMXSTATE(b) do { \ + asm volatile ("movq %%mm0,(%0)" :: "r" (b)); \ + } while (0) #define GET_XSTATE(b) do { \ asm volatile ("movups %%xmm0,(%0)" :: "r" (b)); \ } while (0) #else #define XSTATE_HELPERS_SUPPORTED 0 +#define MMXSTATE_BUFFER_SIZE 1 #define XSTATE_BUFFER_SIZE 1 #define SET_XSTATE(b) #endif