From patchwork Tue Nov 11 07:48:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 124024 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 06E523858405 for ; Tue, 11 Nov 2025 07:49:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 06E523858405 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=AI7mKRj+ X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-yx1-xb12a.google.com (mail-yx1-xb12a.google.com [IPv6:2607:f8b0:4864:20::b12a]) by sourceware.org (Postfix) with ESMTPS id 67D313858D20 for ; Tue, 11 Nov 2025 07:48:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 67D313858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 67D313858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b12a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762847321; cv=none; b=cXs7Z84zsv0f3gymEJT93jBqMy/nQ3c3TEzKozn1CdJsSpByJXPPsn7fMZamnGHW3W7+nrO8DQsGn7nnyRad1lkd+sOxVGB8WY13Q8E3qqtjd5P3C2Qt48RaK67EJdpG4HLb3t7vgKdMXj3Yw78PWGgJQ3ZDy25q2mexrDpYqpo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762847321; c=relaxed/simple; bh=f88BvRs+wcz4xHycoZ3NNgDezoDskT9V16XtXgmweI0=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=OjprC05zTdPCm4VWJIdhmoD2q5buPIUJjv/U9265McuKMqmWHbMuDy6bBplWus+rEaR+OiCSxv7e6U4KykftyJP5cyDZdL0AUMJD9rjLD6iUDPhbWp9gadWcYhDItzi3KK4ZT+MtAweW357tkMsucBN1MSHumQIvLeT2QUQAHYo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 67D313858D20 Received: by mail-yx1-xb12a.google.com with SMTP id 956f58d0204a3-63fbbad0ac3so3708214d50.1 for ; Mon, 10 Nov 2025 23:48:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762847321; x=1763452121; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0djd0bnogk2v7g+bbMw632/CghiY8NdFxxT/ijrFz10=; b=AI7mKRj+SGYdZG+kEmakpKSc+khlqbdyYwSEirvpYgflncB5Ewko+DfKj6BsETTFmk sGyPIATqkty/t+YvdC8weSKj9aWT057NZ6aY5rb4k6JQA5Ko/as8huHumh03pbsRAP1w 3lUDY/Zx3xdaU3xSYTXG5czO1N+iKJ38i8/iPwjTt6bZHTmcLTarL77z8A2yjdOUQk0M FoocBDCbSQSN5moNNoyxgnypqRUJjq19WcrllOutwMRgxVTDrXKiGI6DatBPyUJQpd6o mOyVu62Im7CjonhcVM6z/4ArW3pRAcvzGaejB1V0oKqE1/bWqNM//A7KpZmPM47d7Axm NzDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762847321; x=1763452121; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0djd0bnogk2v7g+bbMw632/CghiY8NdFxxT/ijrFz10=; b=WU/vZwMzdXVdddfs77NXKmCB4H6QW4gegMRyKW+3tUaHgnYRXq4L8tgSSfH2OesQ08 5d0L8oL1/Ii2ijabQ66OKdXqrw+JwLUR5o5fQigP66xcroneJMKiHGfYvxfzkeKhKNWK Abe5HuCF37+2uMEzEFXE7fh6ddt1OpolyOo/v4zEkjz1FMnF3z9w1WLuptB+RRkZspaF G3CeaceSDCPX7pHH8gcDrESuTL41zZEMUFr8FOq8Ed8ydT/jdQU7XesNEIxhcavW7FO2 5ocPRBc0EaILH0SVIkNhooCdZ0xysuWj6dF2+P6uCrkFG5v3DOQmCM6/1ged1yWvPCup /dIQ== X-Forwarded-Encrypted: i=1; AJvYcCUF/v3Ab7/s5dTEKAFv+pop3DCqkI9vu3h6GIgxbs4/Vu/l36OBBuSiY3AtWqHz0vPQPdahRq88o9A0@sourceware.org X-Gm-Message-State: AOJu0YyRp5HDBVRbgvd6rQAz6Bdl+SVSawVpbKGbaLzPNOkzjMdKauKW ZlJkyb58xd9H8UzVBp1eH3NJy3abSZ2OqL30q2sSGreL82E66RxhcyqNEaSOkqQFb+ho8D4YeS1 qcixHjHfmhZN6dQVrvwbuFK7o9JSdhf0= X-Gm-Gg: ASbGnctIInz71xR/043tXlv9+heCUGbAizLoW/YTDCVW16eOdK7AGYtesz8BB7PvMks tMwY5Rt03f3amZm0D3D2rILPaMN4DAK8HAZeakLyIPTb8RgKiXax3524OWCb/8ys1sAEIRSDJ3K hNgTxlNKjJNPWqQ5ZGjqgcuC3/AdCrdANr51sroaiKTl1RljTb+oKOuSHdAsBcfGAGerYGmywU6 YTZJwbfRojZSWPreTFG5bwIeDO9E86rslVIIWZ8a9aRwO45E7RqFSO4544ALkPfstNP8s0= X-Google-Smtp-Source: AGHT+IGYU3ZmrrdhGlSEoHoBmAX1aDRVD5I3gtzdDCtk8Wq4W1zLiW4LUKjabVisNNRf8Ti60SuW+FasipEkd1zub/4= X-Received: by 2002:a53:b116:0:b0:63f:9f72:4936 with SMTP id 956f58d0204a3-640d45f5fcdmr7552306d50.67.1762847320714; Mon, 10 Nov 2025 23:48:40 -0800 (PST) MIME-Version: 1.0 References: <20251017191632.2278298-1-adhemerval.zanella@linaro.org> <20251017191632.2278298-33-adhemerval.zanella@linaro.org> <143a83f8-0d3c-4ae2-87f8-51da49347e1c@linaro.org> <87ms4tur5q.fsf@gmail.com> <871pm5yu6f.fsf@gmail.com> In-Reply-To: From: "H.J. Lu" Date: Tue, 11 Nov 2025 15:48:04 +0800 X-Gm-Features: AWmQ_bkyR5n3Hnzm6i38L72cdjta1IsnuM1osEwo9IEA1Qo7XF9yFfi1m_9cS-g Message-ID: Subject: [PATCH] x86-64: Fix a typo in fesetenv.c [BZ #33619] To: Collin Funk Cc: Adhemerval Zanella Netto , GNU C Library , Sam James X-Spam-Status: No, score=-3013.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org On Tue, Nov 11, 2025 at 2:56 PM H.J. Lu wrote: > > On Tue, Nov 11, 2025 at 2:12 PM Collin Funk wrote: > > > > "H.J. Lu" writes: > > > > >> I bisected 65 test failures to this commit. On a x86_64 Fedora 43 system > > >> with the following gcc: > > >> > > >> $ gcc --version | head -n 1 > > >> gcc (GCC) 15.2.1 20251022 (Red Hat 15.2.1-3) > > >> > > >> The main ones are: > > >> > > >> FAIL: math/test-fenv > > >> FAIL: math/test-fenv-clear > > >> FAIL: math/test-fenv-clear-sse > > >> FAIL: math/test-fenv-return > > >> FAIL: math/test-fenv-x87 > > > > > > How can I reproduce these on Fedora 43? > > > > Here is what I did: > > > > $ "$GLIBC_SRCDIR"/configure --prefix=/usr \ > > && make -j $(nproc) \ > > && make subdirs=math -j $(nproc) check > > > > Collin > > I opened: > > https://sourceware.org/bugzilla/show_bug.cgi?id=33619 > Fix a typo in commit 427c25278d1dae62dffa07ea5cd0fc33f07190af Author: Adhemerval Zanella Date: Fri Oct 31 17:00:46 2025 -0300 x86: Adapt "%v" usage on clang to emit VEX enconding @@ -103,8 +104,8 @@ __fesetenv (const fenv_t *envp) temp.__mxcsr = envp->__mxcsr; } - __asm__ ("fldenv %0\n" - "%vldmxcsr %1" : : "m" (temp), "m" (temp.__mxcsr)); + asm volatile ("fldenv %0" : "=m" (temp)); + ldmxcsr_inline_asm (&temp.__mxcsr); /* Success. */ return 0; "temp" is input not output. This fixes BZ #33619. OK for master if there are no regressions? From bb30869492c79736b12ae7080c38092c41304f68 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Tue, 11 Nov 2025 15:43:31 +0800 Subject: [PATCH] x86-64: Fix a typo in fesetenv.c [BZ #33619] Fix a typo in commit 427c25278d1dae62dffa07ea5cd0fc33f07190af Author: Adhemerval Zanella Date: Fri Oct 31 17:00:46 2025 -0300 x86: Adapt "%v" usage on clang to emit VEX enconding @@ -103,8 +104,8 @@ __fesetenv (const fenv_t *envp) temp.__mxcsr = envp->__mxcsr; } - __asm__ ("fldenv %0\n" - "%vldmxcsr %1" : : "m" (temp), "m" (temp.__mxcsr)); + asm volatile ("fldenv %0" : "=m" (temp)); + ldmxcsr_inline_asm (&temp.__mxcsr); /* Success. */ return 0; "temp" is input not output. This fixes BZ #33619. Signed-off-by: H.J. Lu --- sysdeps/x86_64/fpu/fesetenv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdeps/x86_64/fpu/fesetenv.c b/sysdeps/x86_64/fpu/fesetenv.c index 9cf5f889ed..781de281b8 100644 --- a/sysdeps/x86_64/fpu/fesetenv.c +++ b/sysdeps/x86_64/fpu/fesetenv.c @@ -104,7 +104,7 @@ __fesetenv (const fenv_t *envp) temp.__mxcsr = envp->__mxcsr; } - asm volatile ("fldenv %0" : "=m" (temp)); + asm volatile ("fldenv %0" : : "m" (temp)); ldmxcsr_inline_asm (&temp.__mxcsr); /* Success. */ -- 2.51.1