From patchwork Sun Nov 9 21:53:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alejandro Colomar X-Patchwork-Id: 123869 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 98A3F3858409 for ; Sun, 9 Nov 2025 22:23:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 98A3F3858409 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=JErrV1pX X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by sourceware.org (Postfix) with ESMTPS id C655D385840F for ; Sun, 9 Nov 2025 21:53:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C655D385840F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C655D385840F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762725233; cv=none; b=JwesyXp0zHTj818ROn4kiRNIm6U7oSEcAyr2URKvHzVJGN3UY5/r5WMj8uMmgWjDK0IZjfX+3KXgB+lIkctX/05mFtau2yI+pWxSvsDhZOtQYKClvFANBWRBm5M3fTxWmOjewgVTDsuHNy7swe7s7FXfqbeELqnefHzqeP7xjAY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762725233; c=relaxed/simple; bh=v79IADIFUBd91H1nAKF9oEuIf5UwoNtgB078Fw43i2k=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=JOFz33rNfi9QJLipwMXYcRcxPNCSLBPoQ0npQkonOJiEs50BTgWqYhGxmZDt/d/96lpxuC77F3sulyxcXOXFjcKzLtC4P6aGlnj03b6aTBOKMuWzCOLSLFri+mNXj44OQky/GN3Hhab1TXj7VS8xMBwSEp+cEl7aNbq0jB7Bfy8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C655D385840F Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 3A77B42B1B for ; Sun, 9 Nov 2025 21:53:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B78AC4CEF7; Sun, 9 Nov 2025 21:53:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762725233; bh=v79IADIFUBd91H1nAKF9oEuIf5UwoNtgB078Fw43i2k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JErrV1pXe0M1wn67DvdOAx83zqtqH+GGzXf9kBELwO5IsURtXbftiKLhiMXKGCAjz H7HaI/nMocPyfu7pqaIyD/LTmi59HdGAJBXGRh6PIHImXcnx2rv/87Uyp+HYR1GWM9 x1TGx+M2tnsHT3y+RCSuPKVZSKs+2PVDIizx6/Dns4hUc3Adx862EX+vYWv/jvqVUP EFsnSuMpjaCFoIgRvO+89AzT5U4uIFrpagg+K4J77YHEnHp4gxA+wbfb/KoIpHdojn PQ/5WEKF+A3WghkEvYWSH/ln/2qYPGszj36Aq82NPxh24uTBdYlelpI6cEeoNeShUl qMrptNelH7rVg== Date: Sun, 9 Nov 2025 22:53:50 +0100 From: Alejandro Colomar To: libc-alpha@sourceware.org Cc: Alejandro Colomar Subject: [PATCH v1 25/35] Assume support for the 'unused' attribute on labels Message-ID: <8e56f7709ca3fbea7c12a2b4ab9e194b73aa2cdf.1762725057.git.alx@kernel.org> X-Mailer: git-send-email 2.51.0 References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org We already assume that GCC is at least GCC 5, and we also assume that Clang is at least Clang 4. It seems to me that Clang added support for this attribute in labels in Clang 2.9: llvm.git 9f48354b7127 (2010-09-28; "Don't warn for an unused label if it has 'unused' attribute. Fixes rdar://8483139.") $ git describe --contains 9f48354b7127 llvmorg-2.9.0-rc1~9894 Signed-off-by: Alejandro Colomar --- include/libc-symbols.h | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/include/libc-symbols.h b/include/libc-symbols.h index 1f59b69ecf..d8c77eb741 100644 --- a/include/libc-symbols.h +++ b/include/libc-symbols.h @@ -815,15 +815,9 @@ for linking") GCC -Wunused-parameter. */ # define _GL_UNUSED __attribute__ ((__unused__)) -/* gcc supports the "unused" attribute on possibly unused labels, and - g++ has since version 4.5. Note to support C++ as well as C, +/* Note to support C++ as well as C, _GL_UNUSED_LABEL should be used with a trailing ; */ -#if !defined __cplusplus || __GNUC__ > 4 \ - || (__GNUC__ == 4 && __GNUC_MINOR__ >= 5) # define _GL_UNUSED_LABEL _GL_UNUSED -#else -# define _GL_UNUSED_LABEL -#endif # define _GL_ATTRIBUTE_PURE __attribute__ ((__pure__))