From patchwork Sun Nov 9 21:54:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alejandro Colomar X-Patchwork-Id: 123863 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 701183858402 for ; Sun, 9 Nov 2025 22:17:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 701183858402 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=S5Af77MH X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) by sourceware.org (Postfix) with ESMTPS id CBBC93858416 for ; Sun, 9 Nov 2025 21:54:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CBBC93858416 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CBBC93858416 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2600:3c0a:e001:78e:0:1991:8:25 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762725254; cv=none; b=gt7EnEQSICXZxf8COD0o0IFrvIkygO2AaChr9g5OXAJ9t2sGo35o1QgfkzQKStGfFywynzM8yhL9RWCWrTS6g3g8veCK+qYe8a2sWw8LUcaDNB6/qvW9P1AVGqLrNIeFGZ6xOivY/+4JiP9StK4K/3eMnPTrJi1eWqVY6xVJOSY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762725254; c=relaxed/simple; bh=TsxDYPwIadhO886qsSwFp/FcJCAoDTN1wauKLxRQawc=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Ez7H6XP0wxw8MoingNEPpPeYYfMNWTb+OAr5Yexk9PwZ2IYHqUS3P/kR8r/6U14F9XDYUUCrHBtGQym6kJRD2FlkWvHB+oSjOCn2lYxNaQRNPLZamMwY/aE+U0z9cOEc/w9Ed3lkzSoFmN76lKHpFLrIZclV+Nw+7F68W0UDvQk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CBBC93858416 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 30FF74369A for ; Sun, 9 Nov 2025 21:54:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 664ACC19422; Sun, 9 Nov 2025 21:54:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762725254; bh=TsxDYPwIadhO886qsSwFp/FcJCAoDTN1wauKLxRQawc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S5Af77MHYUMtIaao6XSe1obrlhanoRPs8GiVWWPNOldZnmhCjHgGksaHicIKmHSIa l4O1uNdcHdpeo17LLVOWU7qUi0NuRpn9YhiU9Rk2RtBh7qvpFod70BTW+CKmviWifv tH+XwxV27wwxG6g7G/8cqTlzAS+tBBhzl2kouhir5+T3stR0E/Em0lbRfbiBcsQLLR LHkYIVKiTwI+5i4HH2/34GuxTrxHVp0bgTmuS+nQNl4FDeRTsOMnNwYbRZQ3o9r89O XOtL9u7uQDKEKIO5GMsz9q1b7cxGvXtJTyuwz58uFLPU05cxOTSDp8oKmvK5K1PFKt /tUcF25uFU56w== Date: Sun, 9 Nov 2025 22:54:11 +0100 From: Alejandro Colomar To: libc-alpha@sourceware.org Cc: Alejandro Colomar Subject: [PATCH v1 33/35] Assume __has_attribute(__cold__) Message-ID: <9ae9f9132a4a45e8bb1283f6055fa47ef19c8ae8.1762725057.git.alx@kernel.org> X-Mailer: git-send-email 2.51.0 References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org We already assume that GCC is at least GCC 5, and we also assume that Clang is at least Clang 4. Clang added support for __attribute__((__cold__)) in Clang 3.2: llvm.git 29c2b4330ce0 (2012-05-12; "Add support for __attribute__((hot)) and __attribute__((cold)).") $ git describe --contains 29c2b4330ce0 llvmorg-3.2.0-rc1~1^2~9639 Signed-off-by: Alejandro Colomar --- misc/sys/cdefs.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h index 2320f7293a..07eddbef74 100644 --- a/misc/sys/cdefs.h +++ b/misc/sys/cdefs.h @@ -93,11 +93,7 @@ # endif # endif -# if __GNUC_PREREQ (4, 3) || __glibc_has_attribute (__cold__) # define __COLD __attribute__ ((__cold__)) -# else -# define __COLD -# endif /* These two macros are not used in glibc anymore. They are kept here only because some other projects expect the macros to be defined. */