From patchwork Wed Oct 22 02:52:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Collin Funk X-Patchwork-Id: 122402 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D6D563858C56 for ; Wed, 22 Oct 2025 02:55:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D6D563858C56 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=SKg/RXBX X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id C513A3858D20 for ; Wed, 22 Oct 2025 02:54:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C513A3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C513A3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761101666; cv=none; b=F0A961OQ44ChASUu5+fxK4EpsK/MhnNkgXLsSQs7KcrB8979Z6fUxE8i9cTZ9FT1q12rkOyB4uoJ2myWk+k+tE8o9fN9oJ1yZHELk/xMZ24pqJgfAB/itU2gnBWGYZpbcmEpK5phwWxUTokbfMPL/RIR2zowGwHZYyqQ5Qg/wSE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761101666; c=relaxed/simple; bh=GXkLJvmc2z7lazVF4sthsG/kA9mwqy0GX7KGjnWkhIE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=o2bGab9JvukrkMzLilCuXdMOkbt6IW4f5GWLibb1WGNjyGQh4YJpiBro3Kk7XwCSs+BBiil6wuwvsmMea9KCQM6SH6QZEexQ9e52WBHUbdbtvxsvwSGV+MJXKJ8KDEC/x684V4gTW1goEZUKSKM5TnhIlSapyUW/qHm8JchP4zo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C513A3858D20 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-7811fa91774so5651003b3a.0 for ; Tue, 21 Oct 2025 19:54:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761101666; x=1761706466; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rkd3PkVs+1hKElLYL+sL8CrJKKJ0hzLGVvkYpCk35Lc=; b=SKg/RXBX5ZR0/N6F533N+OBzrK+9FniKEpwG7T5WAd1S0DQmxf2m7Og9oK3ybSnSAo gwzH8LJAg28T9Sg9J+9cCcYqJ4stkZknSm7TdzHEBFU5YPCEKYvsmJD7Ujad0sFvsFrP mMH4gTVkSVc1+srRYNN1aiLNSB24WWx9TPR4eQYvsFIFQSeGfubijqAg5KLa6StTfy7e al2sjASCbsXDyX1iXw8rius07aBk8tGE1th/No8yvSYoAwfQoyjIkNr+/nSXgFEMR/0B MY5l8gTgNIUFGV6edGHAWIiLSoA4LvY/wd7y95up+Y5Sow3jP+bKXQX4GCYjVM4xu5FL LRxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761101666; x=1761706466; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rkd3PkVs+1hKElLYL+sL8CrJKKJ0hzLGVvkYpCk35Lc=; b=qXyLZNkbWmTS2LMYGd133QdB2dXmfbk9+OeKw0y332Qseary1BiOKqy2jrCrSOWnk3 AvQz6MDjrtC53sRt5AC6uJb5JwUAL0tec9Q+zlC7M1oIixVaNKk4Kmnwr8WmzFyqtZVS w0M+VjPPwMV8FaeJK9uj+71zljzCA4prJqvUjIPyeWg/FhILPY2lXsw/vsl5MCulDgIq rgpd0aRTmBLhRWmSgKifu1KH1wDNuXOUNoReeBUTKuwFOkd5eFUnQPev7hHjx9+yfwDe pLlA5dldd7ApEIzV1ExSsM1m/st576ToRWwUgDflg9uNCuY5OfcA/yAnwrngVw3FRJCC yrdw== X-Gm-Message-State: AOJu0Yw92mA6w5fnZxTagoUN9DBSktnOcaYJR3N4shXE7BG5JT807yDY Pi0eYk2GLsDyBcdg51P3qiJB9syNJr8l5bQIOwwW8N03ggcKNDy9632q3fHt580K X-Gm-Gg: ASbGncvGywWbD9NQNHr1gnM3lP2Cw8gbh/5RNScXsAPTODnyEJiYvYG95Zi/kWzU7He 8ARBKzg/LcnpOT/l+m5hNiIdMds8Yp/iydE0sLQbZWPRrbrdSpuQUVyB9bBaK4yL9n9QD31dS4C 53f7CmCM3dS7R4lW3ZEQPRcQfkt5C71mzVEdKEeXABoPmFv6yvvTSjjgFqf+Je5iKI9N8Gvtrdd d39NsQ/bBJlerbwQww3icUixYSsDibI/HpCX2rmgfdAQvKb6y8fwlPO3TdecIz0aTIbeZYubcwU AJ9J9ckK/pwrWCs1aJ3fRAm3Ah/ir998+xIDRqwe0U2i35iialrvc0MrAP7f6ARXdzPWNR9HDiR tI64Yklbak7zDBCRWCzcqoeXvF1XJRRmO1x+O5cnLJyz+FCfcfwrIr5ZHKg== X-Google-Smtp-Source: AGHT+IE44c1B5Iuw1GPmZ+0PX0kTqAw8Gn45+k/5iJi7Xe7qptYi6HnrNtMsTSubaOOXo3RinaZCLQ== X-Received: by 2002:a05:6a00:188b:b0:781:2757:1b4f with SMTP id d2e1a72fcca58-7a2206eb750mr21647911b3a.7.1761101665544; Tue, 21 Oct 2025 19:54:25 -0700 (PDT) Received: from fedora ([2601:646:8081:3770::43bc]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7a22ff35a59sm12789506b3a.25.2025.10.21.19.54.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Oct 2025 19:54:25 -0700 (PDT) From: Collin Funk To: libc-alpha@sourceware.org Cc: Bruno Haible , Collin Funk Subject: [COMMITED] posix: Fix memory leak a memory leak in glob. Date: Tue, 21 Oct 2025 19:52:22 -0700 Message-ID: <1eba0b35ad3e860a0d4fae12579e8399355eee44.1761101530.git.collin.funk1@gmail.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org From: Bruno Haible Found by Coverity in Gnulib. * posix/glob.c (__glob): Add scratch_buffer_free invocation, to match scratch_buffer_init invocation. Reviewed-by: Collin Funk -- 8< -- Bruno pushed this change to Gnulib, and the patch applied to the version in glibc. So I have committed it under his name. --- posix/glob.c | 1 + 1 file changed, 1 insertion(+) diff --git a/posix/glob.c b/posix/glob.c index 0c86d26972..846528e252 100644 --- a/posix/glob.c +++ b/posix/glob.c @@ -886,6 +886,7 @@ __glob (const char *pattern, int flags, int (*errfunc) (const char *, int), { /* We have to regard it as an error if we cannot find the home directory. */ + scratch_buffer_free (&pwtmpbuf); retval = GLOB_NOMATCH; goto out; }