From patchwork Sun Aug 10 21:46:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 118145 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 162F93858D26 for ; Sun, 10 Aug 2025 21:46:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 162F93858D26 X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by sourceware.org (Postfix) with ESMTPS id 4B1453858D21 for ; Sun, 10 Aug 2025 21:46:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4B1453858D21 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bounce.ens-lyon.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4B1453858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.77.166.138 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1754862374; cv=none; b=T71eOG/a9+6yHogOTa2Ht/TVvVAAbsACfZICQX7ORUSGv6SfhLyZMU6/428+mOQoz66QCCbuWG/FJoL2UX7RXmYlz8raBEQBnvJyGH+ilCTHKuTmutVoeUhPCEzkuSf556JMn+wbIe6L0Tnsc6rHhEbzex17bPK5mYN2c2ob1aQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1754862374; c=relaxed/simple; bh=NGju8Lz0inqQ6mlQSq5mqsecVoBm7marqZiun83JiHc=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=BycO5Mb55bNyhEyUWSlw4u2UrnSAkCn6MxgT4ZaAmLOrH+pyO2nnscdvlEt9xZvGGb6qHkQ2T47N0ajAkLASNHOkheAgh7fNmqS3844d4vCE0wrh2mDP46UdhykBcyBE7fkGMHH+h6fok5A4rSn08IloSPAWaalRTrXDfxmDwnc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4B1453858D21 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 0830CA1C61; Sun, 10 Aug 2025 23:46:13 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Wr4RwIGvVdGX; Sun, 10 Aug 2025 23:46:12 +0200 (CEST) Received: from begin.home (aaubervilliers-655-1-3-203.w82-121.abo.wanadoo.fr [82.121.114.203]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id CCD4CA1C12; Sun, 10 Aug 2025 23:46:12 +0200 (CEST) Received: from samy by begin.home with local (Exim 4.98.2) (envelope-from ) id 1ulDro-00000000kE4-1ZAj; Sun, 10 Aug 2025 23:46:12 +0200 From: Samuel Thibault To: libc-alpha@sourceware.org Cc: Samuel Thibault , commit-hurd@gnu.org Subject: [commited] malloc: Fix checking for small negative values of tcache_key Date: Sun, 10 Aug 2025 23:46:08 +0200 Message-ID: <20250810214608.177683-1-samuel.thibault@ens-lyon.org> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org tcache_key is unsigned so we should turn it explicitly to signed before taking its absolute value. --- malloc/malloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/malloc/malloc.c b/malloc/malloc.c index c135916d32..e08873cad5 100644 --- a/malloc/malloc.c +++ b/malloc/malloc.c @@ -3108,7 +3108,7 @@ tcache_key_initialize (void) int minimum_bits = __WORDSIZE / 4; int maximum_bits = __WORDSIZE - minimum_bits; - while (labs (tcache_key) <= 0x1000000 + while (labs ((intptr_t) tcache_key) <= 0x1000000 || stdc_count_ones (tcache_key) < minimum_bits || stdc_count_ones (tcache_key) > maximum_bits) {