From patchwork Tue Jul 8 00:08:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 115825 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 10B96385B51D for ; Tue, 8 Jul 2025 00:10:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 10B96385B51D Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=WxM8L/oT X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) by sourceware.org (Postfix) with ESMTPS id CDC0F385AC1E for ; Tue, 8 Jul 2025 00:09:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CDC0F385AC1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CDC0F385AC1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1134 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1751933372; cv=none; b=JMYBoSYZ7tphM5it7VAICmPo08fLu1Qxtb4eHu7ATi3NmqzfzIB3YZuQ5Ut6MQOB9p+8+7v7oX7mpHR5mUykWKl9EwPejwtrmhgDYnC/jo9PQZsDkOBB3PTKNMo1NX2isvwKcnO8f0gkCL8c3acLyiHwbu+H4X1mfLY18mCHw5g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1751933372; c=relaxed/simple; bh=hB/ltUS/Ez9ftg8dyNpP/YKIzJdVwSwY7FJoI+1f/yw=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=uTsKkaVuDjjWuLgzAnbJHd+hYZ8m5dO2bOagbY5pZCCIAOwRFukWB06sWUoCED4UrWRfYIDt0PXd0jV/YWvdlM1PAv7E/4LOLjjI/gz2khQ6MlGo4X4bBQmNN8OEqPEmjNCPcI72uQwWev1YipY7ODkRF6T0Qd/GljpkpTxwZkQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CDC0F385AC1E Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-70e64b430daso39132837b3.3 for ; Mon, 07 Jul 2025 17:09:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751933371; x=1752538171; darn=sourceware.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=SFi/0fAJx1/Q+nE/0ZopBw7k6RLKLQJ3MTAQ/w2KBEE=; b=WxM8L/oTnBjOlul8YxfXsHukCcQk5CvcO8ROKGxDt8UpDEyH6wIn3OuGBnYtABFEn7 yfhYa//inHuUO4Rfrj7Y2N0zf6oHd22xkq9OYACJYeFZNZ3fdLn5ts53LeX2mnxsSvcf uneVgWsSRvDTCJEgzkwU+qpig5xcz1Ahq90ZtIcQ2RrH0J00aOJuCTZQ/WvsryhHisJG 2t5CjoJQz3w23vEfl+9kG38ry/LSUShcus8q8pdpyTG6qM+AFXVb45iJPxNCrGYx4qRg HkPsqD0KJuEPBCtZvdbZTW6uwNApvggNpvFOzoC3Y3WFSIFKpXwwzxGGc3UpQtnIgUHh Vq9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751933371; x=1752538171; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=SFi/0fAJx1/Q+nE/0ZopBw7k6RLKLQJ3MTAQ/w2KBEE=; b=Ed46sO0coT7bGOCdHSgZ7kp+Q7bgfcVmcW1U9FDSLElm6U74Cv241KWbGXHpxd4QZ6 urjs1uVbL8ymB1vCByUVym2fAGuFa5pNaXzsoWpqlMgz91CPnxww2b7Th2wdbr5Q1aos DUeYr4O4jjJa50xmFZfnhXxLXUXKNiquIIZPGT+8Kif5BFNDJ7TgS1beUkHQfsyOV5xf JjpQ/pkLGBNs6059GSSflz7jfGaXRcKOtc23hzoKddGRqLpJp4oBTHf2Tz2lpgrlUOzH vchA6C8dFWl/w3cvPR+4D+o7CcGeQMMAZ5KxGNCHfy7TaBKI/dvLrw7FQpGThmo7J43N Mm6A== X-Gm-Message-State: AOJu0YyTa935mLSkYsh2WBkNZtK8T9AC7+is1ObfvobquVry86XYwLQK 6+buaf16Pyh2FdYr/Vo+uSHPHejbL+yeGTZ9sxysfkYIGgyy8VCJi6OTPQ1bqmI2Bs/863kU9SB gtVuNSyY0ZEOXeHZMDtcuGje7ZTFQ7LvzGrN2utcmdQ== X-Gm-Gg: ASbGnctyhRacjgCuIVcm4DDoZOw6ZSGBpCHIxDJhjKuD7fm7oQKhMSl2Va+YTHtJ23Y orUmESyvE9qageMWVGo+xFlYjp3gjlmfHwL3iX6nHFwFefhIieEISPkWgg8tnsMi0gwQhiYxDgd qKqEhVyxFzaT50iOExQBSwHX/ihGgXaORnG6oIHkw= X-Google-Smtp-Source: AGHT+IEOTiRXAdj7emTShRJQxw7HFLuGViSx4VxjtdKvye8cuf3b4K3NvbPAJcUCErSvVjo1BpUZdOJK6BZcJtSQV+I= X-Received: by 2002:a05:690c:9511:b0:711:a54e:8e11 with SMTP id 00721157ae682-7166b6be7camr155403737b3.24.1751933370759; Mon, 07 Jul 2025 17:09:30 -0700 (PDT) MIME-Version: 1.0 From: "H.J. Lu" Date: Tue, 8 Jul 2025 08:08:54 +0800 X-Gm-Features: Ac12FXy5hiC8aVqXxPo3eOsG9XQWkKgg_TltAGtntoNL6JxYReX41bSqSvZM9E4 Message-ID: Subject: [PATCH] x86: Avoid vector/r16-r31 registers and memcpy/memset in mcount_internal To: GNU C Library , =?utf-8?q?Andreas_K=2E_H?= =?utf-8?q?=C3=BCttel?= , Florian Weimer X-Spam-Status: No, score=-3014.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org Since mcount_internal is called from mcount/__fentry__ which preserve only RAX, RCX, RDX, RSI, RDI, R8 and R9, compile mcount.c with -fno-tree-loop-distribute-patterns -mgeneral-regs-only -mno-apxf to void vector/r16-r31 registers and memcpy/memset in mcount_internal. This fixes BZ #33134. From 9dbfceac7260f5f8dc4f6863174d34dce5c34d26 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Tue, 8 Jul 2025 06:38:38 +0800 Subject: [PATCH] x86: Avoid vector/r16-r31 registers and memcpy/memset in mcount_internal Since mcount_internal is called from mcount/__fentry__ which preserve only RAX, RCX, RDX, RSI, RDI, R8 and R9, compile mcount.c with -fno-tree-loop-distribute-patterns -mgeneral-regs-only -mno-apxf to void vector/r16-r31 registers and memcpy/memset in mcount_internal. This fixes BZ #33134. Signed-off-by: H.J. Lu --- gmon/Makefile | 5 +++-- sysdeps/x86/Makefile | 4 ++++ sysdeps/x86_64/Makefile | 4 ++++ 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/gmon/Makefile b/gmon/Makefile index 26051ed2fb..b42c14aa83 100644 --- a/gmon/Makefile +++ b/gmon/Makefile @@ -62,8 +62,9 @@ tests-static += tst-gmon-static-pie endif endif -# The mcount code won't work without a frame pointer. -CFLAGS-mcount.c := -fno-omit-frame-pointer +# The mcount code won't work without a frame pointer nor when memcpy or +# memset are called. +CFLAGS-mcount.c := -fno-omit-frame-pointer -fno-tree-loop-distribute-patterns CFLAGS-tst-gmon.c := -fno-omit-frame-pointer -pg tst-gmon-no-pie = yes diff --git a/sysdeps/x86/Makefile b/sysdeps/x86/Makefile index 2aca36c1f0..4fbd48e1c8 100644 --- a/sysdeps/x86/Makefile +++ b/sysdeps/x86/Makefile @@ -137,6 +137,10 @@ tst-tls23-mod.so-no-z-defs = yes $(objpfx)tst-tls23-mod.so: $(libsupport) endif +ifeq ($(subdir),gmon) +CFLAGS-mcount.c += -mgeneral-regs-only +endif + ifeq ($(subdir),math) tests += \ tst-ldbl-nonnormal-printf \ diff --git a/sysdeps/x86_64/Makefile b/sysdeps/x86_64/Makefile index 2e061cb224..5b80391897 100644 --- a/sysdeps/x86_64/Makefile +++ b/sysdeps/x86_64/Makefile @@ -20,6 +20,10 @@ sysdep_routines += _mcount # object. sysdep_noprof += _mcount +ifeq (yes,$(have-x86-apx)) +CFLAGS-mcount.c += -mno-apxf +endif + # -pg doesn't work with separate shrink wrapping in GCC 16: # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=120881 # Add -mfentry to call __fentry__ before the prologue. -- 2.50.0