From patchwork Mon Jul 7 12:10:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dora, Sunil Kumar" X-Patchwork-Id: 115755 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4091F3857C7B for ; Mon, 7 Jul 2025 12:19:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4091F3857C7B X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) by sourceware.org (Postfix) with ESMTPS id 367B9385802C for ; Mon, 7 Jul 2025 12:11:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 367B9385802C Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=windriver.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 367B9385802C Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.166.238 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1751890311; cv=pass; b=lTDFwHGqKaVgzv89huODq5WcyPPF+tM7Q7oacbUB6rnE+cj04Mdkg79yql7IX8hkAMz3hL1o+j8MtozX7VvUxK/eFG0jtsSriH82GFl5ijwFn5YTot8wFNsllWQ4logaMEpU+8FDtQ7xpu3a/jtFU7AWEcpYWDQll1gqKuvifWs= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1751890311; c=relaxed/simple; bh=/fXiNfRmM8EPRSdvE4wWW5JdipBIwmxOeA0ioikfqT0=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=udlKOLrEjx8BamIbVDC5Z6iUYT33v7nK/5p/9Cl/f1A5Pl+mVv+iM+A6lM00vpybJM9N4YoCLZnE0RSdPbBpQEHpVLBbQ1IjyiEWW8R1FcoZh6SDcAZyqPp/ckoga6zDOPjw56Uy+gWZjNd5Ax1Y0xdAaCjefbZ/hpLATQqsNF0= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 367B9385802C Received: from pps.filterd (m0250810.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 567Ag64c018969; Mon, 7 Jul 2025 05:11:39 -0700 Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04on2071.outbound.protection.outlook.com [40.107.102.71]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 47pyb5hh5b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Jul 2025 05:11:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yKnHhi0f3EoySdA0oGGr1da6s88YUBKzHzmioGy6s4dO7vMxC71+/ySFkoOoXX1r2v+MBGwwKDnOXiREmmTYPaq8zbIhOIHUhWowqcQda/TeJRkedGZ6qpY2Bjd7b1hoEBYe6bTVAw+iKOU3e/Nm6+qwD1jkXIurt4jX4+E04DI0MsBNAad0F3JPuxA9S6SMc7ENaG9Eus67VJG92TFICWOquzQW6/ee4WL0DfFPiAauC0ro6yf9C3TSHXc08lU+yXDxfI6nlwlaPmB9Mv13LTQOIpmph7QGNO77R46pgbbbrfQSA/gSUssP+Xfs1mEiJYJC66eLGtx5mdyVV8WN0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=87apyE+bJK1rzi6+FGi+Rzx9ahGGV9sO/mI+4im3b/M=; b=PqksREzFJC/vK9XGikMtXsdBFwk4dQj+x0723v7OGwkVMwaKEDJGgHJiEzqnObC+ZaPxeiZ1g4A8DVTaILnNu/k4BmSTFGkF5x2R9cAw0CHTitV3PyMoP0Uv4Ez8q5ljiU0Qs0FSSYRp4I/n+pvW9ajLrExuRAcHMubOhI6n+ckFC6p1LDdPQXqDP4ostaXkyS1HSMVp8aCkSEkwpWZXkcGJNpkTJiY370jI6JrY4cW4TZmMHCxvPUxn+oJZtRPj26VrBw9lZOsIKVk2fTgHtZDTZb4taQ4t6BFIhUc18NjIheQNDkRjBIo5lJl4F2wsdX8HpCZ6wwjLPTlyer1Y0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from DS0PR11MB7901.namprd11.prod.outlook.com (2603:10b6:8:f4::20) by PH0PR11MB5126.namprd11.prod.outlook.com (2603:10b6:510:3a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.24; Mon, 7 Jul 2025 12:11:37 +0000 Received: from DS0PR11MB7901.namprd11.prod.outlook.com ([fe80::9fa:eb3f:cf26:264d]) by DS0PR11MB7901.namprd11.prod.outlook.com ([fe80::9fa:eb3f:cf26:264d%4]) with mapi id 15.20.8901.023; Mon, 7 Jul 2025 12:11:37 +0000 From: sunilkumar.dora@windriver.com To: libc-alpha@sourceware.org Cc: carlos@redhat.com, SunilKumar.Dora@windriver.com, Sundeep.Kokkonda@windriver.com, fweimer@redhat.com, frankbarrus_sw@shaggy.cc, malteskarupke@fastmail.fm Subject: [PATCH 04/10] [2.37] nptl: Remove unnecessary quadruple check in pthread_cond_wait Date: Mon, 7 Jul 2025 05:10:59 -0700 Message-ID: <20250707121105.2226766-5-sunilkumar.dora@windriver.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250707121105.2226766-1-sunilkumar.dora@windriver.com> References: <20250707121105.2226766-1-sunilkumar.dora@windriver.com> X-ClientProxiedBy: TYAPR01CA0135.jpnprd01.prod.outlook.com (2603:1096:404:2d::27) To DS0PR11MB7901.namprd11.prod.outlook.com (2603:10b6:8:f4::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7901:EE_|PH0PR11MB5126:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f6e6d5d-7e11-4d03-7116-08ddbd4f6c44 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: 7MI0ahqkGmHQUE294Hi8UxZEBgouztXm3xDf1qMthjq+6QXkiCNTp6IaRIfO0Ndl9jSVsnh0SH710pNKT7ESFB5ZtD1fui1MoZ3LMB121cep/hrbZVYG5hfzK6SDr9TuhhkHQ6OQzeEHa/czgFsL6ooPWwBMDQouRgM3V/U6eABzNCh8C7qh2YDoy1Cwzxv79M+EOLmjBjkc7/wRtslF+QjnxGDoFG3RtUGSIir56ozSoPrpvTalaXAgANVZgTa/Jw+ELtzjm8qTR2YYnuqqA3MFiBzWZjtq+3MEEJCNGuB54ybbXRd4xIbqabXvygDAk5tPMV1Bu418Rta+VG/79f1XDW/FCNMtbu2RI6wiyLAgI+xKPkfanl4f4gx+IFwkGvsbHE9YzmBRWdH+/aDrU8YpGgMkOJX1JbCe/GvznLB2eqh4uaxP5HmkIhHF2ocWmX+ytOeIab3f/yeGIYAZdzH6y2OmbaL54KvucvofGFOQyKdMYpqemEZEevZgWg3nVor0K4daBwCDlrOYo4nsUyH7oZSATVK1VrpSmk1lL/JX0VEwB6aqBzOn5nmepB7IAYZd3iOgt3DPQiEXHjKYzuiFyZUmbHroU++JLqVdhdFC0y5FUdNSu/4rZGRYSlS8xkNlIYzgzrWE9vrS0ZzlnhLzVqt/hYCpxMcyYVh+Ltv8qFSvNe9iGXZ55K5JlWhniNjbcYDdje8ZSmZ4e4gUrCo04p3Gu1z4pmub62pyjTYz8YTwUghTaT26X0DQ1avLgEaLScLBwD9WfxWiHscWw7TXUCjI5Dc+hNIEe2ukedjZB2TwPZiwX6Hv4zHynZGhdjSTiXI5jOUkcwQ0g6MSPNhudyZZx6wkJkCjBmjMjVFYv7tj+uLsjQiuu3lFFDPjxldtVQutTIUuQGHOqoylgi0pEgYOVlEWoXaXoBVo4cvY/UFvlf6aW5ySgn/YY98rEpSefdwhW+S84JTzhca31Xm0lMAp4rsVPoIaWKpaotsWrwXf6Zkzx8XnwzidOAOFqcQo9PnI3eP4PByZhMf7Ql1ASZtPqrvFqET9tDVFp5nhDa9P2uNkhkMTaFy2agLf0FwZrz5WgRgjbydXPULDv0GutZhZdVWljwaY8WKIN3nLOBL2aXRNCjG1haqLMbwQTGldgOxif3DUnJBwUyfHWpSSBydl0ot/eIfTGs6CHFO3V6csALqx84bmWLnQzWx18YEkkks7FW9XsrghlL4c25L/2jGJSYXOw8bNGFyz99aNAVf2JuI4dXL9NZ8sgky2SGUHyh5XXyk+6hZqTagnpnlGLr+A1mXmwYNWe08fRYFaCXwYYKoo5fYuh7ow9yZeAYc6XCPvoc3OfUAnLcXIV9wyDb3AWNUWS6axOyU9ffPvgO0NXjUBHfjSPzzzKKlakQA//XjQlpwclO4zAvPBgQKoY3U32NoVNDCL6kfAljmH0ot5x1dMGh+0WvY6kbYXxSSTcFTla32ObhPYYrhOwA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7901.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(52116014)(376014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: El4vW7AR2jheJUcb1PUqC5sE6CpOn9yb6KkdOp2jbYB3UWFgHDv1om1btTT0BmPuMQrHCoe8eia71U68kMwTmRIdv/8wheDLhKMorCjfo60MGjJ+9hAASHkYBf8Nkhgsd0xHoDDak/AwHDmyioGqE0l9D7fVxpnzJ/cq4JehN/TxdX7STfT1X4yQffhL/mj2gFrlymTnGoNnphzDsmqsxn5OReX7kXrXyO8FvvjhR3B8pd/B64Sk3/SgFOdrxuX5IK5SBV5vOHYWKBT7SMpfOfDpF7lstK87ynpqTxgX3HJPP4FYNt/w95A4Uw3BAw9cg0uSM9RqFIvpdjJVozOPYRdbYgqXoXPWbULjjCNQf+t09Tnw8zBdXuGerpFgCImvNbnUJfqDmks36K2AnAPEsaz9flNU1/T83HOEJ7fbJX6zV7cJukwu0kMH23ySQ7kngWqYGHnrO1F7XuOce+E7VIOxbwufbXKGHzQsh3PW+4pWzThoa9xv5DnDPeKbBm7o0v1Mb5F6K2unj/DcmmZuslFrD4hEsLLd/Md4/xAEv6SN96LL6avq01Z2bkeUOG420O4hDyDQk3pcz0GwCjwe2QnH1KkF2dX5MPP8GpUrNpNPszqj5bUpLqTlv2piE6p0S0SL710hD8HOHbH4iOCLjVoxCTPJYftPNENwXLQozBTu6lCiNHyyHCsc7Xy7CsvhDFDWhoAuswuctRypaYX7L/vYoGTBwDGN1eahZH8ZmSiC9y/V3/2fKMAAlAAT0l45oct+UpWCS0f++qLaiv/rL/9mIFixae1d5EBPzqsVvZuG4TrzAKT6IBDJuPcJa+DK8TJ3JdrnI8nNxVlUz9i3Z6mUCS2QDg/ycA8ddfQR+jqPp/lUCKM+p67THHPoZX2VtPzJnX3+kbqulwkShU2eaurwu2Wv8KiNKz0p9HzMPQ79en4jWupI/6c+dMjlyaWmtKs7ZnVBexPScTa1HX1OHXfdRBjrLoEGpnqUSZrVPPLqah9rYkAPsQ+nS1wEmlaGay6F48xnKnLY1rldnKf+K2/NHxi/9AS3gzNhYmglS2dVJdk/4QvoQ7YbpgSZxJku1+I4Qv0lVfgpVONx/DKZjzw0Uyw+lzt5oFi95P1Y3ISRmpZIbrTFKoiC4TEBeZ5l3ASgw9OccSzLhyfEWu3jxBUZwo3yHG4Qzp0L5csjW+VT7+avAdpGhoj5yTcIJJy64zp6nSFzs7zdprq1D8Q9Ut2TDb1kjr0h6Y1G+fELBwfP+MkescJaHTmJ6aWuS94lTC/M1xiPYEjHQU8l+uoxFXzVAm9f+6tof3HZX8pAg2FCSyn+KnXb6DMIzqcYXZWxwFbzKt8koASMIEyorGV1Pgu/HqvOc1pW1TEw1iTtm5Jm4wJV4bN7P42vSxwOzW4hhabOvYpklFR0pBmIRkLve6qsZZe1eLEqaAfQcxpA4IvD0VoCyq3fNCsRBVIG55SJTb1DeaEaoFMsGsEIxCNDaX2Zl1vW4jaiNNXXzHvTJZo0GnTR7LWdQGZxG8GpasyftH+ncJQrxpbcOeS6pnkFuiB/96kX3tfRkaBoHfnnElGR+fbjhCmuRx9DgSlA66Kn4w9jr+fwq/eL7hGdxTHwXg== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f6e6d5d-7e11-4d03-7116-08ddbd4f6c44 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7901.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2025 12:11:37.4837 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y01u5t0lj99HCeIgbeQyWwZ8V0aR89npFcBknoEQ+MLywAFcFLv1sY6zeFXXFRf8dEqktUuP+lGQD+60xVmFodvaNtimUnem31AXIpiroow= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5126 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzA3MDA3MSBTYWx0ZWRfX4RSCwqH01po0 0Ke2Z2eDx3qcdDJUuNHbDKzMG/pA4bfy6EfhE3P/tu1xdNEvqFpcNLqoKm9JZLilODe4ST5TxUe ewZZXr8KV/NRB432REvIpnLlXhI/6FUmG+OgcfVfqDU67O3v9hewQCTvOgbxUzf2To4IJ6eMpPj GhQs7HWV+jX0Zt0RaFvzXcecDvCsbf/t5ID/t4JzQzRdJjLYdC7sdCVjVafnQiIAXMG8Wp+Lc/T yf7rdQDs+zyc9s9HOavGRQXXe8hWrMLZ6UN9xGDzYXltGaVvfoZphGpIzy8Afi+9WhxMg9lX5Zx SsTZPw7K1q+mYYe0tSZntltH58PTc51OmaCP0edYPSn6rjhtUjVLyKpgiLPjhVuO7mNLSHvhr7s tFAUI7txL4GUBI/x5SBut8Ezf8QD9VHDjFmdGeClNg8HbhSa+agfjZfyGwKgV+8QDRYwzU0a X-Authority-Analysis: v=2.4 cv=V5590fni c=1 sm=1 tr=0 ts=686bb97b cx=c_pps a=p48o0NFlLrgQ9ico5GtVJQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=Wb1JkmetP80A:10 a=t7CeM3EgAAAA:8 a=A8Pz68axzIWmibrE1SYA:9 a=FdTzh2GWekK77mhwV6Dw:22 X-Proofpoint-ORIG-GUID: HcCJvkBbXZuplxngQgrRiEoQeu0R4S7x X-Proofpoint-GUID: HcCJvkBbXZuplxngQgrRiEoQeu0R4S7x X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-07_03,2025-07-07_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxscore=0 spamscore=0 priorityscore=1501 clxscore=1011 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 impostorscore=0 mlxlogscore=999 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.21.0-2505280000 definitions=main-2507070071 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org From: Malte Skarupke [BZ #25847] pthread_cond_wait was checking whether it was in a closed group no less than four times. Checking once is enough. Here are the four checks: 1. While spin-waiting. This was dead code: maxspin is set to 0 and has been for years. 2. Before deciding to go to sleep, and before incrementing grefs: I kept this 3. After incrementing grefs. There is no reason to think that the group would close while we do an atomic increment. Obviously it could close at any point, but that doesn't mean we have to recheck after every step. This check was equally good as check 2, except it has to do more work. 4. When we find ourselves in a group that has a signal. We only get here after we check that we're not in a closed group. There is no need to check again. The check would only have helped in cases where the compare_exchange in the next line would also have failed. Relying on the compare_exchange is fine. Removing the duplicate checks clarifies the code. Signed-off-by: Sunil Dora (cherry picked from commit 4f7b051f8ee3feff1b53b27a906f245afaa9cee1) --- nptl/pthread_cond_wait.c | 49 ---------------------------------------- 1 file changed, 49 deletions(-) diff --git a/nptl/pthread_cond_wait.c b/nptl/pthread_cond_wait.c index e6417997f8..11fd45f9a2 100644 --- a/nptl/pthread_cond_wait.c +++ b/nptl/pthread_cond_wait.c @@ -366,7 +366,6 @@ static __always_inline int __pthread_cond_wait_common (pthread_cond_t *cond, pthread_mutex_t *mutex, clockid_t clockid, const struct __timespec64 *abstime) { - const int maxspin = 0; int err; int result = 0; @@ -425,33 +424,6 @@ __pthread_cond_wait_common (pthread_cond_t *cond, pthread_mutex_t *mutex, uint64_t g1_start = __condvar_load_g1_start_relaxed (cond); unsigned int lowseq = (g1_start & 1) == g ? signals : g1_start & ~1U; - /* Spin-wait first. - Note that spinning first without checking whether a timeout - passed might lead to what looks like a spurious wake-up even - though we should return ETIMEDOUT (e.g., if the caller provides - an absolute timeout that is clearly in the past). However, - (1) spurious wake-ups are allowed, (2) it seems unlikely that a - user will (ab)use pthread_cond_wait as a check for whether a - point in time is in the past, and (3) spinning first without - having to compare against the current time seems to be the right - choice from a performance perspective for most use cases. */ - unsigned int spin = maxspin; - while (spin > 0 && ((int)(signals - lowseq) < 2)) - { - /* Check that we are not spinning on a group that's already - closed. */ - if (seq < (g1_start >> 1)) - break; - - /* TODO Back off. */ - - /* Reload signals. See above for MO. */ - signals = atomic_load_acquire (cond->__data.__g_signals + g); - g1_start = __condvar_load_g1_start_relaxed (cond); - lowseq = (g1_start & 1) == g ? signals : g1_start & ~1U; - spin--; - } - if (seq < (g1_start >> 1)) { /* If the group is closed already, @@ -482,24 +454,6 @@ __pthread_cond_wait_common (pthread_cond_t *cond, pthread_mutex_t *mutex, an atomic read-modify-write operation and thus extend the release sequence. */ atomic_fetch_add_acquire (cond->__data.__g_refs + g, 2); - signals = atomic_load_acquire (cond->__data.__g_signals + g); - g1_start = __condvar_load_g1_start_relaxed (cond); - lowseq = (g1_start & 1) == g ? signals : g1_start & ~1U; - - if (seq < (g1_start >> 1)) - { - /* group is closed already, so don't block */ - __condvar_dec_grefs (cond, g, private); - goto done; - } - - if ((int)(signals - lowseq) >= 2) - { - /* a signal showed up or G1/G2 switched after we grabbed the - refcount */ - __condvar_dec_grefs (cond, g, private); - break; - } // Now block. struct _pthread_cleanup_buffer buffer; @@ -533,9 +487,6 @@ __pthread_cond_wait_common (pthread_cond_t *cond, pthread_mutex_t *mutex, /* Reload signals. See above for MO. */ signals = atomic_load_acquire (cond->__data.__g_signals + g); } - - if (seq < (__condvar_load_g1_start_relaxed (cond) >> 1)) - goto done; } /* Try to grab a signal. See above for MO. (if we do another loop iteration we need to see the correct value of g1_start) */