From patchwork Mon Jun 30 08:25:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 115280 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3BC8B385C6D8 for ; Mon, 30 Jun 2025 08:27:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3BC8B385C6D8 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Q+7zlib4 X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) by sourceware.org (Postfix) with ESMTPS id C911B3858431 for ; Mon, 30 Jun 2025 08:26:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C911B3858431 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C911B3858431 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::112b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1751271986; cv=none; b=MLVq0iwbeB8wZfp8unq7wHphHgS6XisDkydDl46DmJfHrfBEQVzRT9l6cb+3MAu3LuOrzrXidNo6RGNZajbvPOga/1pPR0iTjq4GKsDEeMBHNgKpWoIjQqWaukLqfJ/Qg4vmnfS8vlT+oMQ4DuW7IIJt5icTS4eg5LgRMKSGlBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1751271986; c=relaxed/simple; bh=YEPbxCX6pqYHgGch4xlleghu1es+91ZrxYl4InP/6Xc=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=oAUBQ+CvxFQHwikpTCt57FmlsBSRs3RCnFMZwT3cRfc4UuMucnaTfmgaBvcnGkk4EyaO4yZegdSMGILWkxpsmC7naXZzwqd/Yfsf3EVbQRFwX4SEYPpIYqM20MbvWuKSMAyellttWWtFMISwFHfYDxZsPpS7wk8HiuByT4NwTzc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C911B3858431 Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-7115e32802bso18531327b3.1 for ; Mon, 30 Jun 2025 01:26:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751271986; x=1751876786; darn=sourceware.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=oRa2YdQfL+6vZAhdxW+P1l6fwKNfxY50oTQog8yTSAw=; b=Q+7zlib4w+FMvD/KpMBcSq19VxX+Nf2yhKp9sonfXkFR7N4hMz2bV5VBQs/D7y4zJ4 +xopQG0BG/2y46EFr2+Ri3ecRaFLo3gbj8UfBUIYun7/3raMO6T2Wq9qv26sdfwclHf/ NhulJ3a5It00gNeCW/5dUmOOL3UJ2aUc4Qs/DxuwTC24BVf+/nJlZdG7khmzTlXYfNYt WbHa4CEyjIe7lIjX+ub/nqhVLiSSdVngWykLbOK7SDDmHM9IXjq40wOOmfHHYG8MneLK CZT/vvUYylVDSaWLTJDtBXDEeFIusWlFUsJXRkuZ2uJ9kg5aVrL5ceehAVkQFzFLzJWm XZqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751271986; x=1751876786; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=oRa2YdQfL+6vZAhdxW+P1l6fwKNfxY50oTQog8yTSAw=; b=syy78h4PeH5Flee/kTEnD+8yxEm4VAtwbr8dZYy4hRsjJukhIGVLzdim/xr1xF/xYD 3fF1DlfbSaeumhHhvJVPyMncJZMhC0CTMj+jqEwK1vPupbsiimv3RPOJAnbVVWEAXbvJ 1p2I2F0ubRo/iwRS3U0zskcwPCibr/sq8dnR4GJ27wYOckRzAcc44+p1SdCMpZE53rsn m5Xqe9UL8hbi/enGkzBr15Up6Jf/pzv41goIdYHkVM7ahY8pZdDB61UAmXF2FR8xwRNG jSfp3rGZfTKcds+8iQEc1qx9YD3u4C/oOb2VBdC5qp7/Ti17AyN8tvHG77tWhGxKKnAy 8pkA== X-Gm-Message-State: AOJu0Yxmg4BkLF8hSV0iKqO1oh+t2q5WqOqRYes5ICFNGFAxLPriHB/8 gchDBJhOkgPaCZfVHdlMFE0wjYydG50fwNh3YR3eqEFL5vO5IGkPjV2kHKPuvDp92MBM1sKhzcp EkNZJ/jOSMXYnEGn5VQoxNSS9OeIoy7trVO35YKDnoQ== X-Gm-Gg: ASbGnctVlTvaaUjvCZvX3/4AS0654fODcAcegSF5YxLkM8b08UaBKKR4seCXI67T75k Xw9lwRQpcrME/W1k+F0PCkxKO6XcAd+1z7wjmh0zqvPCriETO887xhqtSPgfkAdtxrdI3umC8NS 681XJsCxNXxBkhYYwxw9nRqbOL1Umbl+Ps0M68T0g4tw== X-Google-Smtp-Source: AGHT+IFKJebS3nLmcjAU5M1OX7iIVt6ByFjCtTxs8LmORTj67Gx/PBqE4nRPYdhVVXtsJqseiMyztWDZ4OQ308IyH/c= X-Received: by 2002:a05:690c:688c:b0:70e:18c0:daba with SMTP id 00721157ae682-7151719a793mr176617097b3.25.1751271985993; Mon, 30 Jun 2025 01:26:25 -0700 (PDT) MIME-Version: 1.0 From: "H.J. Lu" Date: Mon, 30 Jun 2025 16:25:49 +0800 X-Gm-Features: Ac12FXyWRQ7C3IJ9KYTGRNnjtpQgMrlM9hTBIgP2Xu_igMn8rVbC1XRU-ahFD9w Message-ID: Subject: [PATCH] Compile gmon tests with $(no-stack-protector) [BZ #33121] To: GNU C Library X-Spam-Status: No, score=-3014.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org When glibc was configured with --enable-stack-protector=all and built with GCC 16, I got: FAIL: gmon/tst-gmon-gprof FAIL: gmon/tst-gmon-pie-gprof FAIL: gmon/tst-gmon-static-gprof FAIL: gmon/tst-gmon-static-pie-gprof [hjl@gnu-tgl-3 build-x86_64-linux]$ cat gmon/tst-gmon-gprof.out FAIL [hjl@gnu-tgl-3 build-x86_64-linux]$ Compile gmon tests with $(no-stack-protector) fixes these gmon tests. This fixes BZ #33121. From 7a296694a3f64799ad1d903bf5bb4f0f3991d902 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Mon, 30 Jun 2025 16:22:19 +0800 Subject: [PATCH] Compile gmon tests with $(no-stack-protector) [BZ #33121] When glibc was configured with --enable-stack-protector=all and built with GCC 16, I got: FAIL: gmon/tst-gmon-gprof FAIL: gmon/tst-gmon-pie-gprof FAIL: gmon/tst-gmon-static-gprof FAIL: gmon/tst-gmon-static-pie-gprof [hjl@gnu-tgl-3 build-x86_64-linux]$ cat gmon/tst-gmon-gprof.out --- expected +++ actual @@ -1,3 +1,2 @@ f1 2000 f2 1000 -f3 1 FAIL [hjl@gnu-tgl-3 build-x86_64-linux]$ Compile gmon tests with $(no-stack-protector) fixes these gmon tests. This fixes BZ #33121. Signed-off-by: H.J. Lu --- gmon/Makefile | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/gmon/Makefile b/gmon/Makefile index 26051ed2fb..e83c582a10 100644 --- a/gmon/Makefile +++ b/gmon/Makefile @@ -65,7 +65,7 @@ endif # The mcount code won't work without a frame pointer. CFLAGS-mcount.c := -fno-omit-frame-pointer -CFLAGS-tst-gmon.c := -fno-omit-frame-pointer -pg +CFLAGS-tst-gmon.c := -fno-omit-frame-pointer $(no-stack-protector) -pg tst-gmon-no-pie = yes CRT-tst-gmon := $(csu-objpfx)g$(start-installed-name) tst-gmon-ENV := GMON_OUT_PREFIX=$(objpfx)tst-gmon.data @@ -93,7 +93,8 @@ ifeq ($(run-built-tests),yes) tests-special += $(objpfx)tst-mcleanup.out endif -CFLAGS-tst-gmon-static.c := $(PIE-ccflag) -fno-omit-frame-pointer -pg +CFLAGS-tst-gmon-static.c := $(PIE-ccflag) $(no-stack-protector) \ + -fno-omit-frame-pointer -pg CRT-tst-gmon-static := $(csu-objpfx)g$(static-start-installed-name) tst-gmon-static-no-pie = yes tst-gmon-static-ENV := GMON_OUT_PREFIX=$(objpfx)tst-gmon-static.data @@ -101,7 +102,8 @@ ifeq ($(run-built-tests),yes) tests-special += $(objpfx)tst-gmon-static-gprof.out endif -CFLAGS-tst-gmon-pie.c := $(PIE-ccflag) -fno-omit-frame-pointer -pg +CFLAGS-tst-gmon-pie.c := $(PIE-ccflag) $(no-stack-protector) \ + -fno-omit-frame-pointer -pg CRT-tst-gmon-pie := $(csu-objpfx)g$(start-installed-name) tst-gmon-pie-ENV := GMON_OUT_PREFIX=$(objpfx)tst-gmon-pie.data ifeq ($(run-built-tests),yes) @@ -109,7 +111,8 @@ tests-special += $(objpfx)tst-gmon-pie-gprof.out endif ifeq (yes,$(enable-static-pie)) -CFLAGS-tst-gmon-static-pie.c := $(PIE-ccflag) -fno-omit-frame-pointer -pg +CFLAGS-tst-gmon-static-pie.c := $(PIE-ccflag) $(no-stack-protector) \ + -fno-omit-frame-pointer -pg CRT-tst-gmon-static-pie := $(csu-objpfx)gr$(static-start-installed-name) tst-gmon-static-pie-ENV := GMON_OUT_PREFIX=$(objpfx)tst-gmon-static-pie.data ifeq ($(run-built-tests),yes) -- 2.50.0