From patchwork Wed Jun 10 15:17:22 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joseph Myers X-Patchwork-Id: 136804 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2C6EF4BA2E29 for ; Wed, 10 Jun 2026 15:18:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2C6EF4BA2E29 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KdVKhPbo X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id E4C014BA2E31 for ; Wed, 10 Jun 2026 15:17:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E4C014BA2E31 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E4C014BA2E31 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781104647; cv=none; b=iDUSkJqB60k6E5bQiLAT3L3IXwtcT6JX+uJ4VEvGZP0YCNXtBRwSCOLnqsEor2PfMWfvBkAws3GC4kUdLhX8CxyBvfEgy1PTZCRbLBJOrJiVopwGPFfAEQTMMdV0N+P+u4rrQQSaDafsTIf1QGr4rlRjk5UEynabHLxhYC1BMH4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781104647; c=relaxed/simple; bh=PSgNseH5qu6A/KIka1mLawmO+b8eu7e7sfjp3wDpmRM=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Xd2scD1HpjNb3qSFVKTfnDNCpQPqdh+LuVwcr/WdGnooy0P7jKagPsuGwgx343Gyiz6pCUvvypinXPB8UpoMptXoBUg6rhaRnLQQIMsgb7WzEaMC9VZwKQPn8IFD48Ukp3aHXj87KGlv3T3YX/OsXdqYae/fHm6YwQdXRH4b0js= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KdVKhPbo DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E4C014BA2E31 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781104646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=ECO5NakKtNdB3u96Gdt/CMP7qgBSiIflF2P3mwnOmJc=; b=KdVKhPbocyk9AhlhdFKXe1BIfTeAyO4njr7MvFT5ckOK2KZzB1ctJHYIsU1nxXsDZusr6W 8yvzSiJfPsiS3iMHDH3oOobUxKGKODAKmTAAX8mCthGoCAIAayarhPvVsxF1YWWhM9iB0l a+joaFmkk6rkZm9AdZq26/QB0PIni7M= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-488-Jz-RohMlOlmBRznAvnRlKw-1; Wed, 10 Jun 2026 11:17:25 -0400 X-MC-Unique: Jz-RohMlOlmBRznAvnRlKw-1 X-Mimecast-MFC-AGG-ID: Jz-RohMlOlmBRznAvnRlKw_1781104644 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-45eecec7667so4884307f8f.3 for ; Wed, 10 Jun 2026 08:17:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781104644; x=1781709444; h=mime-version:message-id:subject:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ECO5NakKtNdB3u96Gdt/CMP7qgBSiIflF2P3mwnOmJc=; b=dK9Z2Bg8LnrjHndRh3P5MGPDM96XQwsDI9ChriTYUU9zlNpPXQUKxKrcihiguJI/Z3 wCDJ9pqhZ75/u0jO/II0Gyg42KUUaPim2P1ACEBswd5zh5Byrg/TJdgg/mtN39Vv6v0A iKTtzURMtL94ZBQ3dXeFuK6cpoE1kgmaq/eMqiTR53cbNHT1ZRfwk85c2QgtGg4R9YOu OP+XfD7njibAwJQNVdsL8PpxaMdyTPQ6zZhfvbmYYht2HoefahlyvGcJlZ/RDsHdcOWq dTRtovGElkulnFvRwbg4JwIXunpuxsIzS/Wq/yzyx75erR8p/DE2vkbrA6SZm47JG61N D+uw== X-Gm-Message-State: AOJu0Yyj59oiwSWgrrfL/5B+f3Wv8fsFV+juS2d5+oPoFQ+WSWSKzguu jZEFjrfS62PhMT/b++j/8gEy5fWe5XuYb9K4wokqGG4CgGU2VmpoR6VAHlm372blP/N9k7jXfh0 /f4/tnYH3cYLpXXmYZnTKgUm8quP9ycy7eoGh6QgG4DctQQ/tGXhKZqW+opIEnOGblaSwRwrVxc pfDbiuGEet3LM8k4dfo5fefkSHY8EeQII7gBTf8Wnm/bxaFw== X-Gm-Gg: Acq92OGkpMJxMBa6NHLKXBMV7J0lBsDpiPXPaUa84e2aQvaaw9BKoiLkwjd2AbyEhLC McRV3n7j5vudy+NI41uvJaRJtWtSvnX0fE+x6GwjyCeNUHvosQc5pZc/MEKuKs4ODSQfExKrrtY MlX5VxKRFnvuHQgUn1OfVjEaNSRtI6PmRnc1xR3VdNOeP59y6PWJ4gUXJqQPzuvWhn9L6eEjJRu J0Ty/Hppn0i6KnTTN/iFWqJb/d5wrX2iQ8QFN352zgSyHy8Rx9RD7xns4GxvNL4hu6aqUzmJ0Wp LJDqsXALV/u9PPei/h45jH5fuSonypCKyBFi93VOexg39CDkuwj27pwNCovSzbKVoXYIxeiFuR+ zk2hDri222fJ1ZxYMeFBOWY/nynu7gfngd1PtO17u3uDHTHT9/IyIIqHwFfDzeI8= X-Received: by 2002:adf:e30e:0:b0:460:1233:ecf2 with SMTP id ffacd0b85a97d-46030609798mr29878817f8f.30.1781104643933; Wed, 10 Jun 2026 08:17:23 -0700 (PDT) X-Received: by 2002:adf:e30e:0:b0:460:1233:ecf2 with SMTP id ffacd0b85a97d-46030609798mr29878773f8f.30.1781104643513; Wed, 10 Jun 2026 08:17:23 -0700 (PDT) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46028a6dce6sm65173076f8f.30.2026.06.10.08.17.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 08:17:23 -0700 (PDT) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.98.2) (envelope-from ) id 1wXKgE-00000000DD9-0sv9 for libc-alpha@sourceware.org; Wed, 10 Jun 2026 15:17:22 +0000 Date: Wed, 10 Jun 2026 15:17:22 +0000 (UTC) From: Joseph Myers To: libc-alpha@sourceware.org Subject: Fix -Werror=constant-logical-operand errors in soft-fp Message-ID: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SFB6kKz2w3ihN1yXo0kYhB1V2jz3DsoU8lvosfbWrrE_1781104644 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NONE, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org Building for sparc64-linux-gnu with GCC mainline produces a series of -Werror=constant-logical-operand errors in soft-fp code, relating to calls to _FP_TO_INT where rsigned is -1 not 0 or 1. Use explicit != 0 in the soft-fp code to avoid these errors. Tested with build-many-glibcs.py (compilers and glibcs builds) for sparc64-linux-gnu with GCC mainline. Reviewed-by: Adhemerval Zanella diff --git a/soft-fp/op-common.h b/soft-fp/op-common.h index ce8d60ee26..49d47efd32 100644 --- a/soft-fp/op-common.h +++ b/soft-fp/op-common.h @@ -1510,7 +1510,7 @@ } \ \ if (_FP_EXPBIAS_##fs + (rsize) - 1 < _FP_EXPMAX_##fs \ - && (rsigned) \ + && (rsigned) != 0 \ && X##_s \ && X##_e == _FP_EXPBIAS_##fs + (rsize) - 1) \ { \ @@ -1555,7 +1555,7 @@ _FP_FRACBITS_##fs); \ _FP_FRAC_ASSEMBLE_##wc ((r), X, (rsize)); \ } \ - if ((rsigned) && X##_s) \ + if ((rsigned) != 0 && X##_s) \ (r) = -(r); \ if ((rsigned) == 2 && X##_e >= _FP_EXPBIAS_##fs + (rsize) - 1) \ { \