From patchwork Tue Apr 21 12:50:15 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Liebler X-Patchwork-Id: 133479 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id DFA124B9DB6D for ; Tue, 21 Apr 2026 12:51:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DFA124B9DB6D Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=hHHBvRKX X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id BC79E4B9DB4F for ; Tue, 21 Apr 2026 12:50:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BC79E4B9DB4F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BC79E4B9DB4F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776775837; cv=none; b=dGG8eqqlJ9PfftL/cU+xLP1xlIxuiAyTK3jepZ8fJB+7JXaBH6fs2pNiN2UhZKG0BhuXy9J9mjzXV6SsaFD62ZCH42qwfxXvgwkLEg6iWTUlH7q28LTbcDJEGAzWr/84rzOZIvA7TfrMg8b/stltHvFxkziKF7ILQrVX5vwRFxA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776775837; c=relaxed/simple; bh=LDD7NmOvU9d6NY4h9UpWI3FlEvtrPhN4hw0EOxFry4E=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=DvOqHUh+VH1cz7nAy3sVzlLE5trg4hdNMd8Dmqtobl33LeLTjj4yJzUc4vAG2RLSea/A7TICjUyCquvCVygsJqxnfsErgahdyNWqqSkvllDJvTIt2ApyPv05PuDVW+XjQUnx43kRl7tvjo7OMeQ7jK4IHt1bjPKMMgt/f/+C0I8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BC79E4B9DB4F Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63LCaBCr2330050; Tue, 21 Apr 2026 12:50:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=Os0CiGck+xRuxIEJOktPG/mlrw7GkYJ5Z1b2Jw8a7 OA=; b=hHHBvRKX7ftqIUKUe6xkMqI9sV7C/pHnUIxPkaScIjqBh66AMAIPU7pW2 i4lMUl1fNECl3fuM/uMn/nyAu7OWdTPc2NYQe4EPji9VJkLUk8W1fXbLr+i1KV5h MeQ7aL+U4krkbh3FvsJVpUdElmzNZ8GIw7uY8uhWy23Ox+JbO5zzmhiUlio+Am7p uh/0Q4UaOo8LTSGoHZrMdQS+/QyhwGJVKgPmEsc3KGfkArIjm1SdEDQGOZoS4GVF KZG2I4KGcs6VaKMHStKKaAkSk15hwx593Opbrzn5ChNdVlQNALiaXRnXEIzZ+5q0 h0uGGkBlEhIP4WoyHo+88VXGPl5fQ== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dm2k0uhuq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Apr 2026 12:50:36 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 63LCoaiS025063; Tue, 21 Apr 2026 12:50:36 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dmn9k0pkq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Apr 2026 12:50:35 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 63LCoV3g52167120 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Apr 2026 12:50:31 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C14662004F; Tue, 21 Apr 2026 12:50:31 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AC80D2004D; Tue, 21 Apr 2026 12:50:31 +0000 (GMT) Received: from a35lp68.lnxne.boe (unknown [9.87.84.240]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 21 Apr 2026 12:50:31 +0000 (GMT) From: Stefan Liebler To: libc-alpha@sourceware.org Cc: Adhemerval Zanella Netto , Stefan Liebler Subject: [PATCH] s390: Remove Wno-CFLAGS for rtld.c/dl-load.c/dl-reloc.c Date: Tue, 21 Apr 2026 14:50:15 +0200 Message-ID: <20260421125015.3313313-1-stli@linux.ibm.com> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: Wc14rPNl7U_BqTRDqG2hBLRsfRv1FcoF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIxMDEyNyBTYWx0ZWRfX+M/45KNKihpB jF8+i0T88at/PulSvlc0n64ve0CgGN8WQTjwoBlKP5V2HV8VA9NNCrgsDhjAtHE4DCc5jWAQ6+a UmFlwXVHEA8hGQqs6MsaLbAkpNvjTfsBluMnpX72amTz8eq1+czY2VgnQp4PiPpHy/d7qzv58+8 5kuHXaCgdiDUU6h1d6fsYL+A7pGOlPeY4cKl/05BbL9avFr9w82c8rOIkHV7XOY+KDz50d/ysQ0 e1uF9FTe7gdjzR6xtsMqiXfNUeMrXxZHv7iIZWuIRQCUN/ZFwmNvEcJwUr09pdWwWigT+3cdDoj acK0u6voIxZGCTQpQdjhya1CtSXe5HhEF05HRels14jBfW5Z32VAoq8h8mCDyRh5+r0nxDakBPS d4dDtiN4+1mel4n7fmYfL74f6sZ2Y1bDEly/sRzAloaSWXQwlHEKEiJa6c28X6WU7lsmeRerEge 9njI18XsvimXkaNeR9w== X-Authority-Analysis: v=2.4 cv=PtujqQM3 c=1 sm=1 tr=0 ts=69e7729c cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=CCpqsmhAAAAA:8 a=VnNF1IyMAAAA:8 a=BxQziMYRpeD1P8iSzOYA:9 a=ul9cdbp4aOFLsgKbc677:22 X-Proofpoint-GUID: Wc14rPNl7U_BqTRDqG2hBLRsfRv1FcoF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-21_02,2026-04-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 clxscore=1015 spamscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604210127 X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org While review of s390-32 removal, Adhemerval asked if those CFLAGS are still necessary: https://inbox.sourceware.org/libc-alpha/20260409085102.3475867-1-stli@linux.ibm.com/T/#me5120906445f3941031e29c3a093f1699eae77b4 According to the git-history, the first s390-Makefile was introduced back in 2000-08-02 with those CFLAGS. The same are also included now and past in i386-Makefile. But I haven't found a reason why those were added in the past and if it was really necessary on s390. I assume it was with old GCCs most likely due to inclusion of dl-machine.h. This patch removes those CFLAGS. If needed, we have to circumvent the issues again. At least I've used current GCCs 12.5, 13.4, 14.3, 15.2 and gcc-head to successfully build current glibc on s390-64 with -O2, -O3 and -Os without such warnings. --- sysdeps/s390/Makefile | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sysdeps/s390/Makefile b/sysdeps/s390/Makefile index 29d11dfdab..85446ca0b3 100644 --- a/sysdeps/s390/Makefile +++ b/sysdeps/s390/Makefile @@ -47,10 +47,6 @@ $(modpfx)gconv-modules-s390.conf: ../sysdeps/s390/gconv-modules-s390.conf \ endif ifeq ($(subdir),elf) -CFLAGS-rtld.c += -Wno-uninitialized -Wno-unused -CFLAGS-dl-load.c += -Wno-unused -CFLAGS-dl-reloc.c += -Wno-unused - $(objpfx)tst-glibc-hwcaps: \ $(objpfx)libmarkermod2-1.so \ $(objpfx)libmarkermod3-1.so \