From patchwork Mon Jan 26 16:28:34 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Boccassi X-Patchwork-Id: 128986 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 054844B920ED for ; Mon, 26 Jan 2026 16:30:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 054844B920ED Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=WpdFTMHM X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 309E64BA2E06 for ; Mon, 26 Jan 2026 16:30:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 309E64BA2E06 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 309E64BA2E06 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769445024; cv=none; b=SKlyozv2bPoK3SZbmsZ2KOdffunfrwW1ge65tElfd0HbqQqTjbeoj494dMbApd0WZGzPUi9hhRUipGZ8at6dwpCY8YGsbccYaR68nM7wN3ouUIPBUGgpIPMqt3ScMyOfh6ezbfR799k976yHcEOegKBDckJVmdeDPq7ArJ+AkGc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769445024; c=relaxed/simple; bh=r7j/bgdvX1gaRE2CTYCb+rsWPNNFjn/1m74eUGPBppo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=OC6dvEN0V8TNrKj8vaNlIEH953XR0bEU4BK0MjC2yACVlQdTbbSnXw+JmW0zlZSYk800lHPp8tx43rmggFcRGcOfOgZp8covciTjCJBL60Up2OdvyIIgyzvNzKg6pzfuoAZqF5JbG7Nt5YSXwVDSu2896STcwiAKHpkEDEnz0LM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 309E64BA2E06 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-435a517be33so2882116f8f.0 for ; Mon, 26 Jan 2026 08:30:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769445023; x=1770049823; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jh+L9d62/EMrCJA/vzyi+cpz03e6H1vBvJBqofy4PEQ=; b=WpdFTMHMM8W8eZFru5leQaDxN8pdsmaYTbE+uE/uWsTJqLSYYY8fISPm2qeJI8If1o B01IXb3c5DkiJ1/3IZYkscFiMbgolC7AGOlhnhYubZh1ARndPRoVGJEp4Fnnu2WN1enu e1iUw8yHg/g0yCZ3sC+iKEKLtxpNLxr/A3KtQLBBtmlNQWGTDbZJDvlArKBhPP6wU/Z7 80CaFHb7reoiebuF5s/hj0/oG5nhd/21HFtsGKcZ0dZT94nLupH/R0inIEjearvFg2k2 DFcF/WkzppFE+zc3hKFxVteZDHkvKN4nGLEVErNcu5mqbSLqwyjGhxlfwipuYAj5Hg87 KlVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769445023; x=1770049823; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Jh+L9d62/EMrCJA/vzyi+cpz03e6H1vBvJBqofy4PEQ=; b=rCqfnU+OtFcBylPISG5YKo/6cIzCBD8H+u5vz0AsMwBCDeaS2SZscYnP5lrsPWm7Po sbldtTyeEAAGiCejvQWVXYiNoEoVMkxX+pArZiQD92AhCqN9GpbE+Zs5EKmc4uN9Polf AWXJ9wXVr7rDyIMjikVh1E4ZJrJIKHqZURItkdXxXol+5r1KN23eC3uGfcvVzSA+W7eN W5M0hztTkqsmjgSMJx/1A/euZXlUVzj93N8njOmniQV4C8hnOWrRE8FNZ2qO01lW+qnu 0DeILI5/LrXbZSb1Lie39nCvHt6cS24YMmSS94yphDHC2LA9pdQuHmMFkAocphjHUf3U /YZQ== X-Gm-Message-State: AOJu0Yy2RPHyLKRUIfqEEn3osQBfoH8fXGBK7+LXAzHw2Oy0JD6jDsq+ sZF8fryhZKFqSZoYxWyHaCZfNNhM/Pu/wzNMwYLRJXcmO29ECiQ9YxPGajXLDQ== X-Gm-Gg: AZuq6aJk5CLq+LkCgS3Ky13ntvyWO1wWTGuk7GAVgGZVBN5Wq54TfAKxeOuGIi4Rd/m kOvGm/tt6Ew26fQsLs+UyipwQo+Q6F9sqQDezgR7eSnOEiUrNRYcLxGenPe2dK6azJgUwlxYAN/ BSjRxDfWr1qXdFJR6Igcwpq4W8oIMoaaIcMTG43qFShUm+UHecWO6gdobWnBAz2IH6andHJQNLF pcSfz7UCx7ljv/MzTpCQTh6OloRZ3Pn2oHAjPJRkRyXXulWWy00sMMqZvzXPK1CdFmve/rKr4yj zA57KNsSTKs0nAHOORd8Fj5K0dmk5Hs+zc0plMQzWl9OYMuOWpXWPiWZfMgI/uqrpPsuAWukbCp wccTyUPmx9nyag1PkAiayN/e76e3J1holdV6Wu83nqAip+N1QAc71sJ9DNJuAm/2cLKDcY1I0RW eCIritKsghhWL4+JobvLKHNBvEJyw= X-Received: by 2002:a5d:5d09:0:b0:435:99d5:9d90 with SMTP id ffacd0b85a97d-435ca0d1277mr7868310f8f.3.1769445022584; Mon, 26 Jan 2026 08:30:22 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:53d2:28bc:8a2d:b680]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-435b1c24ac1sm30986482f8f.14.2026.01.26.08.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 08:30:22 -0800 (PST) From: luca.boccassi@gmail.com To: libc-alpha@sourceware.org Cc: adhemerval.zanella@linaro.org, fweimer@redhat.com Subject: [PATCH v5] linux: use PIDFD_GET_INFO ioctl for pidfd_getpid() if available Date: Mon, 26 Jan 2026 16:28:34 +0000 Message-ID: <20260126163020.372708-1-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260124220504.709905-1-luca.boccassi@gmail.com> References: <20260124220504.709905-1-luca.boccassi@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_GMAIL_RCVD, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org From: Luca Boccassi Linux v6.13 introduced a new ioctl to query info from a pidfd. The advantage of this vs. parsing /proc/ is that it works even when procfs is not mounted. It's also a single syscall, and doesn't need manual string parsing. Use it when available. Signed-off-by: Luca Boccassi --- v2: use sys/pidfd.h instead of installed kernel headers v3: add __ASSUME_PIDFD_GET_INFO use atomics for support cache var v4: drop support cache var v5: drop static helper given it's just the ioctl call now, simplifies the flow sysdeps/unix/sysv/linux/kernel-features.h | 8 +++++ sysdeps/unix/sysv/linux/pidfd_getpid.c | 39 ++++++++++++++++++----- 2 files changed, 39 insertions(+), 8 deletions(-) diff --git a/sysdeps/unix/sysv/linux/kernel-features.h b/sysdeps/unix/sysv/linux/kernel-features.h index 01c865e2d5..94bdbbb730 100644 --- a/sysdeps/unix/sysv/linux/kernel-features.h +++ b/sysdeps/unix/sysv/linux/kernel-features.h @@ -269,4 +269,12 @@ # define __ASSUME_MSEAL 0 #endif +/* The PIDFD_GET_INFO ioctl was introduced across all architectures in Linux + 6.13. */ +#if __LINUX_KERNEL_VERSION >= 0x060D00 +# define __ASSUME_PIDFD_GET_INFO 1 +#else +# define __ASSUME_PIDFD_GET_INFO 0 +#endif + #endif /* kernel-features.h */ diff --git a/sysdeps/unix/sysv/linux/pidfd_getpid.c b/sysdeps/unix/sysv/linux/pidfd_getpid.c index 860829cf07..33d4f2c9ba 100644 --- a/sysdeps/unix/sysv/linux/pidfd_getpid.c +++ b/sysdeps/unix/sysv/linux/pidfd_getpid.c @@ -23,8 +23,11 @@ #include #include #include +#include +#include #include +#if !__ASSUME_PIDFD_GET_INFO #define FDINFO_TO_FILENAME_PREFIX "/proc/self/fdinfo/" #define FDINFO_FILENAME_LEN \ @@ -91,15 +94,9 @@ parse_fdinfo (const char *l, void *arg) return 1; } -pid_t -pidfd_getpid (int fd) +static pid_t +getpid_fdinfo (int fd) { - if (__glibc_unlikely (fd < 0)) - { - __set_errno (EBADF); - return -1; - } - char fdinfoname[FDINFO_FILENAME_LEN]; char *p = mempcpy (fdinfoname, FDINFO_TO_FILENAME_PREFIX, @@ -126,3 +123,29 @@ pidfd_getpid (int fd) return fdinfo.pid; } +#endif + +pid_t +pidfd_getpid (int fd) +{ + struct pidfd_info info = { .mask = PIDFD_INFO_PID }; + + if (__glibc_unlikely (fd < 0)) + { + __set_errno (EBADF); + return -1; + } + + /* New in kernel 6.13 */ + if (ioctl (fd, PIDFD_GET_INFO, &info) < 0) + { +#if !__ASSUME_PIDFD_GET_INFO + if (errno == ENOTTY || errno == EINVAL) + return getpid_fdinfo (fd); +#endif + + return INLINE_SYSCALL_ERROR_RETURN_VALUE (errno); + } + + return info.pid; +}