From patchwork Mon Jan 26 16:10:59 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Boccassi X-Patchwork-Id: 128984 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id B88E24BC7ECA for ; Mon, 26 Jan 2026 16:12:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B88E24BC7ECA Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=CXQJou+K X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 5A4AE4BA9007 for ; Mon, 26 Jan 2026 16:11:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5A4AE4BA9007 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5A4AE4BA9007 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::431 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769443903; cv=none; b=rCDKbvC9RCC9rNFdwtY5e2RzX1eAmwo81Os3nPet/FRQzWsFAqPLHEKuL6d5rm8zb79PbIVEdiODOMLy4x2B/X00HgfPmsOpIH7r9itNPhCScEsPrmW6r9hbBAo4oFgTApkIfvgrv/O3nWxkulT27J3nAR4zn0DgFBsYdh2mNAA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769443903; c=relaxed/simple; bh=gecW1nddxTujUiZk7ZVUn3PiqYDA9L+mJK6t3wqgPW4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=U59Kp5Zkr+uyuLEq3tlloA736hRBiRAmjxfUpxAwczBYBTB5ZduxvIisRHQIPXC/IxECBPBdUkYWqGYHtw7QTeTrnciuvACPrvu6uINmxzUwDQN8w++BK6ozRnb2/MUrk6E0x2sZpfrLfUqXx+CIest4lYcrYiPB0uTtNi4vhys= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5A4AE4BA9007 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-430f2ee2f00so2776341f8f.3 for ; Mon, 26 Jan 2026 08:11:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769443902; x=1770048702; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Yf+MTjC0Ogll3I/LXwsGB8/zpeP6ZtoBAg1sKK9DQEw=; b=CXQJou+KUpo6lKBBxyqqJD1jE04dytnuUEB+rZCZNk+Xeb53xbvfuiCFzAXL45PPGa mjY02DaoZ8MTHNMj4PNV0xmfNGf9/SsC97oc91reIXpx68T11AYqTp3W9YpiVcEnwZRL Sg3R/Bx+Mkk+1eUNPzemG0VvgKdicED/0JVZgs8kjM3IpqRVA9lM4yeef7n9fbPvNKFw e1uLy/SYLsCD2ffCtUqEjczJAtl7QD1YCQ17t5yJUZJ2YbUh5FLHY27DifMdPmN9rHPu eg6yO4aafPBvJd43elcIe3j3fz1rN/xFsxB9LZQcYAOdWeSfMEYSoQ+PHoEJgx4RjTiK ocBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769443902; x=1770048702; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Yf+MTjC0Ogll3I/LXwsGB8/zpeP6ZtoBAg1sKK9DQEw=; b=f2h0+wJq592KdUYm4aQnOY9fQQeGC8pupX4a08xx/6RrjyAUlzBLB+IDbZlfVlxNIa /1wqEtDpt8sydKeeOZw9vgPgyzOSRF8VHSd/meoDKe64MH6quGRE8Z+W3L1cVQC4k0Ay mWH1L3oETeM8lb69MrQRppIZRctTCAkH+wj42SC5g1Lxtj/5DXhVD819J8lYJ3loW3mz ZzruW6FKZimn42+3UZ5PATPQqYD5JACn42IA9x5k6Cvf46ADcr2rYAk0/QWOD0mB90ks LAbMxADz3zDK3MffFpovLvlnmtyPb8GSWcZZic2gY9DSK+SQB+jstuhHHxb2YlUXl71W Pn9w== X-Gm-Message-State: AOJu0YyUYULquVHiDRMP3u17WvjvE293jsTcEGR2N2sihHK9R6rEyAEm viQi6ruB83I9p6us/1HN3eVETiXexHeEP5C0veHqpND9NXJFt+0p72ZEvEv1Yw== X-Gm-Gg: AZuq6aJYY6ym318sjz8jnfBecg9zCROwvepdZqIDoElkp75lj1F3WF6r6QY0Og2DXZm BSUNpLfZEHRuWx9px02M36qHyTV8yhujbDIVGSIYccGCzGZ5vvjxI++Ww4LMVuMJKUamVhQv75u MGp9l7XN3FWC5KgnCt7Gdv1e0GZBi+kowYb3b79J/wxR7gxKFHtJCj3eMqN92ybqFIwj4zm74SC AfG3vuvNIeXzy3UbB3I1GSa7mfrY4Yue2v8dWui93OEZuWZscbaTjWLzmuM/3ukUWpYlpHpL+SC d4CAxOsWsbBcfocjJiPQCO6hxrPu7fsUubTaegoJ5bEjRSnbdzCwQGnfgBALVBxX5+HUJHIdyqB FeEkRyu03Yp/49j/aeWKWb6G2kX1TqamvojmLP0Kyy9dqHGjvZYehS26hwgu7T9lAlqr20oAS6/ dyrFHUGzEn5O5OJdTp X-Received: by 2002:a05:6000:2512:b0:431:9d7:5c2e with SMTP id ffacd0b85a97d-435ca1adc71mr9010649f8f.35.1769443901824; Mon, 26 Jan 2026 08:11:41 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:53d2:28bc:8a2d:b680]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-435b1c02f71sm31501460f8f.6.2026.01.26.08.11.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 08:11:41 -0800 (PST) From: luca.boccassi@gmail.com To: libc-alpha@sourceware.org Cc: adhemerval.zanella@linaro.org, fweimer@redhat.com Subject: [PATCH v4] linux: use PIDFD_GET_INFO ioctl for pidfd_getpid() if available Date: Mon, 26 Jan 2026 16:10:59 +0000 Message-ID: <20260126161136.366228-1-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260124220504.709905-1-luca.boccassi@gmail.com> References: <20260124220504.709905-1-luca.boccassi@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org From: Luca Boccassi Linux v6.13 introduced a new ioctl to query info from a pidfd. The advantage of this vs. parsing /proc/ is that it works even when procfs is not mounted. It's also a single syscall, and doesn't need manual string parsing. Use it when available. Signed-off-by: Luca Boccassi --- v2: use sys/pidfd.h instead of installed kernel headers v3: add __ASSUME_PIDFD_GET_INFO use atomics for support cache var v4: drop support cache var sysdeps/unix/sysv/linux/kernel-features.h | 8 ++++ sysdeps/unix/sysv/linux/pidfd_getpid.c | 53 +++++++++++++++++++---- 2 files changed, 53 insertions(+), 8 deletions(-) diff --git a/sysdeps/unix/sysv/linux/kernel-features.h b/sysdeps/unix/sysv/linux/kernel-features.h index 01c865e2d5..94bdbbb730 100644 --- a/sysdeps/unix/sysv/linux/kernel-features.h +++ b/sysdeps/unix/sysv/linux/kernel-features.h @@ -269,4 +269,12 @@ # define __ASSUME_MSEAL 0 #endif +/* The PIDFD_GET_INFO ioctl was introduced across all architectures in Linux + 6.13. */ +#if __LINUX_KERNEL_VERSION >= 0x060D00 +# define __ASSUME_PIDFD_GET_INFO 1 +#else +# define __ASSUME_PIDFD_GET_INFO 0 +#endif + #endif /* kernel-features.h */ diff --git a/sysdeps/unix/sysv/linux/pidfd_getpid.c b/sysdeps/unix/sysv/linux/pidfd_getpid.c index 860829cf07..5399fd74f9 100644 --- a/sysdeps/unix/sysv/linux/pidfd_getpid.c +++ b/sysdeps/unix/sysv/linux/pidfd_getpid.c @@ -23,8 +23,11 @@ #include #include #include +#include +#include #include +#if !__ASSUME_PIDFD_GET_INFO #define FDINFO_TO_FILENAME_PREFIX "/proc/self/fdinfo/" #define FDINFO_FILENAME_LEN \ @@ -91,15 +94,9 @@ parse_fdinfo (const char *l, void *arg) return 1; } -pid_t -pidfd_getpid (int fd) +static pid_t +getpid_fdinfo (int fd) { - if (__glibc_unlikely (fd < 0)) - { - __set_errno (EBADF); - return -1; - } - char fdinfoname[FDINFO_FILENAME_LEN]; char *p = mempcpy (fdinfoname, FDINFO_TO_FILENAME_PREFIX, @@ -126,3 +123,43 @@ pidfd_getpid (int fd) return fdinfo.pid; } +#endif + +static pid_t +getpid_ioctl (int fd) +{ + struct pidfd_info info = { .mask = PIDFD_INFO_PID }; + + /* New in kernel 6.13 */ + if (ioctl (fd, PIDFD_GET_INFO, &info) < 0) + { +#if !__ASSUME_PIDFD_GET_INFO + if (errno == ENOTTY || errno == EINVAL) + return -EOPNOTSUPP; +#endif + + return INLINE_SYSCALL_ERROR_RETURN_VALUE (errno); + } + + return info.pid; +} + +pid_t +pidfd_getpid (int fd) +{ + if (__glibc_unlikely (fd < 0)) + { + __set_errno (EBADF); + return -1; + } + +#if __ASSUME_PIDFD_GET_INFO + return getpid_ioctl (fd); +#else + pid_t pid = getpid_ioctl (fd); + if (pid != -EOPNOTSUPP) + return pid; + + return getpid_fdinfo (fd); +#endif +}