From patchwork Mon Jan 26 12:36:19 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Boccassi X-Patchwork-Id: 128968 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id E151C4BC8953 for ; Mon, 26 Jan 2026 12:38:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E151C4BC8953 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=McdNjP+n X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 121004BA9004 for ; Mon, 26 Jan 2026 12:36:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 121004BA9004 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 121004BA9004 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769431019; cv=none; b=b8+DkT/XMnrvb2yu9/BmmK0IRTgdD3m9w2zZcpbvbXRlqCU/UAKv5I8RLxZIoj3yjd2rIZc1jpRBKATjW2Gzao2sbrWTXSAskOm6mr+XvxdU0LkRb+L2mpLV0Ha/YkfRmQnovhRBEixzLA4bTplsHgYfF6lcik7GHwRIvqXO0bI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769431019; c=relaxed/simple; bh=AF7lyxxT4UsAmkEon6cLtqOnwgB8L87zKSecLK+ZHcc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WAU1UzW7wqXhSZMWaVrITUP1BoVor/pWCuB+OePLmSvQkmnOIApKxXyQt9kLHSqTAKPSPFJxLy7wCXILVKxS+EyclPsqs3oW0NrvJt1tAF4C5CmBfvasmvfj/pizS0YJtETrXk/qnAoOgNdfEvUWSQZE654Wxvj9FUqwQRH1ogc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 121004BA9004 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-43246af170aso2524424f8f.0 for ; Mon, 26 Jan 2026 04:36:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769431018; x=1770035818; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fsKl91uyEmgV+w1kqhbzQa7YTWPAWBbAEqPSfwBvmMQ=; b=McdNjP+npQZWjjNusrGBoksPkuRcaIK24YQ5f7OdTa2OR1yOJxWCl7DtIcAA+iU1ZZ HcHS5YrdTSXye+MFtZvtha/0jCTPTEnMHEHdJMaq2nIMYJLATGAHLrOg1sVfTEipafwj ioSSwsdyeEHc92aFZCRYqjslT2AdcUZmoWR4SJ2Lki+dv11DomfUVBz6CttrH6pfMLPL SrT6HFvUXYznYqTn7bAZrUH7Nn+wpjLhfDUQztBu6pjHQQ7N/1hvF7Ih/SxiI10mJcfn TRV5Xpn5k70ctbCi3d32shtC05yrCLt2x4qvwTDUIySNpWRTEmgEt2pT48DfQEt5aBrW 5Mew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769431018; x=1770035818; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fsKl91uyEmgV+w1kqhbzQa7YTWPAWBbAEqPSfwBvmMQ=; b=ow5v23Yr9MeIA8KXVl3PfU50VK9eTOuJRNsgM0IjhszeJ/5G0z0dpLU6vUL0oBTgtL Yy07bQW9TwtRcRMKbHaHratavvLhlCtE2OpFhciUkGyB0kRxQDaJUQhp+Gk4u1zMomtr NoljyOtl4ggV2g1VeHeoTuq2oh1M+3JG2T5tWS1qBv2BOsSwR7cRtRy5n+2qC8z0J3qH xooDDIzjwd1z4XfRk52DgZRhLKmd/eoSu2QV0MyzXqUKxuDFrm47zKjAFFWJPpwS71bs Io1MipsseP0eVtNYA2YD5qyJ8ny8bVqVan/aYmMwpBHefq+KOKHK3fE+PeqqJq655c5L kwkA== X-Gm-Message-State: AOJu0YyKmKD6ic2y/vg8AwMuNu+vk946IGPewcbbYn37qff0f5iwy+At 9r63/W68eqZBDj+VVIIYZKT5HLe+Ntv8tAC/PCLydsUIgb6F022h6LebTztflg== X-Gm-Gg: AZuq6aKje5kdC2F1MAVSpB/oOekqPBCrMhDNNKh1p6CJjFQFQzAZSaQx/1iEfshOAHR CDNFiWd02rlYBSKPh224/xN6DmRpewlwPt+VTpqbp2SoizYxfkFiiCuYc9pYG1ajYU/a7UfcA69 gf82xrtKg0hIpZQdrrcLdVNWbZ3eD3uypTQjPogABAtI4+L7dUaCD7NwkyCsuqng+bx8PA1dqJv fP7dQmv6Y1qv6mJ34H+V8KUn7SowQhnbnGC32iqQ+DlDXxyUUQeL2D5/CwKDY/LSw0IHYNID8zd hRl0B660XCzob8EH2aATW28KkRhlvzZf8c/wS6ZsVQ3SzkOGAdWeVGWBNAljp7tR/AHcnIeGC8R JxV1zCSHuWhGdiBl84QVyDyVEsPY0A3hesWZPLktZEk2LfZ0BmaR1QG7rKO2NOBQ2kXWMqbwui6 BUfxPVAEX1B0kuE20Q X-Received: by 2002:a05:6000:1a87:b0:432:dcb1:68bc with SMTP id ffacd0b85a97d-435c9d1c693mr7123373f8f.23.1769431017475; Mon, 26 Jan 2026 04:36:57 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:bae2:4383:eaf2:23e7]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-435b1c24ac1sm29602343f8f.14.2026.01.26.04.36.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 04:36:56 -0800 (PST) From: luca.boccassi@gmail.com To: libc-alpha@sourceware.org Cc: fweimer@redhat.com Subject: [PATCH v2] linux: use PIDFD_GET_INFO ioctl for pidfd_getpid() if available Date: Mon, 26 Jan 2026 12:36:19 +0000 Message-ID: <20260126123653.1008836-1-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260124220504.709905-1-luca.boccassi@gmail.com> References: <20260124220504.709905-1-luca.boccassi@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org From: Luca Boccassi Linux v6.13 introduced a new ioctl to query info from a pidfd. The advantage of this vs. parsing /proc/ is that it works even when procfs is not mounted. It's also a single syscall, and doesn't need manual string parsing. Use it when available. Signed-off-by: Luca Boccassi --- v2: use sys/pidfd.h instead of installed kernel headers sysdeps/unix/sysv/linux/pidfd_getpid.c | 52 ++++++++++++++++++++++---- 1 file changed, 44 insertions(+), 8 deletions(-) diff --git a/sysdeps/unix/sysv/linux/pidfd_getpid.c b/sysdeps/unix/sysv/linux/pidfd_getpid.c index 860829cf07..fb9fd21e68 100644 --- a/sysdeps/unix/sysv/linux/pidfd_getpid.c +++ b/sysdeps/unix/sysv/linux/pidfd_getpid.c @@ -23,6 +23,8 @@ #include #include #include +#include +#include #include #define FDINFO_TO_FILENAME_PREFIX "/proc/self/fdinfo/" @@ -91,15 +93,9 @@ parse_fdinfo (const char *l, void *arg) return 1; } -pid_t -pidfd_getpid (int fd) +static pid_t +getpid_fdinfo (int fd) { - if (__glibc_unlikely (fd < 0)) - { - __set_errno (EBADF); - return -1; - } - char fdinfoname[FDINFO_FILENAME_LEN]; char *p = mempcpy (fdinfoname, FDINFO_TO_FILENAME_PREFIX, @@ -126,3 +122,43 @@ pidfd_getpid (int fd) return fdinfo.pid; } + +static pid_t +getpid_ioctl (int fd) +{ + static bool cached_supported = true; + struct pidfd_info info = { .mask = PIDFD_INFO_PID }; + + if (!cached_supported) + return -EOPNOTSUPP; + + /* New in kernel 6.13 */ + if (ioctl (fd, PIDFD_GET_INFO, &info) < 0) + { + if (errno == ENOSYS || errno == EINVAL || errno == ENOTTY || errno == EOPNOTSUPP) + { + cached_supported = false; + return -EOPNOTSUPP; + } + + return INLINE_SYSCALL_ERROR_RETURN_VALUE (errno); + } + + return info.pid; +} + +pid_t +pidfd_getpid (int fd) +{ + if (__glibc_unlikely (fd < 0)) + { + __set_errno (EBADF); + return -1; + } + + int pid = getpid_ioctl (fd); + if (pid != -EOPNOTSUPP) + return pid; + + return getpid_fdinfo (fd); +}