From patchwork Thu Nov 13 14:59:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos O'Donell X-Patchwork-Id: 124176 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 71A6B385841F for ; Thu, 13 Nov 2025 15:01:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 71A6B385841F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=b599YxQh X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 7E79A3858D20 for ; Thu, 13 Nov 2025 15:00:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7E79A3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7E79A3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763046016; cv=none; b=wTqHGdxJoI/LPfe3GSlA471QQfdJQR5zTPnt/Lfro4VyTmK9oXWN7FFF02Wa9sScGXLMsmLYHUbf9dn2StcixQ/55aO5q3h2/Z7AAB1ahRQo+p+SwsBKG+B3MZMrapAFalItiY88czvHHYoJrke0MJDTxYW8vYdzrEoUUnCXZq8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763046016; c=relaxed/simple; bh=pjtMzT/5Pe0GOqPc4q4yPcR9QsmDLhoSLM7YP8wBwxs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=V/j+zlcOS4D3onQsoXq4NrzJxGGAZCHxzGfUB5T70gZ2J2Mdr4LO4FlTDkcHtNNPJGkfZSu2rnqDU+WAbOK8PpX+vIOTVi45bTwC1hunsPJ4ZSvporfOqzFaVAJQk8YGr5LGbnEwX32tiWJZ9IA0xjLGWaH3eRwsiZQEHyi8hME= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7E79A3858D20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763046016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=15tuaqRKRFaWJ9P3dohDI4T50G9o/13i9qJMLa2aI8o=; b=b599YxQhpop2JzAOaXMIBouFHS8+cnmKElZHuMDFirvbjJVXvCoykutkp5hfL2FDCXQ1a7 AvzgmEU4WoUyP67JlbLsCLTvCZlH+Dl5+xpsZppQD5lULyhifpRB+VFZ9PGB1KPkMfFXFv 3dDTWZbyc37kVMOUUw9B9MrWDlBT+os= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-250-BnnWjfwnMKGFja8k83yYww-1; Thu, 13 Nov 2025 10:00:15 -0500 X-MC-Unique: BnnWjfwnMKGFja8k83yYww-1 X-Mimecast-MFC-AGG-ID: BnnWjfwnMKGFja8k83yYww_1763046014 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-88237204cc8so14431356d6.2 for ; Thu, 13 Nov 2025 07:00:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763046014; x=1763650814; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=15tuaqRKRFaWJ9P3dohDI4T50G9o/13i9qJMLa2aI8o=; b=TCkDrE7qf2ELk5cDxpDAQOQyW1t0oIvsQUlaYeX0n5nWdood8XLH5+aKxWT+HfvIcN iFSE/wyaA0+scs/EYcRitDxth9IswhP4TBakFkn7YKiSOXBpR6gZcSEYml6lz+y5z/XO Jt34Rzf72FiUzm8kvLebl755Sfn4XhIn9+7GgLmHTReqQXCISkhc3aETdw/nCXTfGLvF QrW+2cqx0n+587so7ygS562aBKGgMFHmrWcfd6r/4H/V+1CtBrNK5JTaBRLFKtrRgS97 +fJgrRHdMRaUq1x5+sv24PSjDP29CUctl74+FFGja+kkwah62ZsGdyW1ZN3tacm2tdWM 5/2A== X-Gm-Message-State: AOJu0YzKgB+uu0cNFEhRe+6+D9L0Sbm+mVUI0O8B2WeasDa4cZgpUVLz bafO6E01spvrjqcMpZakwJmjxe16C8qbtJqhWzVdA5121iLeUTETWk6kUcwwYlLW2xSu8TdHSyJ ThcAdmMZNQgk9KC9lw1a2NZTQmpf8OAHdDtEUt12HJbpHZGC2sa7miniO88lJRzwnhQ/FBFRmCm dMZiFUBmBraaDodxiQoP3ZcGr/uUnUfS7gBX/8jW7QWq4= X-Gm-Gg: ASbGncsG49Cd0Hu/kB+ACPjgTVzEF9rIbTz3l9bjtoX19pnIfdcrmfMSgvoGiPRjT7q 3sXq2Lw1Ehw+tTPklQY/rYfcqzfABdkdIMe5eEPkAQQ41P883id1JFHmD3pICiaoRlsrebaidbj sZ81Xn7zPg/KJe1f7PnGccGKrAyGLprg0FIBVMdGVt+WoaNuhto+0TWZIdrNHBU0X/RV6Kg2TSs m032C8OcUTm1rCpuC9+SXi450VOIjViw8vqqUhp+SGjuF59eNfVWqcpCb4Z4Mu2HW+7OqX1/3+j /M3awWaobtS2BFHUBHTJnNopzp7pCYYKEhMhh/9HyQaqfXVZs+KPTFb7mXUtkUFJp7VaboBkyt6 jMA== X-Received: by 2002:a05:6214:f03:b0:87c:2270:2b37 with SMTP id 6a1803df08f44-88271a3cdd3mr105986786d6.58.1763046013465; Thu, 13 Nov 2025 07:00:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IGLjdXfJM6pNR359r5fZFPiI9xo0qGgPETzV2eCpI3jhupHuy0w2ShAPaLpfoChQpQyDOPAqQ== X-Received: by 2002:a05:6214:f03:b0:87c:2270:2b37 with SMTP id 6a1803df08f44-88271a3cdd3mr105985906d6.58.1763046012744; Thu, 13 Nov 2025 07:00:12 -0800 (PST) Received: from athas.redhat.com ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8828652b392sm13059816d6.35.2025.11.13.07.00.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Nov 2025 07:00:11 -0800 (PST) From: Carlos O'Donell To: libc-alpha@sourceware.org, dj@redhat.com Cc: Carlos O'Donell Subject: [PATCH] x86: Increase allowable TSX abort rate to 6%. Date: Thu, 13 Nov 2025 09:59:58 -0500 Message-ID: <20251113150009.1139451-1-carlos@redhat.com> X-Mailer: git-send-email 2.51.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: n_gGQRM-WAZdiVcMNZtk20rhT9iYm3LZ7ajgjcLdJbg_1763046014 X-Mimecast-Originator: redhat.com Content-type: text/plain; charset=UTF-8 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org In pre-commit CI on an E5-2698 v4 we sometimes see ~5% aborts. Set the trip point to 6%. --- sysdeps/x86/tst-string-rtm.h | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/sysdeps/x86/tst-string-rtm.h b/sysdeps/x86/tst-string-rtm.h index 1bf863063f..699c52227b 100644 --- a/sysdeps/x86/tst-string-rtm.h +++ b/sysdeps/x86/tst-string-rtm.h @@ -36,6 +36,18 @@ do_test_1 (const char *name, unsigned int loop, int (*prepare) (void), unsigned int i; unsigned int naborts = 0; unsigned int failed = 0; + + /* Iterate LOOP number of times, calling the same function over + and over again in an attempt to detect the following failure + modes: + + 1. Aborting instruction on the hot path. + 2. Number of instructions executed exceeds maximum. + 3. Memory reads or writes exceed maximum. + + The function getting bigger may increase the abort rate due + to external events, despite not triggering #2 above, and may + need adjusting the abort rate failure test below. */ for (i = 0; i < loop; i++) { failed |= function (); @@ -56,10 +68,12 @@ do_test_1 (const char *name, unsigned int loop, int (*prepare) (void), if (naborts) { - /* NB: Low single digit (<= 5%) noise-level aborts are normal for - TSX. */ + /* Low single digit (<= 5%) noise-level aborts are normal for TSX + for reasons that are outside of the library's control. + In pre-commit CI on an E5-2698 v4 we sometimes see ~5% aborts. + Set the trip point to 6%. */ double rate = 100 * ((double) naborts) / ((double) loop); - if (rate > 5) + if (rate > 6) FAIL_EXIT1 ("TSX abort rate: %.2f%% (%d out of %d)", rate, naborts, loop); }