From patchwork Sat Aug 23 14:04:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 118797 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 68D593858410 for ; Sat, 23 Aug 2025 14:05:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 68D593858410 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=ORvzjGiI X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 9D4563858C50 for ; Sat, 23 Aug 2025 14:04:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9D4563858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9D4563858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::633 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755957896; cv=none; b=oj2VGlOTvVjgunO83iYf74BcAEtJO7m+c2QogHWMTwFtuIbcNtjmos2r15QYVzlQRpbFD1ATS3lEDIysFhDEB3pmrie1uRax1TbiQL4epOa8U81PS5bkd6cLG5jydRfiLzE+4XJvOxLtw27CdL24dQOw8Nr5ysDVNKeYGqenwcs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755957896; c=relaxed/simple; bh=fAnICXMaSC1eZ7s0SX4gKvjL6LfhaHm2oHmtWuNN12U=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=nyCr6RV4zDIiDHlchf++/Lh8JtOcK9Y1VPBSJRsEv3n1EOXvJiwWfchpZQhsXQUPCCYLEqvpD9AE9pGp04PW10XyNGKWyKpi8K4VzpcuOKkG/G18lSGvshvYnh+yb18SAECuNdpLmSXLQ3slQBrBZ4jTwt/PYdwAH4PEGwgfrA8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9D4563858C50 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-24616482efeso13663055ad.1 for ; Sat, 23 Aug 2025 07:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755957895; x=1756562695; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=CMctj+/1tmatHQDyCmIsU4oSCdTZfiMaLJBUyBmsXls=; b=ORvzjGiIlWRfTvyrmRP6odmQ0dLJlv5cCAPJdCLZbJ0AAU5I/uIHo06N2e2cjAn3GZ 1Sr82rt6NaM5k1Jevy3civhUb8hnGaEAeqHlpaMF+3WNlfz13oeNkyp25SLf1vseGXCV tK9D9zrs5bHOQe5z480bX6OCtiGE5l1L2OhZKlHZV+DZ1ZxyhCnQzQ8bf0z83mgb7iL9 cXJUHtTfasp0jO3ukkXm333FOGf296+f8FRy4Y+AM+ujaMv9JtJGttFCilSDNjFVtg7n K/VfsrWwG3S52wSXgOEKKQRehv/w+KcmU58XJx+M2YIa9oiO6fdd4UaP2QlLa7EpdQvQ i3LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755957895; x=1756562695; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CMctj+/1tmatHQDyCmIsU4oSCdTZfiMaLJBUyBmsXls=; b=Qnm1eKNpydQRDxaqIBabnEBFeIXzo9SqGt8aAjIKA/N2zJqggyiubF7CLZUbhBfSH8 JNGp2u27C93k375qAozuP/LK3BxMrRTsf+M6bQc+L5L66wKZYmSGv0DYHJZys50zAMzf yB9nsJxA4PSTnVE2R5DXtqR85MA9VUlO2RQQU83t9CAFgmOpSUE6wlOlIfuEfuzLYpFE jX2AnRa7TfwmTGqk6tLq+SmEV/NN0yx6spFluDULr1L2X/rOLpgGqdR4CTLsrKuKndB9 y0H1+LwB4sxN/nijJ7xgfpe73vN6A48J2/3CQ+VhU6L3WiC/3SJWGZx+EyZtun2ujRtj ddOQ== X-Gm-Message-State: AOJu0YxiojNAAYxajwfJzilHLMa/XjwGH0acP9cwPFAQNwZ5DNcpZG9H tG+Tk1iY+ldWbYYycZffJRpvDbMQyVTw/nC+o2AhPX4HupjgaXD3kk/oMkD9iA== X-Gm-Gg: ASbGncsoukgcowR8Qn1QxOGQEsNrrEla8Ud9kYI0HyCgmkRrKSEPE9LmWEoA03T98Vr y8FjetJciF5ioKJf1MCx5MVNPVzVrPSc1kTvXuaN+it+1QECyOZjLkUzyWFfbr0AxDn6amhXudA yumLdibVACMARNo4NQYfFDpwR6BWMUbVN9EloCcLsOzbgVlNCvHyrm6heMglmJ+hH5LWgj7AkA0 Hd7LyFn21kRr+LLGqKb0Qo4yL/5R3SvAfRfQODnr81b3cHPEXnseuAiG5TYltOHH03pDfOZsAF4 wNB2wu4XYFGqciBwCEfm/3K/8nC5N66g3nwz8EsgTFC0MKVmmcLNQVZia+i3i+YaCYIXS0ZmVcZ WibhGnfSi2DHUUHO1oSlsB7OFDSS9IjdI38q1f8E= X-Google-Smtp-Source: AGHT+IH6Vwv8qNlSbD4S9DY1CaFTmfWYz+Qu2rnwxwZ2sze+9aVwyArzRRQvGWkEXPQa7+8YSuHlbQ== X-Received: by 2002:a17:903:178b:b0:245:f806:466c with SMTP id d9443c01a7336-2462eeaf241mr86167845ad.25.1755957895116; Sat, 23 Aug 2025 07:04:55 -0700 (PDT) Received: from gnu-cfl-3.localdomain ([172.59.160.12]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-770401b1033sm2634895b3a.55.2025.08.23.07.04.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Aug 2025 07:04:54 -0700 (PDT) Received: from gnu-cfl-3.localdomain (localhost [127.0.0.1]) by gnu-cfl-3.localdomain (Postfix) with ESMTP id B0DAE7401D9 for ; Sat, 23 Aug 2025 07:04:53 -0700 (PDT) From: "H.J. Lu" To: libc-alpha@sourceware.org Subject: [PATCH] Don't pass -c to LIBC_TRY_TEST_CC_OPTION Date: Sat, 23 Aug 2025 07:04:48 -0700 Message-ID: <20250823140448.3746720-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3012.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org LIBC_TRY_TEST_CC_OPTION is defined with LIBC_TRY_CC_OPTION: dnl Test a compiler option or options with an empty input file. dnl LIBC_TRY_CC_OPTION([options], [action-if-true], [action-if-false]) AC_DEFUN([LIBC_TRY_CC_OPTION], [AS_IF([AC_TRY_COMMAND([${CC-cc} $1 -xc /dev/null -S -o /dev/null])], [$2], [$3])]) which passes -S to compiler. Unlike gcc, when -c is also passed to clang 20, we get configure:7838: clang -c -Werror -fsemantic-interposition -xc /dev/null -S -o /dev/null clang: error: argument unused during compilation: '-c' [-Werror,-Wunused-command-line-argument] Don't pass -c to LIBC_TRY_TEST_CC_OPTION since -c isn't needed. This fixes BZ #33318. Signed-off-by: H.J. Lu Reviewed-by: Sam James --- configure | 10 +++++----- configure.ac | 10 +++++----- sysdeps/x86/configure | 2 +- sysdeps/x86/configure.ac | 2 +- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/configure b/configure index 613ebe670a..222f04db22 100755 --- a/configure +++ b/configure @@ -7834,7 +7834,7 @@ if test ${libc_cv_test_cc_cflags_fsemantic_interposition+y} then : printf %s "(cached) " >&6 else case e in #( - e) if { ac_try='${CC-cc} -c -Werror -fsemantic-interposition -xc /dev/null -S -o /dev/null' + e) if { ac_try='${CC-cc} -Werror -fsemantic-interposition -xc /dev/null -S -o /dev/null' { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 (eval $ac_try) 2>&5 ac_status=$? @@ -8204,7 +8204,7 @@ if test ${libc_cv_test_cflags_wno_restrict+y} then : printf %s "(cached) " >&6 else case e in #( - e) if { ac_try='${CC-cc} -c -Werror -Wno-restrict -xc /dev/null -S -o /dev/null' + e) if { ac_try='${CC-cc} -Werror -Wno-restrict -xc /dev/null -S -o /dev/null' { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 (eval $ac_try) 2>&5 ac_status=$? @@ -8238,7 +8238,7 @@ if test ${libc_cv_test_cflags_wno_fortify_source+y} then : printf %s "(cached) " >&6 else case e in #( - e) if { ac_try='${CC-cc} -c -Werror -Wno-fortify-source -xc /dev/null -S -o /dev/null' + e) if { ac_try='${CC-cc} -Werror -Wno-fortify-source -xc /dev/null -S -o /dev/null' { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 (eval $ac_try) 2>&5 ac_status=$? @@ -8272,7 +8272,7 @@ if test ${libc_cv_test_cflags_finput_charset_ascii+y} then : printf %s "(cached) " >&6 else case e in #( - e) if { ac_try='${CC-cc} -c -Werror -finput-charset=ascii -xc /dev/null -S -o /dev/null' + e) if { ac_try='${CC-cc} -Werror -finput-charset=ascii -xc /dev/null -S -o /dev/null' { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 (eval $ac_try) 2>&5 ac_status=$? @@ -8306,7 +8306,7 @@ if test ${libc_cv_test_cxxflags_finput_charset_ascii+y} then : printf %s "(cached) " >&6 else case e in #( - e) if { ac_try='${CXX-c++} -c -Werror -finput-charset=ascii -xc++ /dev/null -S -o /dev/null' + e) if { ac_try='${CXX-c++} -Werror -finput-charset=ascii -xc++ /dev/null -S -o /dev/null' { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 (eval $ac_try) 2>&5 ac_status=$? diff --git a/configure.ac b/configure.ac index 6aefff94a2..af57b0cbae 100644 --- a/configure.ac +++ b/configure.ac @@ -1543,7 +1543,7 @@ AC_SUBST(libc_cv_test_cc_signaling_nans) dnl Check if TEST_CC supports -fsemantic-interposition. LIBC_TRY_TEST_CC_OPTION([-fsemantic-interposition], - [-c -Werror -fsemantic-interposition], + [-Werror -fsemantic-interposition], libc_cv_test_cc_cflags_fsemantic_interposition, [libc_cv_test_cc_cflags_fsemantic_interposition=yes], [libc_cv_test_cc_cflags_fsemantic_interposition=no] @@ -1649,7 +1649,7 @@ LIBC_CONFIG_VAR([have-test-cc-trampoline], dnl Check if TEST_CC supports -Wno-restrict. LIBC_TRY_TEST_CC_OPTION([-Wno-restrict], - [-c -Werror -Wno-restrict], + [-Werror -Wno-restrict], libc_cv_test_cflags_wno_restrict, [libc_cv_test_cflags_wno_restrict=-Wno-restrict], [libc_cv_test_cflags_wno_restrict=] @@ -1659,7 +1659,7 @@ LIBC_CONFIG_VAR([test-config-cflags-wno-restrict], dnl Check if TEST_CC supports -Wno-fortify-source. LIBC_TRY_TEST_CC_OPTION([-Wno-fortify-source], - [-c -Werror -Wno-fortify-source], + [-Werror -Wno-fortify-source], libc_cv_test_cflags_wno_fortify_source, [libc_cv_test_cflags_wno_fortify_source=-Wno-fortify-source], [libc_cv_test_cflags_wno_fortify_source=] @@ -1669,7 +1669,7 @@ LIBC_CONFIG_VAR([test-config-cflags-wno-fortify-source], dnl Check if TEST_CC supports -finput-charset=ascii. LIBC_TRY_TEST_CC_OPTION([-finput-charset=ascii], - [-c -Werror -finput-charset=ascii], + [-Werror -finput-charset=ascii], libc_cv_test_cflags_finput_charset_ascii, [libc_cv_test_cflags_finput_charset_ascii="-finput-charset=ascii"], [libc_cv_test_cflags_finput_charset_ascii=] @@ -1679,7 +1679,7 @@ LIBC_CONFIG_VAR(test-config-cflags-finput-charset-ascii, dnl Check if TEST_CXX supports -finput-charset=ascii. LIBC_TRY_TEST_CXX_OPTION([$CXX -finput-charset=ascii], - [-c -Werror -finput-charset=ascii], + [-Werror -finput-charset=ascii], libc_cv_test_cxxflags_finput_charset_ascii, [libc_cv_test_cxxflags_finput_charset_ascii="-finput-charset=ascii"], [libc_cv_test_cxxflags_finput_charset_ascii=] diff --git a/sysdeps/x86/configure b/sysdeps/x86/configure index f495f69894..b8583e266b 100644 --- a/sysdeps/x86/configure +++ b/sysdeps/x86/configure @@ -189,7 +189,7 @@ if test ${libc_cv_have_test_cc_cflags_mfpmath_387+y} then : printf %s "(cached) " >&6 else case e in #( - e) if { ac_try='${CC-cc} -c -Werror -mfpmath=387 -xc /dev/null -S -o /dev/null' + e) if { ac_try='${CC-cc} -Werror -mfpmath=387 -xc /dev/null -S -o /dev/null' { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 (eval $ac_try) 2>&5 ac_status=$? diff --git a/sysdeps/x86/configure.ac b/sysdeps/x86/configure.ac index 77ba6721ec..07f62d0616 100644 --- a/sysdeps/x86/configure.ac +++ b/sysdeps/x86/configure.ac @@ -124,7 +124,7 @@ LIBC_CONFIG_VAR([enable-x86-isa-level], [$libc_cv_include_x86_isa_level]) dnl Check if TEST_CC supports -mfpmath=387 LIBC_TRY_TEST_CC_OPTION([if -mfpmath=387 works], - [-c -Werror -mfpmath=387], + [-Werror -mfpmath=387], libc_cv_have_test_cc_cflags_mfpmath_387, [libc_cv_have_test_cc_cflags_mfpmath_387=yes], [libc_cv_have_test_cc_cflags_mfpmath_387=no]