From patchwork Sat Jul 19 14:43:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 116610 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9F07F3858420 for ; Sat, 19 Jul 2025 14:45:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9F07F3858420 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=R0OfkM5u X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id 672A13858C2D for ; Sat, 19 Jul 2025 14:43:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 672A13858C2D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 672A13858C2D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::435 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752936217; cv=none; b=ocRzKM8d5/XW+OrGf9zDC0Um4Z9sGfrCxsVssDxPkNXiF0bXimLUodkrPjjCP1rl+Z1Ht3ltwNusIxYLS1qT27mSEZraZcvjZ3Zes6K/vsDq8uqQcpJoZayu4ERNVfxT82KVtbeOK2gBJruPybBwGQZYbOXKNR5BsoeNxk5MihM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752936217; c=relaxed/simple; bh=QbQVfH+YmhtsCniX8wvZi02JBXq+mgZK5JSZWFN6xdM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=FPThPyppYkH46aSBaPua+JPCly8kvAoV2ojc9uXuM+S+17JhyX2xxMHgzL10DE5xo+kIS7BV7j2psHLr6ySKZ0CPPuGpT68eCWwlQ5JgeoOQv2fMJ96BuacRom6CfEOM15zEPZvuC3GJ9xXeO1ba3A74imuUyvWhbAEKSPuP5wU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 672A13858C2D Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-7490702fc7cso1911123b3a.1 for ; Sat, 19 Jul 2025 07:43:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752936216; x=1753541016; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oGZUCENViCaFaQ9J/oFfjW+No1U2pihoV7DRWIkzIIE=; b=R0OfkM5uX4w2VIWsK7D/+tLzaZJkbSdj/sBKaAuzkRfaDJieYh7HpxuyvEg+LwQfb5 fd7ZZ6l6o4l2n+UerIWu1hpw8NG40y/5njjPUOsGnY8gfxY7yokoOKethXQdXKxtSXAB sKrEJy+W50PaONZZ70UzRKDMQNmx6dojOkbde5aWRj1mFL1nacHRyP1WzVKd2FL8bctd 1MLfXZDjplhcOfzkkI42r4rmk9NWfn8x5uX9CoTlWiwjZ/Z6gkGx0kkAzSpS3i8YKU4U b85C59X7A9qjDRrUfAU9EQIwlo+RARoQBMMSDWq5jlL2zplLD9Y8nYyiKGsHiEEBgaHq VeuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752936216; x=1753541016; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oGZUCENViCaFaQ9J/oFfjW+No1U2pihoV7DRWIkzIIE=; b=WOVEdeOyEQmiE7QutC1kqorK1j4aUN2T/UpBoE3h+IkTrhXGVTWhZtFOg1Ha517xMj IG8Gl2H01UGMSneqTb3wC8m5QOprWpJiA75yYzQDRDMW8zQtpXuPevD09/TQDrXpeikg OYYC4ODUizi6YD3tBQWuCBUtv+sIs4vl1tD2cbBUNtdFDSUJzuFFT/3NtpxS3QWsND+G ZAMlQoOpViE+DaEqEsxG6Fjm1tq3WYNV+4gzZGzgfBkkkA4nTLr//T1ZLVEUGj12s1Vd PdG+BDYrUM02fTTwMWc+E7hKLmxfg9Pu19VqGMy08aJtHVLc7Pk4ekKW/6U1Kmhp87rH R4cA== X-Gm-Message-State: AOJu0YyWvWiujudTM6dk5szTnlaSAh1Y7q7FgzY56gFXNUmiAtU0sAbK Ydl6F4Q7vbt0GEKD7HUv879V23jnz2Fr75bq8chx8wulgTHTouAQnAetH7wSxw== X-Gm-Gg: ASbGnculD49t5IYMXouVXBe4XxOfymDryt0RSJyCKSzeKZTdDKqhlBY814hLH9+BhtA am60jHjMdQrN3pF+CCeHgGXuhyY38Ais7+oNRDBs6zg4pRUNrCt3A3ZbTXCsoW5k1OCV0MlmNGF UKKaMvZZGhr6mtUwVXxDO1ur4DwbdU8CUAsaxeOjANfYrUi+0d4gwB6ObQRzWC59ivsVkhvR33Q kcqskX4e+/5b285Vw0gAJLu5s9Ckb2KO2/vwcW675C9N04Z2Cw3GnrrrdStvFnTM2RfRgLLk8Cy Pn6hmKJh/lmWGRCt5bFpUDCBrDAltCtKi6f0YReJIJgz2FoZdK6oeT6GgflpMCuq1dhH+z3DAei q8GcqtynB4qdHcQqy/m2fUkD093fA148gwc3r99wCaRQabeeJWA== X-Google-Smtp-Source: AGHT+IEkZV7qLEfbG6W1Tivf0TIDA/NchFmSTEShvzb0l47v+HiyfnoxruP5vjUILiHPJpANNQwoVw== X-Received: by 2002:a05:6a20:a110:b0:239:d43:481c with SMTP id adf61e73a8af0-2390d434ca9mr17888034637.37.1752936216357; Sat, 19 Jul 2025 07:43:36 -0700 (PDT) Received: from gnu-cfl-3.localdomain ([172.59.161.186]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-759c84e215esm2918896b3a.9.2025.07.19.07.43.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Jul 2025 07:43:35 -0700 (PDT) Received: from gnu-cfl-3.localdomain (localhost [127.0.0.1]) by gnu-cfl-3.localdomain (Postfix) with ESMTP id 2BF38740286; Sat, 19 Jul 2025 07:43:34 -0700 (PDT) From: "H.J. Lu" To: libc-alpha@sourceware.org Cc: dilfridge@gentoo.org, fweimer@redhat.com Subject: [PATCH v2 1/4] Delete temporary files in support_subprocess Date: Sat, 19 Jul 2025 07:43:26 -0700 Message-ID: <20250719144329.453163-2-hjl.tools@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250719144329.453163-1-hjl.tools@gmail.com> References: <20250719144329.453163-1-hjl.tools@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-3014.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org Call support_delete_temp_files to delete temporary files before exit in support_subprocess. This partially fixes BZ #33182. Signed-off-by: H.J. Lu --- support/support_subprocess.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/support/support_subprocess.c b/support/support_subprocess.c index be00dde3a7..8bf9a33ea2 100644 --- a/support/support_subprocess.c +++ b/support/support_subprocess.c @@ -25,6 +25,7 @@ #include #include #include +#include static struct support_subprocess support_subprocess_init (void) @@ -60,6 +61,8 @@ support_subprocess (void (*callback) (void *), void *closure) xclose (result.stdout_pipe[1]); xclose (result.stderr_pipe[1]); callback (closure); + /* Make sure that temporary files are deleted. */ + support_delete_temp_files (); _exit (0); } xclose (result.stdout_pipe[1]); From patchwork Sat Jul 19 14:43:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 116612 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 278A23858C2C for ; Sat, 19 Jul 2025 14:48:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 278A23858C2C Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=kea3Pucg X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id C0262385840E for ; Sat, 19 Jul 2025 14:43:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C0262385840E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C0262385840E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::633 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752936217; cv=none; b=CLgOTHEoCEKsQTaeqjZAZJnDhwDvn+ZZNptx4Rw/y/xin1QeKABogPUUhk+/CNTFUAiHPwG2LguGPAgOPka/3ODHN017Nb45Q4uwvZBm6LVd8jUqp1QSGhFUWWpqmBH9ZUgMwanPyOpdOSx5RFB/LoHeq5UzLYfqi2O364IPnMo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752936217; c=relaxed/simple; bh=C9eTjmMSPWwtLYHneA/4sl/bjgkazQbodeVv6U9EPm8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=k7ktZiY8a/0DrmgvD2rwHUWLOst5ejfWXHvk077hX2f5oCkrzXuQtIQaSPVd+ulK11u1U6VbpYS1GJ8GKLDJX/iRNTRla9DDkBdNqtvwvhOVQh7Q3YVrNMKKdD5OPb6nmerk/glHGqRj/D2Pn0mD71kp7+ZkOlI+mmcB2e4m6bE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C0262385840E Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-23aeac7d77aso25132805ad.3 for ; Sat, 19 Jul 2025 07:43:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752936217; x=1753541017; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7hoQtpGZ+aWvvEVyZHN9b7H/k2JGKJPHBrsWlfBCBh8=; b=kea3PucgNtM5hDJjJV7ASH0DK1QazrGLIBKB1ilMrPPDGMXO9lKzX/fBg0q9dAkEDo l0ESD9iefjnM4M/CvmcDEf+6h+YMWVoII54eQT044FTGXTHcWEVlIiYxLYdwu1+GTY3e TIYtJ/NnMIyqr/IGaGyCGm9NJGeq7xtT1P/o3U/TtEKBwtI0WpjhilKvuRw2pdeWgRk0 0Emd6D+00ck36BWfIHhS/FOkGcKZVnjSQiIfDUdAdHx+nyCRzdoa1K2JnqYvsnGXBX3f NfFzGffO6pk/D20z95p2t1lMe1wcDAl/7s9stlrtFqFe2ZVDMft6+5cnLVfWZx1qM5G5 +UWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752936217; x=1753541017; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7hoQtpGZ+aWvvEVyZHN9b7H/k2JGKJPHBrsWlfBCBh8=; b=pXmDZ0neG+Bz6xTWyNvkGKOx9NheFP5g4PzuXDxfE74cDvyWIuCRFSDI1tNzfDaXXH pT6xKDWxw6qhojuhrzvIFEekn4nPSMJbHObdUFNR65Ec2Sn8DG7gc1MDSAlAk6xM3f/G NqhqQdOx+2QrA3JyCqTx1aYWjjVOI2iDk3R9DI4FsVm/35yTu1gLkP8QR8GnPFOqQPI9 rIpZ6fejIWk879Eym8MjA5LLn31RLpNrsLOM2rtkHZgmZF7+Dxdqk+3xkOn3n+ok3ERL P6/sW9tj/9ZolBHcwgH1JrtgTRYjckCsZQKl76mhtMQyD9xme7QqauYvBHUG8vMBRg8m BmSg== X-Gm-Message-State: AOJu0Yyw3sWp2Md59LrnkGRnHykaZcwri8M4GPgWsk0/IqTBJsBfxwzR vVHu29qNRxTW0s/e4vCoVgRb7ouhzhJE88kgtYbpeBsool98s+WvnLGPq0RHDA== X-Gm-Gg: ASbGnctUo8mVWGMyFKjevpX3N+Rbn+E3j0CPCjr8JPou2b+WZFvCwHlz6wevywZqfDq BxidhbwF1y1YgCgZUX7vuELMhHluMzIipUek8KTH1mm+oc+0rKfCH6kRrpf6R5tv58lGVYpyv1d TTYYS3wE+qKUWmXySEyE7uHYblCHJfg7rp4F0AMsEaHydQjFWom7kvLzeiEYVoebL0KaT56GtIz XLYTJglbVuP4TZ9swFPAH7eXBIqQqygcp9iy9eNvFq8Fs70G774zk+5K5xhq+1rVtzoIJGb2Ezn hybCt8UJdgoE++muRndacwLogwtHF9OvhYRHcEYZJPYr7tkHAF3476L3BXW/qjFSiP8Sm3QqMI7 Y7XmsmDOdNrfbOiu40E+NzOVb3+I48LQVJCToVwhs/NalUwEUjw== X-Google-Smtp-Source: AGHT+IHEgvno91qitxyYpaweXoozy45mY8ipMJiABFXz1VrxPBWFw8pAWG4viy1BKoemSQ1Kh1tVag== X-Received: by 2002:a17:902:e881:b0:223:65dc:4580 with SMTP id d9443c01a7336-23e25000f07mr214396215ad.52.1752936216625; Sat, 19 Jul 2025 07:43:36 -0700 (PDT) Received: from gnu-cfl-3.localdomain ([172.59.161.186]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31cc0bd12b5sm3390388a91.12.2025.07.19.07.43.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Jul 2025 07:43:35 -0700 (PDT) Received: from gnu-cfl-3.localdomain (localhost [127.0.0.1]) by gnu-cfl-3.localdomain (Postfix) with ESMTP id 371967403D6; Sat, 19 Jul 2025 07:43:34 -0700 (PDT) From: "H.J. Lu" To: libc-alpha@sourceware.org Cc: dilfridge@gentoo.org, fweimer@redhat.com Subject: [PATCH v2 2/4] tst-fopen-threaded.c: Delete temporary file Date: Sat, 19 Jul 2025 07:43:27 -0700 Message-ID: <20250719144329.453163-3-hjl.tools@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250719144329.453163-1-hjl.tools@gmail.com> References: <20250719144329.453163-1-hjl.tools@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-3014.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org Update tst-fopen-threaded.c to call support_create_temp_directory to create a temporary directory and open "file" in the temporary directory, instead of using /tmp/openclosetest and leaving it behind. This partially fixes BZ #33182. Signed-off-by: H.J. Lu --- sysdeps/pthread/tst-fopen-threaded.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/sysdeps/pthread/tst-fopen-threaded.c b/sysdeps/pthread/tst-fopen-threaded.c index ade58ad19e..c17f1eaa13 100644 --- a/sysdeps/pthread/tst-fopen-threaded.c +++ b/sysdeps/pthread/tst-fopen-threaded.c @@ -34,11 +34,13 @@ #include #include #include +#include #include #include #include #include +#include #define NUM_THREADS 100 #define ITERS 10 @@ -111,7 +113,8 @@ threadOpenCloseRoutine (void *argv) /* Wait for all threads to be ready to call fopen and fclose. */ xpthread_barrier_wait (&barrier); - FILE *fd = xfopen ("/tmp/openclosetest", "w+"); + char *file = (char *) argv; + FILE *fd = xfopen (file, "w+"); xfclose (fd); return NULL; } @@ -235,6 +238,10 @@ do_test (void) xfclose (fd_file); } + char *tempdir = support_create_temp_directory ("openclosetest-"); + char *file = xasprintf ("%s/file", tempdir); + add_temp_file (file); + /* Test 3: Concurrent open/close. */ for (int reps = 1; reps <= ITERS; reps++) { @@ -243,7 +250,7 @@ do_test (void) { threads[i] = xpthread_create (support_small_stack_thread_attribute (), - threadOpenCloseRoutine, NULL); + threadOpenCloseRoutine, file); } for (int i = 0; i < NUM_THREADS; i++) { @@ -252,6 +259,9 @@ do_test (void) xpthread_barrier_destroy (&barrier); } + free (file); + free (tempdir); + return 0; } From patchwork Sat Jul 19 14:43:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 116611 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2709C3858C2C for ; Sat, 19 Jul 2025 14:45:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2709C3858C2C Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=BMV2pJ3I X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id CD2E43858C66 for ; Sat, 19 Jul 2025 14:43:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CD2E43858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CD2E43858C66 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752936217; cv=none; b=UAKfolFZJjEqagPs5In1KRNzNBeIO5BKuA2A80EODnNoO1i7j8QHSbT2aqfsXI9gBOlGKwfBZKgVIm+rT5bqOT38LHkzO79vbVxLvHpyqr11sVrJSkczGGuq8kzrR7//mpzppXw2AiR7ww/9sWR1UCNntNiBJQFI7kkbf85WEmI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752936217; c=relaxed/simple; bh=WtNg/wCREhDneOmzp1OxRMbRcMOaft061WtTyq5krcI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=b0VyUv43JaGe2C2flcC3eKFw8WPbpqJHW3nj5e1mfjlGIOAbd6vr2q6Kop9Ck1R37x2c/N1J/eE9O2U6RkkidN8f4hp1LNvpTbwKKXfGXhIBx6FQiQ0/Dvo7mv1fTbMOOZE3ii8RUP3BIfsD/gXWeGlJITCCS0z3hfVf/re0a0s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CD2E43858C66 Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-b2c4331c50eso2406319a12.3 for ; Sat, 19 Jul 2025 07:43:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752936216; x=1753541016; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WUpyDaynNCwsGAl1ztIc/GOGlPr7AM1uDc+5VHUTljU=; b=BMV2pJ3Ifr0M5jls2WXxmzwdAVob7X9eLIbYwHD+isE4tgvJaXc++1rStIwHMUR+ck NbEW6T/xxd1NEv0eI2B7a/oUvsm8/9SoYZHFPYalOGypf3CP7IH2FmCO0ENLuVZS15wt 4y6+TGIuZWmrOxqGCXB7DdzGTXeRwmFVGICtwrMz6oBFCTel764CYwi2m/P4UuyukMzt 5SXMNAs50yF9UWSOpjOfUrApgLLcImQlgf2XdCUTzj5YrF2YnpM+gzQ8/ELJqGc/Abh1 JyhXeHCSzg7Z5/cfiZXiUjMFnlnhpWStQtdVZKwTAP2PJS201fgNikk7K9QeZT0SNN9n 5ZOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752936216; x=1753541016; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WUpyDaynNCwsGAl1ztIc/GOGlPr7AM1uDc+5VHUTljU=; b=Xb2EfOfFRAyeFwtdSp5y9HAfDzHo7p7sF4dtvS+XDq3tKzmToNSfdNu0ia1pH//6Ch 2rAsZpemhLZD6t+7j1bKnyJhzLSN2rR/fdr1l9Q+sabaNUtiNlBoT3XLudEMka2kjXMr GpH5bswfO+uS0YAmVdn9kxJWkNcFz/5lVx6qXSl4N78pq/u6JjNIzr3fFpw0e5tL2f5u L0liKzHjtIP6NuoCO+1M2+wYsaKanJfcgJCZMT97vvTJl01ZkGC67jy0qQksTDOLC83E BhdmBLt//KpbiXZP6qBXwo5NzCpCnVNlduBbpmpUw0a1RztN1t3wd4g0Rtk5iULIC/Uw oLvQ== X-Gm-Message-State: AOJu0YwhxETbb0SMgiu3vu/MkaqQqOF0dLNJ9umA/uZWCcjBEuVyPZRL 0qC+Hp/obwebpEMOFoDvYuQWwXdjNVjcgaIeKV5NJmN8tS/6BB16jaNr X-Gm-Gg: ASbGncsKac/fpCSq5vzvUT31g2I8rJHmxiyPgzYjo4VQudhJFXmMp3aG6VAcipFJ72/ PckZe8GC7xpaZ8MOwgIzSC3oHll1M292NC+w+/cw/mn/7gfqvnQ8aLXH/dT7lfcVLChLtk9VBgM a9cSGYWWNVtW5iGumx+YCwda1hfRL45S6lRHdsCQFf6RsGlF10N2Wc3XSSMR4pmGmFBddEwhLRX 6o2rUz++2qweBbXpDvT+UHOU3+3DAO0j5YRs60DqaHtyHIRspkjcwd/iyMnAh8Bhy5rxQRwPKCN 0Mm6pMQi6/eLX0LLLEfMKsSubJeYq4KvEcNT/hsx0RZv8mPePaRg4HIErIT26w52oS+dr50bQLq +FXYp3z2FFc283lmxB9BzQhm+leyID4HyIJbykMI= X-Google-Smtp-Source: AGHT+IEBQDLJ5cFTdQXhEjIkx3qgekUXiQFemi0WhA/UALQaGACe451MgNpsUfUXJEd4KDBH9uN8uw== X-Received: by 2002:a17:90b:28cc:b0:311:b0d3:865 with SMTP id 98e67ed59e1d1-31c9e7931a3mr17874227a91.32.1752936215665; Sat, 19 Jul 2025 07:43:35 -0700 (PDT) Received: from gnu-cfl-3.localdomain ([172.59.161.186]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c9f2b4a40sm7144222a91.45.2025.07.19.07.43.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Jul 2025 07:43:35 -0700 (PDT) Received: from gnu-cfl-3.localdomain (localhost [127.0.0.1]) by gnu-cfl-3.localdomain (Postfix) with ESMTP id 424927403D8; Sat, 19 Jul 2025 07:43:34 -0700 (PDT) From: "H.J. Lu" To: libc-alpha@sourceware.org Cc: dilfridge@gentoo.org, fweimer@redhat.com Subject: [PATCH v2 3/4] tst-freopen4-main.c: Call support_capture_subprocess with chroot Date: Sat, 19 Jul 2025 07:43:28 -0700 Message-ID: <20250719144329.453163-4-hjl.tools@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250719144329.453163-1-hjl.tools@gmail.com> References: <20250719144329.453163-1-hjl.tools@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-3014.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org Update tst-freopen4-main.c to call support_capture_subprocess with chroot, which makes temporary files inaccessible, so that temporary files can be deleted. This partially fixes BZ #33182. Signed-off-by: H.J. Lu --- stdio-common/tst-freopen4-main.c | 44 ++++++++++++++++++++++---------- 1 file changed, 30 insertions(+), 14 deletions(-) diff --git a/stdio-common/tst-freopen4-main.c b/stdio-common/tst-freopen4-main.c index 3336f5327d..436da4d203 100644 --- a/stdio-common/tst-freopen4-main.c +++ b/stdio-common/tst-freopen4-main.c @@ -28,25 +28,15 @@ #include #include #include +#include -int -do_test (void) +static void +do_test_chroot (void *data) { - mtrace (); - char *temp_dir; + char *temp_dir = (char *) data; FILE *fp; int ret; - /* These chroot tests verify that either reopening a renamed or - deleted file works even in the absence of /proc, or that it fails - (without memory leaks); thus, for example, such reopening does - not crash in the absence of /proc. */ - - support_become_root (); - if (!support_can_chroot ()) - return EXIT_UNSUPPORTED; - - temp_dir = support_create_temp_directory ("tst-freopen4"); xchroot (temp_dir); /* Test freopen with NULL, renamed file. This verifies that @@ -96,6 +86,32 @@ do_test (void) puts ("freopen of deleted file failed (OK)"); free (temp_dir); +} + +int +do_test (void) +{ + mtrace (); + char *temp_dir; + + /* These chroot tests verify that either reopening a renamed or + deleted file works even in the absence of /proc, or that it fails + (without memory leaks); thus, for example, such reopening does + not crash in the absence of /proc. */ + + support_become_root (); + if (!support_can_chroot ()) + return EXIT_UNSUPPORTED; + + temp_dir = support_create_temp_directory ("tst-freopen4"); + + struct support_capture_subprocess result; + result = support_capture_subprocess (do_test_chroot, temp_dir); + support_capture_subprocess_check (&result, "freopen4", 0, + sc_allow_stdout); + fputs (result.out.buffer, stdout); + support_capture_subprocess_free (&result); + return 0; } From patchwork Sat Jul 19 14:43:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 116613 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B5750385800F for ; Sat, 19 Jul 2025 14:49:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B5750385800F Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=NdJktmSO X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by sourceware.org (Postfix) with ESMTPS id 25F7A3858C2C for ; Sat, 19 Jul 2025 14:43:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 25F7A3858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 25F7A3858C2C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752936217; cv=none; b=MVnDzebMiwNJkUGCMNQTOXNMTc2IVKiLIxYD27sg2b3zp8FKZE4XuRyO3Pu1cn9BRjXxddyZRUR6d9WXHZsfpQwiL5PUqATejoOzQS06DKnwsZzeYSK6GwYVdwS0+rZtVw6DbNVBDv+LgG8SYIMY6EAx5iwP4VeVW8occBSlLo8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752936217; c=relaxed/simple; bh=wuiYzvaB8IYRLD7aVWS7qoFkR/dMYcubROCMJ6nspJk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=OqZIRRK4NtLs/ubc3nqJ0xih+gPoPk0RKZNk+Q/NJXCY9hSUbDNfUqPPk3eq7FbCjaVpSy7GVybKJAwjzw4MlsyaAaNdESqZdNAvJc2qCN1Bwpc0jNUimF+Y2uIoDXODnQDjwaNiBgpDBDDTHPrcnCNx+Jdz75S2u64ujw1laVM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 25F7A3858C2C Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-311da0bef4aso3050417a91.3 for ; Sat, 19 Jul 2025 07:43:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752936216; x=1753541016; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m7Si1iEvqthpKYihzvwxoCo070AmCYCfL1/X3A2vjvY=; b=NdJktmSO8cKZleLnLxmQGG931GsZqa/oX+wy4moNt72xh8xaOPpo/WRVl0j22luxgP 8JxR6ctqXwDR2jUD/LRUsArmSlsCe4kpPpQLxvpyaFdndGvJEoojcxdcG1Hl1zXwGvsZ Zi7sa2HEbgNULNBj8h43CygimMiYeOed7whouZn2zSpDmAhWTDGTbmS6+NI4ESd+L6zr 9qPuj0VOwxZikbeX8zR06/ZKUu9hj8Wi7nbtpKkWAEibwZdCpptQae8M0iY8kv/GIke5 Wdj7TPzTMMlhs0NsHLnpOjEO/jQh64AbWL8+0OZdymXLtZv0m9dB0tcfU88g4Dw3fRlB RUKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752936216; x=1753541016; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m7Si1iEvqthpKYihzvwxoCo070AmCYCfL1/X3A2vjvY=; b=UaM+OulLgH3q7EZeyhButHP13hxU6jbQ+YedKizlyR8qAXipegku389GXALFN6kcLF 3FSwE7g7NCyCi5zvf5v5hsu5BeHSyWpqtUlAlF4yBSddowYY2lKP7zwF3i/RvkrnsU3o 9GexIewtx8tB6QKetbh+l+8+bd3aX8FxR5SyFqmftpqI8WXhW2Etn9X77fryy56ZEuPl 2gxZC3L2QOT2FsiVpaDJhe1sH/OH1/kMy2rYVciysV3aFlhHVC5OCddQvCOXSJjap0UC nbcfZIPq40m7BHbdyf3RKlfHHQo/9PgLl2RN6GaquxxshmfQ+o5eN7ox+lEBHwLr+fJE cYoQ== X-Gm-Message-State: AOJu0YyOGWVsSJZknvbSDWcgSGgJ5F/1ur75cgbfBtJq2lZ4jy/YhnFt a/2UIAV4/Efhdc2E5qth5SmKKaimo0mF8vkBCnny1w3ruhr6e4T1ZQUA X-Gm-Gg: ASbGncvv8DUxzPPIL+/Q+ANWlM1HHM6ClUtTym3Ji8UbiSl1VBCtJJ1SlZ9a8NGskLE lRmYdV2TXBnuAqRsIuqNv0Z6Fm9R7bP1ch0wnbqqRAUkKdF6erErxIRAgspyN0Pzt7JliIix0wb tBBBOzwo2q4MC0E/SiM389srC3++zfJZy/IcJioaIKcONiMSnlWytXAfyh4ILgqhguZujewDwK7 ny2l4315T3laHrXvMnQ+czCIPwAlyv+SMzdjJ9QUm+a7TMshGKQefFWpHsgbSPq4KIqcmSVlPNU zjVyuu5+cZcxehwTdU9SSy+J+/O+zHQRH25hoU/oCrP3ZraZEcZ18xSTYXLDUOtWbuNMyKHtOFv DAZhTD3avY359IZB77d+XXef231ldjL+X1IEQoP0= X-Google-Smtp-Source: AGHT+IExzKzHKFHRQU9/rcvzrWk5L1LhDY09YmZSF1QQ7XLnHXOZpvNrasP4e5Ys9lG3gsAR5A4Ung== X-Received: by 2002:a17:90b:1b06:b0:311:f2f6:44ff with SMTP id 98e67ed59e1d1-31c9f42400cmr23555624a91.17.1752936216030; Sat, 19 Jul 2025 07:43:36 -0700 (PDT) Received: from gnu-cfl-3.localdomain ([172.59.161.186]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31cc3e5b439sm3111095a91.14.2025.07.19.07.43.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Jul 2025 07:43:35 -0700 (PDT) Received: from gnu-cfl-3.localdomain (localhost [127.0.0.1]) by gnu-cfl-3.localdomain (Postfix) with ESMTP id 4D6C57403DB; Sat, 19 Jul 2025 07:43:34 -0700 (PDT) From: "H.J. Lu" To: libc-alpha@sourceware.org Cc: dilfridge@gentoo.org, fweimer@redhat.com Subject: [PATCH v2 4/4] tst-env-setuid: Delete LD_DEBUG_OUTPUT output Date: Sat, 19 Jul 2025 07:43:29 -0700 Message-ID: <20250719144329.453163-5-hjl.tools@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250719144329.453163-1-hjl.tools@gmail.com> References: <20250719144329.453163-1-hjl.tools@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-3014.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org Update tst-env-setuid.c to delete LD_DEBUG_OUTPUT output, instead of leaving it behind. This partially fixes BZ #33182. Signed-off-by: H.J. Lu --- elf/tst-env-setuid.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/elf/tst-env-setuid.c b/elf/tst-env-setuid.c index 7209acd616..ff3eda7f91 100644 --- a/elf/tst-env-setuid.c +++ b/elf/tst-env-setuid.c @@ -40,6 +40,8 @@ static char SETGID_CHILD[] = "setgid-child"; # define PROFILE_LIB "tst-sonamemove-runmod2.so" #endif +#define LD_DEBUG_OUTPUT "/tmp/some-file" + struct envvar_t { const char *env; @@ -61,7 +63,7 @@ static const struct envvar_t filtered_envvars[] = { "MALLOC_TRIM_THRESHOLD_", FILTERED_VALUE }, { "RES_OPTIONS", FILTERED_VALUE }, { "LD_DEBUG", "all" }, - { "LD_DEBUG_OUTPUT", "/tmp/some-file" }, + { "LD_DEBUG_OUTPUT", LD_DEBUG_OUTPUT }, { "LD_WARN", FILTERED_VALUE }, { "LD_VERBOSE", FILTERED_VALUE }, { "LD_BIND_NOW", "0" }, @@ -74,6 +76,14 @@ static const struct envvar_t unfiltered_envvars[] = { "LD_ASSUME_KERNEL", UNFILTERED_VALUE }, }; +static void +unlink_ld_debug_output (pid_t pid) +{ + char *output = xasprintf ("%s.%d", LD_DEBUG_OUTPUT, pid); + unlink (output); + free (output); +} + static int test_child (void) { @@ -138,13 +148,21 @@ do_test (int argc, char **argv) /* Setgid child process. */ if (argc == 2 && strcmp (argv[1], SETGID_CHILD) == 0) { + pid_t ppid = getppid (); + if (getgid () == getegid ()) - /* This can happen if the file system is mounted nosuid. */ - FAIL_UNSUPPORTED ("SGID failed: GID and EGID match (%jd)\n", - (intmax_t) getgid ()); + { + /* This can happen if the file system is mounted nosuid. */ + unlink_ld_debug_output (ppid); + + FAIL_UNSUPPORTED ("SGID failed: GID and EGID match (%jd)\n", + (intmax_t) getgid ()); + } int ret = test_child (); + unlink_ld_debug_output (ppid); + if (ret != 0) exit (1); return 0;