From patchwork Wed Jun 18 20:37:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 114700 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3FBA43850B08 for ; Wed, 18 Jun 2025 20:38:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3FBA43850B08 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=RLlrgf1K X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) by sourceware.org (Postfix) with ESMTPS id CAC873850B00 for ; Wed, 18 Jun 2025 20:37:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CAC873850B00 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CAC873850B00 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1133 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750279061; cv=none; b=gdyM9ov467QrrsChCfkfeMiZcluDcQ1G5ukBWBNNf9D2v8sj5edZZnSFLlmcuq7GB4UZ2Ye1mST/P85yyktDxfiOXXNYRG0IxoCILDrhOfI1gjFnnv8Gk5ByZeDkPEXBP2Fu+gBPsG03R/vy+Q/It3+TVmv+GwRFS8y7pVCqPFM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750279061; c=relaxed/simple; bh=TfaYaUKrIop8OzhhzGKsP7L67pf7LnmQadZmAb0Bbhc=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=aQpL7/61HLFdpcfnau1ZARgBsJayx4LoDyNKWnp6cBUhaaxjdnUl4dAZAspGtKu7C64H7ayswFXoXDfwsuvMWJn92OXtrX5CmLB4TBELQIZwLfiSC7BN19h5u98QIbAqqS0ikcfO5fljnuEUKxHMA5f2J3t/avLfYpIcByoiAXU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CAC873850B00 Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-70e302191a3so864667b3.2 for ; Wed, 18 Jun 2025 13:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750279060; x=1750883860; darn=sourceware.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=RLZV0ZJy219SJKTyLSqS/ESPRWPIKZez4ZzP0MJq9sU=; b=RLlrgf1KcTPNin0DAV8BWxhij/KqfeDXzlw8t3oFJyLjlp8Uhkv/dGmk0oeiYBg0Cq ime4OPGFKFFrp0Zk+5UsrS5GlZtXn6NSqCqwFrAmCDzkfTLhJcPMcnbeFAbsqRegPKWR n4OXsCE7tevcJSoXD3YKd10wFwCWpvZ64/vZgfaFoYGjlB45hJZ9rlIU1k/yLj1I2eGN tDAjiTo0t+iu9glKQyH4iIxEhhHP/0fTd3DFJhNsHHL3Ix4brfGMgQ6XU1Y4KALx4qMZ rf68q7wMXOHmjWA8Ii2UTMPohXHpJuFr/gl0xDE1FJGxACAzq6f9pjm5NF7gUVmzd3Ag 2M6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750279060; x=1750883860; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RLZV0ZJy219SJKTyLSqS/ESPRWPIKZez4ZzP0MJq9sU=; b=tPgG5hC5aFiQVIjComcaviVp+M0OjpUr6NsblA37RpOtWVl0ceHWXGTG4TTtsaMj9N 2kyN7Dda+2xSkBJMQdj3wESUQ/ZsM+ary8xDFUNRNOszf5P4rla54DNRzb7DXM+jbO1z w6HhatCdncs3tpNhh0Ze0EYGAhw8mi1qHsRRo84wFfuyXG6jAImOxZOS6IeKVLY0W2ij ZDpbiIf8RbO0f0LPlw6katMazYrJZap6AQDei2/izAjCZwIET5FhB7Y/dmd77NeNoTaw 2GlPEUGydNYG6LEsS7lIruu8jCbrVYOBZAkiTw3uCA5WVPIdMmcmveHE1S0bNfNr2T5q YTpw== X-Gm-Message-State: AOJu0YyqYYWulsygbORrADvd54VcE9Vri6uQJ2PQO+y2gLXWszd4T1ua o4llu9zpOtaq87loBZIIttXdlue8HCcckkipamHhljmXH3fjVfaDwlkU9Iilq1XBeOypomBTWve TuJuOm953qWpvmLusn7LMIYMRtJ0BRuhA2JEhhGSVAA== X-Gm-Gg: ASbGncvvZdCJls95rTw/qA0U+6vfAZiXIWs3HyZRvapX3b8T5bgEMMGkG02W4cO+1Wk SkdKTCKkDAsq9pOvw8fULddNLeCl/h64jYI++8mNH3+0w+MBA4fJ/ugoN6rOgYSgibIixjrPzV4 8xvkDOiM3Gka8M8Ez/oQUAM4KSl46vNpWP2wlmqw3BE5w= X-Google-Smtp-Source: AGHT+IHtXIWDoClq84FL6CvaJyFLNy+wzLPxO5RdeepjGoz6JRZyBF+H9KNEdfV+RYxIzksDPBHHssS5d3EjZG2eIIQ= X-Received: by 2002:a05:690c:6886:b0:6fb:ae6b:a340 with SMTP id 00721157ae682-71175456e3bmr287608247b3.30.1750279059930; Wed, 18 Jun 2025 13:37:39 -0700 (PDT) MIME-Version: 1.0 From: "H.J. Lu" Date: Thu, 19 Jun 2025 04:37:03 +0800 X-Gm-Features: Ac12FXyUfYTDBQoZWmxx462R-g2Utj6aaUi2tdGBZk19aWWBA02qUu4pOBinfE0 Message-ID: Subject: [PATCH] x86: Update tst-gnu2-tls2 tests To: GNU C Library , Sunil K Pandey X-Spam-Status: No, score=-3014.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org Update tst-gnu2-tls2 tests to set XMM0...XMM7 to all 1s in malloc to verify that XMM registers are preserved when _dl_tlsdesc_dynamic is called by clearing vectors with zeroed XMM registers before _dl_tlsdesc_dynamic and using these XMM registers to clear vectors after _dl_tlsdesc_dynamic. Reviewed-by: Sam James From 38cce69eaf6340a7a8c2a8dadd39a240b8d62987 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Mon, 9 Jun 2025 08:17:49 +0800 Subject: [PATCH] x86: Update tst-gnu2-tls2 tests Update tst-gnu2-tls2 tests to set XMM0...XMM7 to all 1s in malloc to verify that XMM registers are preserved when _dl_tlsdesc_dynamic is called by clearing vectors with zeroed XMM registers before _dl_tlsdesc_dynamic and using these XMM registers to clear vectors after _dl_tlsdesc_dynamic. Signed-off-by: H.J. Lu --- elf/tst-gnu2-tls2.c | 4 +- sysdeps/unix/sysv/linux/x86_64/Makefile | 8 ++-- sysdeps/x86/Makefile | 16 ++++++-- sysdeps/x86/tst-gnu2-tls2-x86-noxsave.c | 2 +- sysdeps/x86/tst-gnu2-tls2-x86-noxsavec.c | 2 +- sysdeps/x86/tst-gnu2-tls2-x86-noxsavexsavec.c | 2 +- sysdeps/x86/tst-gnu2-tls2.c | 36 ++++++++++-------- sysdeps/x86/tst-gnu2-tls2.h | 37 +++++++++++++++++++ 8 files changed, 79 insertions(+), 28 deletions(-) create mode 100644 sysdeps/x86/tst-gnu2-tls2.h diff --git a/elf/tst-gnu2-tls2.c b/elf/tst-gnu2-tls2.c index 74637ee19e..6a253c9b94 100644 --- a/elf/tst-gnu2-tls2.c +++ b/elf/tst-gnu2-tls2.c @@ -25,7 +25,7 @@ #include #include #include -#include "tst-gnu2-tls2.h" +#include #ifndef IS_SUPPORTED # define IS_SUPPORTED() true @@ -75,7 +75,7 @@ close_mod (int i) static void access_mod (int i, const char *sym) { - struct tls var = { -1, -1, -1, -1 }; + struct tls var = { -4, -4, -4, -4 }; struct tls *(*f) (struct tls *) = xdlsym (mod[i], sym); /* Check that our malloc is called. */ malloc_counter = 0; diff --git a/sysdeps/unix/sysv/linux/x86_64/Makefile b/sysdeps/unix/sysv/linux/x86_64/Makefile index fb834a7089..6938382801 100644 --- a/sysdeps/unix/sysv/linux/x86_64/Makefile +++ b/sysdeps/unix/sysv/linux/x86_64/Makefile @@ -87,10 +87,10 @@ $(objpfx)tst-gnu2-tls2-amx-mod0.so: $(libsupport) $(objpfx)tst-gnu2-tls2-amx-mod1.so: $(libsupport) $(objpfx)tst-gnu2-tls2-amx-mod2.so: $(libsupport) -CFLAGS-tst-gnu2-tls2-amx.c += -mamx-tile -CFLAGS-tst-gnu2-tls2-amx-mod0.c += -mamx-tile -mtls-dialect=gnu2 -CFLAGS-tst-gnu2-tls2-amx-mod1.c += -mamx-tile -mtls-dialect=gnu2 -CFLAGS-tst-gnu2-tls2-amx-mod2.c += -mamx-tile -mtls-dialect=gnu2 +CFLAGS-tst-gnu2-tls2-amx.c += -mamx-tile -DTEST_AMX +CFLAGS-tst-gnu2-tls2-amx-mod0.c += -mamx-tile -DTEST_AMX -mtls-dialect=gnu2 +CFLAGS-tst-gnu2-tls2-amx-mod1.c += -mamx-tile -DTEST_AMX -mtls-dialect=gnu2 +CFLAGS-tst-gnu2-tls2-amx-mod2.c += -mamx-tile -DTEST_AMX -mtls-dialect=gnu2 endif endif # $(subdir) == elf diff --git a/sysdeps/x86/Makefile b/sysdeps/x86/Makefile index f64cee3cd9..2aca36c1f0 100644 --- a/sysdeps/x86/Makefile +++ b/sysdeps/x86/Makefile @@ -96,14 +96,22 @@ tst-ifunc-isa-2-ENV = GLIBC_TUNABLES=glibc.cpu.hwcaps=-SSE4_2,-AVX,-AVX2,-AVX512 tst-ifunc-isa-2-static-ENV = $(tst-ifunc-isa-2-ENV) tst-hwcap-tunables-ARGS = -- $(host-test-program-cmd) -CFLAGS-tst-gnu2-tls2.c += -msse +CFLAGS-tst-gnu2-tls2.c += -msse2 CFLAGS-tst-gnu2-tls2mod0.c += -msse2 -mtune=haswell CFLAGS-tst-gnu2-tls2mod1.c += -msse2 -mtune=haswell CFLAGS-tst-gnu2-tls2mod2.c += -msse2 -mtune=haswell -LDFLAGS-tst-gnu2-tls2-x86-noxsave += -Wl,-z,lazy -LDFLAGS-tst-gnu2-tls2-x86-noxsavec += -Wl,-z,lazy -LDFLAGS-tst-gnu2-tls2-x86-noxsavexsavec += -Wl,-z,lazy +LDFLAGS-tst-gnu2-tls2 += -rdynamic +LDFLAGS-tst-gnu2-tls2mod0.so += -Wl,-z,undefs +LDFLAGS-tst-gnu2-tls2mod1.so += -Wl,-z,undefs +LDFLAGS-tst-gnu2-tls2mod2.so += -Wl,-z,undefs + +CFLAGS-tst-gnu2-tls2-x86-noxsave.c += -msse2 +CFLAGS-tst-gnu2-tls2-x86-noxsavec.c += -msse2 +CFLAGS-tst-gnu2-tls2-x86-noxsavexsavec.c += -msse2 +LDFLAGS-tst-gnu2-tls2-x86-noxsave += -Wl,-z,lazy -rdynamic +LDFLAGS-tst-gnu2-tls2-x86-noxsavec += -Wl,-z,lazy -rdynamic +LDFLAGS-tst-gnu2-tls2-x86-noxsavexsavec += -Wl,-z,lazy -rdynamic # Test for bug 32810: incorrect XSAVE state size if XSAVEC is disabled # via tunable. diff --git a/sysdeps/x86/tst-gnu2-tls2-x86-noxsave.c b/sysdeps/x86/tst-gnu2-tls2-x86-noxsave.c index f0024c143d..963c4f3811 100644 --- a/sysdeps/x86/tst-gnu2-tls2-x86-noxsave.c +++ b/sysdeps/x86/tst-gnu2-tls2-x86-noxsave.c @@ -1 +1 @@ -#include +#include diff --git a/sysdeps/x86/tst-gnu2-tls2-x86-noxsavec.c b/sysdeps/x86/tst-gnu2-tls2-x86-noxsavec.c index f0024c143d..963c4f3811 100644 --- a/sysdeps/x86/tst-gnu2-tls2-x86-noxsavec.c +++ b/sysdeps/x86/tst-gnu2-tls2-x86-noxsavec.c @@ -1 +1 @@ -#include +#include diff --git a/sysdeps/x86/tst-gnu2-tls2-x86-noxsavexsavec.c b/sysdeps/x86/tst-gnu2-tls2-x86-noxsavexsavec.c index f0024c143d..963c4f3811 100644 --- a/sysdeps/x86/tst-gnu2-tls2-x86-noxsavexsavec.c +++ b/sysdeps/x86/tst-gnu2-tls2-x86-noxsavexsavec.c @@ -1 +1 @@ -#include +#include diff --git a/sysdeps/x86/tst-gnu2-tls2.c b/sysdeps/x86/tst-gnu2-tls2.c index de900a423b..b3195fff2e 100644 --- a/sysdeps/x86/tst-gnu2-tls2.c +++ b/sysdeps/x86/tst-gnu2-tls2.c @@ -1,20 +1,26 @@ -#ifndef __x86_64__ -#include +#ifndef TEST_AMX +# ifndef __x86_64__ +# include -#define IS_SUPPORTED() CPU_FEATURE_ACTIVE (SSE2) -#endif +# define IS_SUPPORTED() CPU_FEATURE_ACTIVE (SSE2) +# endif -/* Clear XMM0...XMM7 */ -#define PREPARE_MALLOC() \ -{ \ - asm volatile ("xorps %%xmm0, %%xmm0" : : : "xmm0" ); \ - asm volatile ("xorps %%xmm1, %%xmm1" : : : "xmm1" ); \ - asm volatile ("xorps %%xmm2, %%xmm2" : : : "xmm2" ); \ - asm volatile ("xorps %%xmm3, %%xmm3" : : : "xmm3" ); \ - asm volatile ("xorps %%xmm4, %%xmm4" : : : "xmm4" ); \ - asm volatile ("xorps %%xmm5, %%xmm5" : : : "xmm5" ); \ - asm volatile ("xorps %%xmm6, %%xmm6" : : : "xmm6" ); \ - asm volatile ("xorps %%xmm7, %%xmm7" : : : "xmm7" ); \ +/* Set XMM0...XMM7 to all 1s. */ +# define PREPARE_MALLOC() \ +{ \ + asm volatile ("pcmpeqd %%xmm0, %%xmm0" : : : "xmm0" ); \ + asm volatile ("pcmpeqd %%xmm1, %%xmm1" : : : "xmm1" ); \ + asm volatile ("pcmpeqd %%xmm2, %%xmm2" : : : "xmm2" ); \ + asm volatile ("pcmpeqd %%xmm3, %%xmm3" : : : "xmm3" ); \ + asm volatile ("pcmpeqd %%xmm4, %%xmm4" : : : "xmm4" ); \ + asm volatile ("pcmpeqd %%xmm5, %%xmm5" : : : "xmm5" ); \ + asm volatile ("pcmpeqd %%xmm6, %%xmm6" : : : "xmm6" ); \ + asm volatile ("pcmpeqd %%xmm7, %%xmm7" : : : "xmm7" ); \ } +#endif #include + +#ifndef TEST_AMX +v2di v1, v2, v3; +#endif diff --git a/sysdeps/x86/tst-gnu2-tls2.h b/sysdeps/x86/tst-gnu2-tls2.h new file mode 100644 index 0000000000..fdbb56500c --- /dev/null +++ b/sysdeps/x86/tst-gnu2-tls2.h @@ -0,0 +1,37 @@ +/* Test TLSDESC relocation, x86 version. + Copyright (C) 2025 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#ifndef TEST_AMX +# include + +typedef long long v2di __attribute__((vector_size(16))); +extern v2di v1, v2, v3; + +# define BEFORE_TLSDESC_CALL() \ + v1 = __extension__(v2di){0, 0}; \ + v2 = __extension__(v2di){0, 0}; + +# define AFTER_TLSDESC_CALL() \ + v3 = __extension__(v2di){0, 0}; \ + asm volatile ("" : "+x" (v3)); \ + union { v2di x; long long a[2]; } u; \ + u.x = v3; \ + TEST_VERIFY_EXIT (u.a[0] == 0 && u.a[1] == 0); +#endif + +#include -- 2.49.0