From patchwork Sat Jun 14 10:09:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matteo Croce X-Patchwork-Id: 114485 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9CD1B38BE99E for ; Sat, 14 Jun 2025 10:10:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9CD1B38BE99E Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Iitukq8U X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id 47A7438BE99D for ; Sat, 14 Jun 2025 10:09:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 47A7438BE99D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 47A7438BE99D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749895760; cv=none; b=pmzCAr0pndsSj4nJvAGHlIQtgGwL3ZGIVYdBc7Ws6QtJPvi4H6yTB5SpBx61BgFNjs3LxxaK+8olK78ShD7QiA2qRxSJAQLL+HdgxTCQ85xFF+q1zW+g09+qJoeqQlV7vF0wwmX3Tp6WwcBqNwC/Zt+FFD+uuc0Lw1FO4NnSp2E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749895760; c=relaxed/simple; bh=+FgizwqvI7qE8N4t5+3frJRQ/v4QMkFwGYGjX2wxFw8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=FaKL17yV/oLiE3skSIzCj2bh9N2rduRnmYZhjAiUBRoQ0P8dJCZGtbwdybNN/TVK25vSv3FLlhGIpnUZrth10GDlQpdCd+mr702kgqgN4AlCVTMeqNV59uMsFBHbfA3tkbzokhnVA6VLasIOgYT8fIWP0lwSjl3CCMAxwEkpVtQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 47A7438BE99D Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-608acb0a27fso3012275a12.0 for ; Sat, 14 Jun 2025 03:09:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749895759; x=1750500559; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hfSoqaBw/AeqsPd4JIBvGeJMFRjkrSf+wkuy+CV2wys=; b=Iitukq8UoodaZS+L5ZC8GZ5+RNP/Ulbq6fDWfXJdB+cVfRW84CULdylQk8cp+XJ0mU MAgATm1e2PpxEO/OYdwMKjbaK7k+NM8CqsWWhfZAdAMAxMha6wyjhmZ8P+QhSINZqVtL PNpTr8hK/fQfUNf8LwP5PCWGUzt1skoIZhR9uU9zYzSc9xyrNY6q9xzN8p2d3pwoaM/D A50Pzq5MVQ0gwxgyGQ6q6ePzBwjOPznREEWy5sV9hZe02T5Zp5nR36YzFv2heMErt2CP DjyPTQCKKTJwGeHG1q5zUVp7cqzxUmF+oWOFHMoJj7qGd6QU1IfxcsH3UV8QfffLAo4z NhKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749895759; x=1750500559; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hfSoqaBw/AeqsPd4JIBvGeJMFRjkrSf+wkuy+CV2wys=; b=TZkFmidF+sxczFqL/Ys8b3R0DHxkT7XM3FUtgILqiXCaApbvk5YDPwDsfCQ8aj3Wrn MHanX0foYU37CLFWfDf3M23XlBF5lUP0DDEAormAV9MU3paRKcUhGQbLijSYO65Fj50b sQ+ZA0Ua1pCA2NbVvqYb23kSh/ttHK+SpB0PTmzhYcBih49cv/vGfJWOcVCNJHLFd0DJ mXKx56lWOEV2/Xe2pvBV1vghuFcVpA4UmJ5fnOSdKDeXZE9jEAJPv8hc0V2tDJF5GM6d mW6ABpKe3a7/sgnAv1XJALa6jCMtAoKtJMkrp6cASv2OeuCJq9SkdpMonEnM2Xra49RI 8Gpg== X-Gm-Message-State: AOJu0YwTZM26qQ57kM9NHiVpwpyPR9TJKXOGVomMpZhuciKxJCQfQ9/a j+5VLGCch7UI+e0ilvJ4w5QmJBc94bOZmIbS8BXSSos7L+1CK2zWqvukjVXCqGKlZb8= X-Gm-Gg: ASbGnctoHv3Q5ZJuGInEtlDS08QJPfZJtoSlunr1jfqUTSLh6V7SLHJ3sYqJLd/iu5K Zn67Us6UmRso1hWpcn9Kr0PlwSZiLOxRvBw36g59EPWPlcTP677fGNElvBJWFq6oCl7fikWGsUD uakVVProWYvcFZXZpmMpo+gGfNotPxJBpEXmc+DQRxGNcxmRYk8P4gCCTJ0Ny4TrfnXKMSl3br8 CBoNmUjPKCP4UuHrxK/bHxAMi1Pvc6JSlqqR6lI4s90LMkvKh02PPoTpD+UEkVCWa5go8BEyY1D f5RF2qGPCBxIfHBgWWsSMA+y1zpzVK/TeaU7w2cQ5ip99I16kZShBvBHd1CqHItFOKwLJHG3 X-Google-Smtp-Source: AGHT+IHzL6wZyu8JdoYKmmNcVDrG58P8ewKQrMnJx8LK7OyzZU8w1//AZ9gawIZUCPzBg2isABNVeA== X-Received: by 2002:a17:907:1ca1:b0:ad8:9d9b:40f9 with SMTP id a640c23a62f3a-adfad451623mr212592366b.43.1749895758762; Sat, 14 Jun 2025 03:09:18 -0700 (PDT) Received: from fedorarm.. ([147.229.117.1]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-adec897bd88sm275191166b.165.2025.06.14.03.09.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Jun 2025 03:09:18 -0700 (PDT) From: Matteo Croce To: libc-alpha@sourceware.org Cc: Matteo Croce Subject: [PATCH v2] fstat: add test and documentation for an edge case. Date: Sat, 14 Jun 2025 12:09:16 +0200 Message-ID: <20250614100916.203313-1-technoboy85@gmail.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org From: Matteo Croce The fstatat behaviour when the target is a dangling symlink is different if flags contains AT_SYMLINK_NOFOLLOW or not. Add a test for this and document it. --- io/tst-stat.c | 16 +++++++++++++++- manual/filesys.texi | 5 +++-- 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/io/tst-stat.c b/io/tst-stat.c index 61bdbfb638..257e39de65 100644 --- a/io/tst-stat.c +++ b/io/tst-stat.c @@ -62,12 +62,22 @@ fstatat_check (int fd, const char *path, struct stat *st) TEST_COMPARE (fstatat (fd, path, st, 0), 0); } +static void +fstatat_link (const char *path, struct stat *st) +{ + TEST_COMPARE (fstatat (AT_FDCWD, path, st, 0), -1); + TEST_COMPARE (errno, ENOENT); + + TEST_COMPARE (fstatat (AT_FDCWD, path, st, AT_SYMLINK_NOFOLLOW), 0); +} + typedef void (*test_t)(int, const char *path, struct stat *); static int do_test (void) { char *path; + const char *linkame = "tst-fstat.linkname"; int fd = create_temp_file ("tst-fstat.", &path); TEST_VERIFY_EXIT (fd >= 0); support_write_file_string (path, "abc"); @@ -81,13 +91,13 @@ do_test (void) printf ("warning: timestamp with nanoseconds not supported\n"); struct statx stx; + struct stat st; TEST_COMPARE (statx (fd, path, 0, STATX_BASIC_STATS, &stx), 0); test_t tests[] = { stat_check, lstat_check, fstat_check, fstatat_check }; for (int i = 0; i < array_length (tests); i++) { - struct stat st; tests[i](fd, path, &st); TEST_COMPARE (stx.stx_dev_major, major (st.st_dev)); @@ -111,6 +121,10 @@ do_test (void) } } + symlink("tst-fstat.target", linkame); + add_temp_file(linkame); + fstatat_link(linkame, &st); + return 0; } diff --git a/manual/filesys.texi b/manual/filesys.texi index d0ced84bf6..e3721c3d23 100644 --- a/manual/filesys.texi +++ b/manual/filesys.texi @@ -2397,8 +2397,9 @@ The descriptor @var{filedes} is not associated with a directory, and @var{filename} is a relative file name. @item ENOENT -The file named by @var{filename} does not exist, or @var{filename} is an -empty string and @var{flags} does not contain @code{AT_EMPTY_PATH}. +The file named by @var{filename} does not exist, it's a dangling symlink +and @var{flags} does not contain @code{AT_SYMLINK_NOFOLLOW}, or @var{filename} +is an empty string and @var{flags} does not contain @code{AT_EMPTY_PATH}. @end table When the sources are compiled with @code{_FILE_OFFSET_BITS == 64} this