From patchwork Fri May 16 12:52:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alejandro Colomar X-Patchwork-Id: 112379 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 33C7D3858289 for ; Fri, 16 May 2025 12:52:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 33C7D3858289 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=U6EHBt3S X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by sourceware.org (Postfix) with ESMTPS id 627463858416 for ; Fri, 16 May 2025 12:52:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 627463858416 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 627463858416 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=172.105.4.254 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1747399932; cv=none; b=mv4/pv9M4Qwx3Ebf1oFLNa9HuiKZCekDax/+ZaHWknfWbTrAXK+bTM/Y4hv+rtbT+c9MIY4c0Gr2ICiv+jGC4FQuQiAiF0xy6lWngbBGsa/GU474VAwn0Ove0OF0cfVEv/t6GIgX5J0Z9YasHKPUJZmzHEgeoM8BstgbtsLhtKg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1747399932; c=relaxed/simple; bh=5XNbJn2Os6XRURBhbHEbR26xbDn53Gzi/Niz2e844T0=; h=DKIM-Signature:Date:From:Subject:Message-ID:MIME-Version; b=X7aKAeydZQSuJGG+/sfxp7rd7InjQ0jg5/ATLxYKtYdKPuDj70d6zLtRTzZOpTBnEyTkNKWb6RcSR+7HCORG/UXZzErBOdfGX4Uazyzl6R4cnBEd7egB+3uoDfyLVuPm4FaD0XjUw2FrIjTYARiDPMcZsNaTyk9Uw5ec/2pqPvY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 627463858416 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id B3A6B629F9; Fri, 16 May 2025 12:52:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79295C4CEE9; Fri, 16 May 2025 12:52:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747399931; bh=5XNbJn2Os6XRURBhbHEbR26xbDn53Gzi/Niz2e844T0=; h=Date:From:Cc:Subject:References:In-Reply-To:From; b=U6EHBt3SuYdyVL+ZXYeIFCoJPrBp6/N+rm73qneLENMr4zcTsWet/yDGnnlLVE5jv tjh4M38fBOMJICYf4+oAPi2ZK/Vr4byMoACkSEPbeE7WtvAGGI0H5R/4NbuR7dhadx Mo6Q7eERm/3pgjr1V0ycZcDsAm1dMt+Cd/zYnsJpr+OBz06v+3MCbbuRPQqeXDLRcN U4d09CXCtIyDHJtVkrtqrAS2mSQM4NWvI58RWoMVBa5LMM9sKFfnLByVtgOFHv7AmE P2htj2Ooxvm/OVC1mZix50GIlXDVwvXJHeC6phemVUTxq/zjUgizk+kpU1OiPSTiiY k0YSrNioaH61Q== Date: Fri, 16 May 2025 14:52:05 +0200 From: Alejandro Colomar Cc: Alejandro Colomar , Jan Kara , Alexander Viro , Christian Brauner , Rich Felker , linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, libc-alpha@sourceware.org Subject: [RFC v1] man/man2/close.2: CAVEATS: Document divergence from POSIX.1-2024 Message-ID: X-Mailer: git-send-email 2.49.0 References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_HEADERS, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org POSIX.1-2024 now mandates a behavior different from what Linux (and many other implementations) does. It requires that we report EINPROGRESS for what now is EINTR. There are no plans to conform to POSIX.1-2024 within the Linux kernel, so document this divergence. Keep POSIX.1-2008 as the standard to which we conform in STANDARDS. Link: Link: Cc: Jan Kara Cc: Alexander Viro Cc: Christian Brauner Cc: Rich Felker Cc: Cc: Cc: Signed-off-by: Alejandro Colomar --- Hi, I've prepared this draft for discussion. While doing so, I've noticed the glibc bug ticket, which sounds possibly reasonable: returning 0 instead of reporting an error on EINTR. That would be an option that would make us conforming to POSIX.1-2024. And given that a user can (and must) do nothing after seeing EINTR, returning 0 wouldn't change things. So, I'll leave this patch open for discussion. Have a lovely day! Alex man/man2/close.2 | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) Range-diff against v0: -: --------- > 1: efaffc5a4 man/man2/close.2: CAVEATS: Document divergence from POSIX.1-2024 base-commit: 978b017d93e4e32b752b33877e44a8365644630c diff --git a/man/man2/close.2 b/man/man2/close.2 index b25ea4de9..9d5e26eed 100644 --- a/man/man2/close.2 +++ b/man/man2/close.2 @@ -191,10 +191,7 @@ .SS Dealing with error returns from close() meaning that the file descriptor was invalid) even if they subsequently report an error on return from .BR close (). -POSIX.1 is currently silent on this point, -but there are plans to mandate this behavior in the next major release -.\" Issue 8 -of the standard. +POSIX.1-2008 was silent on this point. .P A careful programmer who wants to know about I/O errors may precede .BR close () @@ -206,7 +203,7 @@ .SS Dealing with error returns from close() error is a somewhat special case. Regarding the .B EINTR -error, POSIX.1-2008 says: +error, POSIX.1-2008 said: .P .RS If @@ -243,16 +240,10 @@ .SS Dealing with error returns from close() error, and on at least one, .BR close () must be called again. -There are plans to address this conundrum for -the next major release of the POSIX.1 standard. -.\" FIXME . for later review when Issue 8 is one day released... -.\" POSIX proposes further changes for EINTR -.\" http://austingroupbugs.net/tag_view_page.php?tag_id=8 -.\" http://austingroupbugs.net/view.php?id=529 -.\" -.\" FIXME . -.\" Review the following glibc bug later -.\" https://sourceware.org/bugzilla/show_bug.cgi?id=14627 +.P +POSIX.1-2024 standardized the behavior of HP-UX, +making Linux and many other implementations non-conforming. +There are no plans to change the behavior on Linux. .SH SEE ALSO .BR close_range (2), .BR fcntl (2),