From patchwork Mon Apr 21 21:09:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 110771 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 116473858C42 for ; Mon, 21 Apr 2025 21:10:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 116473858C42 X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by sourceware.org (Postfix) with ESMTPS id 62D2F3858CD1 for ; Mon, 21 Apr 2025 21:09:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 62D2F3858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bounce.ens-lyon.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 62D2F3858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.77.166.138 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745269795; cv=none; b=XVQiDoN7OsI0DNBYfpSnWoG3bySr6kZiIDdRLGUBdKnqFH8ZJ/RapOMAf3tKdSapO3urS7MXzUuhx36UrNOdEBpCqJLyHCkTzFCMmpBf9jRUyNfHZejcI1CYmTfi3sv4VhwWetElhRwqhCk97peASJY7F+72crajyAn6p8y2JNM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745269795; c=relaxed/simple; bh=rRdTUKCzg9FOAU5vVPkyA4/eFKxoIXUfzYcdEV/Ch1o=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=D2mzz+FQmn/sJA3CcXP1Qc3yb/qZRs/l7vhbAWGevkoS7XSq1QWyT4znOnHFFK2So34Etp40p4MmmvWKDY+s5LqQoXqNiFHyWPLkJKHUhEoGTq/QJLe6wLchYxI1K6JMWoGju9sIlWKAZr8vN861vo8me1LXczWj+MbeZ4Mwa2o= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 62D2F3858CD1 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 62021A4922; Mon, 21 Apr 2025 23:09:54 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vFx-TgAzfthw; Mon, 21 Apr 2025 23:09:54 +0200 (CEST) Received: from begin (aamiens-653-1-40-48.w83-192.abo.wanadoo.fr [83.192.199.48]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 2A7F8A4884; Mon, 21 Apr 2025 23:09:54 +0200 (CEST) Received: from samy by begin with local (Exim 4.98.2) (envelope-from ) id 1u6yOn-0000000EkGe-2hqI; Mon, 21 Apr 2025 23:09:53 +0200 From: Samuel Thibault To: libc-alpha@sourceware.org Cc: Samuel Thibault , commit-hurd@gnu.org Subject: [hurd, commited] hurd: Make symlink return EEXIST on existing target directory Date: Mon, 21 Apr 2025 23:09:53 +0200 Message-ID: <20250421210953.3514437-1-samuel.thibault@ens-lyon.org> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org 8ef17919509e ("hurd: Fix EINVAL error on linking to a slash-trailing path [BZ #32569]) made symlink return ENOTDIR, but the gnulib testsuite does not recognize it for such a situation, and EEXIST is indeed more comprehensible to users. --- sysdeps/mach/hurd/symlinkat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdeps/mach/hurd/symlinkat.c b/sysdeps/mach/hurd/symlinkat.c index e7dfb673df..cb6250e6f0 100644 --- a/sysdeps/mach/hurd/symlinkat.c +++ b/sysdeps/mach/hurd/symlinkat.c @@ -47,7 +47,7 @@ __symlinkat (const char *from, int fd, const char *to) if (! *name) /* Can't link to the existing directory itself. */ - err = ENOTDIR; + err = EEXIST; else /* Create a new, unlinked node in the target directory. */ err = __dir_mkfile (dir, O_WRITE, 0777 & ~_hurd_umask, &node);