From patchwork Mon Apr 21 17:47:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 110765 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1D4D43858D39 for ; Mon, 21 Apr 2025 17:47:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1D4D43858D39 X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by sourceware.org (Postfix) with ESMTPS id 89FAC3858D37 for ; Mon, 21 Apr 2025 17:47:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 89FAC3858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bounce.ens-lyon.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 89FAC3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.77.166.138 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745257633; cv=none; b=T5wvUvPDkYfADIw/A0WQYPdtr0F2yvLd9XuIaX69zKuvCfCcwPisJP9iESAEETkheEkxub6gTtZBnA309FNqAcpeZ4zwhyyiXjObauQvSOUgdL6AjRpKIGHHC+TXJ7h2KvVaKorSajSyqhSKGSzr88iZ5s2XxaTBI8kxeRGo/Lw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745257633; c=relaxed/simple; bh=AkaGEA+KYSuoxleVxyJSw1yTgbft9kCji5c3Fc3Q/eo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=c4X22OztWiG/p+Q93srMhM2nCnZlfc6YO0J3OEaewsd8m6l6mjzZ5B8C1Ji0YRzoburs5k91fTFWQMzrL/n94G2fFeS+E+dhNjtPNVwa1dUXMlbPkv8ktSkw8jRcdzb+H78J2DxnOeGXbhbY/8vq6S7PvUK1MvM52unDvwcvMnI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 89FAC3858D37 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id BC568A493C; Mon, 21 Apr 2025 19:47:12 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5RDg2I-eDhRN; Mon, 21 Apr 2025 19:47:12 +0200 (CEST) Received: from begin (aamiens-653-1-40-48.w83-192.abo.wanadoo.fr [83.192.199.48]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id A1344A4938; Mon, 21 Apr 2025 19:47:12 +0200 (CEST) Received: from samy by begin with local (Exim 4.98.2) (envelope-from ) id 1u6vEe-0000000EaHe-0elO; Mon, 21 Apr 2025 19:47:12 +0200 From: Samuel Thibault To: libc-alpha@sourceware.org Cc: Samuel Thibault , commit-hurd@gnu.org Subject: [hurd, commited] hurd: Do not check for xstate level if it was not initialized Date: Mon, 21 Apr 2025 19:47:08 +0200 Message-ID: <20250421174708.3476030-1-samuel.thibault@ens-lyon.org> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org If __thread_get_state failed, there is no xstate level to check. ok is 0 already and the memory exists, but better not read uninitialized memory. --- sysdeps/mach/hurd/x86/trampoline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdeps/mach/hurd/x86/trampoline.c b/sysdeps/mach/hurd/x86/trampoline.c index db756e8a1f..02510b178c 100644 --- a/sysdeps/mach/hurd/x86/trampoline.c +++ b/sysdeps/mach/hurd/x86/trampoline.c @@ -289,7 +289,7 @@ _hurd_setup_sighandler (struct hurd_sigstate *ss, const struct sigaction *action (thread_state_t) stackframe->xstate, &got) && got == (xstate_size / sizeof (int))); - if (((struct i386_xfloat_state*) stackframe->xstate)->fp_save_kind > 5) + if (ok && ((struct i386_xfloat_state*) stackframe->xstate)->fp_save_kind > 5) /* We support up to XSAVES */ ok = 0;