From patchwork Mon Feb 10 19:28:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 106305 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 20B2A3857B84 for ; Mon, 10 Feb 2025 19:29:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 20B2A3857B84 X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from sonata.ens-lyon.org (sonata.ens-lyon.org [140.77.166.138]) by sourceware.org (Postfix) with ESMTPS id 29D293858420 for ; Mon, 10 Feb 2025 19:28:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 29D293858420 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bounce.ens-lyon.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 29D293858420 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.77.166.138 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739215724; cv=none; b=DIGh6IMIb3cguPPGr2l3JM/8kGSbQHIRgXsCLtPlglnLHJwONmFowGznqeRxWp+Sz1VIfH/L0PB/SC2i+Q5QsPWYslTs/vLEC5FUZXiygj5kJGPV3z67kdQR0QHy/hdGSeK5S0AVGC9e62pe+OtBDG/zd795NpgkFfxQsjB8Tuo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739215724; c=relaxed/simple; bh=jmK2ax/oOG4gWM8yqAnLgic+dnOieMMkFb+9g600aic=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=HJE6OaBm1Mb47KGApFLggVdEmXZvey3tAGngsdDxj7d8vE3L1oOLRS27l3XRwFrcNmn6LlMQIABCUS9nYYyqrTS7czRRJMSOtPoMqezXQMAbmc5xBrzHEsY2Xvuwv31gFH965biW/Gu4zrl8lPZohLb6kZTvZk0H0hLbt5f2rto= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 29D293858420 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 56734A5E52; Mon, 10 Feb 2025 20:28:43 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RflwkBb7lVDk; Mon, 10 Feb 2025 20:28:43 +0100 (CET) Received: from begin.home (aamiens-653-1-40-48.w83-192.abo.wanadoo.fr [83.192.199.48]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 3CF2DA1BD9; Mon, 10 Feb 2025 20:28:43 +0100 (CET) Received: from samy by begin.home with local (Exim 4.98) (envelope-from ) id 1thZSU-00000004iK4-3IFj; Mon, 10 Feb 2025 20:28:42 +0100 From: Samuel Thibault To: libc-alpha@sourceware.org Cc: Samuel Thibault , commit-hurd@gnu.org Subject: [hurd,commited] hurd: Replace char foo[1024] with string_t Date: Mon, 10 Feb 2025 20:28:41 +0100 Message-ID: <20250210192841.1123677-1-samuel.thibault@ens-lyon.org> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org Like already done in various other places and advised by Roland in https://lists.gnu.org/archive/html/bug-hurd/2012-04/msg00124.html --- hurd/hurd/lookup.h | 4 ++-- hurd/hurdlookup.c | 2 +- hurd/lookup-at.c | 2 +- hurd/lookup-retry.c | 2 +- sysdeps/mach/hurd/bind.c | 2 +- sysdeps/mach/hurd/dl-sysdep.c | 2 +- sysdeps/mach/hurd/fexecve.c | 2 +- sysdeps/mach/hurd/getlogin.c | 2 +- sysdeps/mach/hurd/readlinkat.c | 2 +- sysdeps/mach/hurd/ttyname.c | 2 +- sysdeps/mach/hurd/ttyname_r.c | 2 +- 11 files changed, 12 insertions(+), 12 deletions(-) diff --git a/hurd/hurd/lookup.h b/hurd/hurd/lookup.h index f2ff0a1537..45f365f8d3 100644 --- a/hurd/hurd/lookup.h +++ b/hurd/hurd/lookup.h @@ -138,7 +138,7 @@ error_t __hurd_file_name_lookup_retry (error_t (*use_init_port) string_t retry_name, mach_port_t *result), enum retry_type doretry, - char retryname[1024], + string_t retryname, int flags, mode_t mode, file_t *result); error_t hurd_file_name_lookup_retry (error_t (*use_init_port) @@ -152,7 +152,7 @@ error_t hurd_file_name_lookup_retry (error_t (*use_init_port) string_t retry_name, mach_port_t *result), enum retry_type doretry, - char retryname[1024], + string_t retryname, int flags, mode_t mode, file_t *result); diff --git a/hurd/hurdlookup.c b/hurd/hurdlookup.c index 994d557ff7..f27bf3af6d 100644 --- a/hurd/hurdlookup.c +++ b/hurd/hurdlookup.c @@ -51,7 +51,7 @@ __hurd_file_name_lookup (error_t (*use_init_port) { error_t err; enum retry_type doretry; - char retryname[1024]; /* XXX string_t LOSES! */ + string_t retryname; int startport; error_t lookup_op (mach_port_t startdir) diff --git a/hurd/lookup-at.c b/hurd/lookup-at.c index c2a1139dea..064b1ba4c6 100644 --- a/hurd/lookup-at.c +++ b/hurd/lookup-at.c @@ -40,7 +40,7 @@ __file_name_lookup_at (int fd, int at_flags, if (empty != 0 && file_name[0] == '\0') { enum retry_type doretry; - char retryname[1024]; /* XXX string_t LOSES! */ + string_t retryname; err = HURD_DPORT_USE (fd, __dir_lookup (port, "", flags, mode, &doretry, retryname, diff --git a/hurd/lookup-retry.c b/hurd/lookup-retry.c index 3a9ad70f5d..6b94a10eae 100644 --- a/hurd/lookup-retry.c +++ b/hurd/lookup-retry.c @@ -53,7 +53,7 @@ __hurd_file_name_lookup_retry (error_t (*use_init_port) retry_type *do_retry, string_t retry_name, mach_port_t *result), enum retry_type doretry, - char retryname[1024], + string_t retryname, int flags, mode_t mode, file_t *result) { diff --git a/sysdeps/mach/hurd/bind.c b/sysdeps/mach/hurd/bind.c index bb408afcf6..cdcdd305ad 100644 --- a/sysdeps/mach/hurd/bind.c +++ b/sysdeps/mach/hurd/bind.c @@ -66,7 +66,7 @@ __bind (int fd, __CONST_SOCKADDR_ARG addrarg, socklen_t len) if (! err) { enum retry_type doretry; - char retryname[1024]; + string_t retryname; /* Get a port to the ifsock translator. */ err = __dir_lookup (node, "", 0, 0, &doretry, retryname, &ifsock); if (! err && (doretry != FS_RETRY_NORMAL || retryname[0] != '\0')) diff --git a/sysdeps/mach/hurd/dl-sysdep.c b/sysdeps/mach/hurd/dl-sysdep.c index 0ddb220a4e..173499c4c1 100644 --- a/sysdeps/mach/hurd/dl-sysdep.c +++ b/sysdeps/mach/hurd/dl-sysdep.c @@ -267,7 +267,7 @@ open_file (const char *file_name, int flags, mach_port_t *port, struct stat64 *stat) { enum retry_type doretry; - char retryname[1024]; /* XXX string_t LOSES! */ + string_t retryname; file_t startdir; error_t err; diff --git a/sysdeps/mach/hurd/fexecve.c b/sysdeps/mach/hurd/fexecve.c index 906cd86be4..cd3bd2b269 100644 --- a/sysdeps/mach/hurd/fexecve.c +++ b/sysdeps/mach/hurd/fexecve.c @@ -28,7 +28,7 @@ fexecve (int fd, char *const argv[], char *const envp[]) file_t file; error_t err; enum retry_type doretry; - char retryname[1024]; + string_t retryname; err = HURD_DPORT_USE (fd, __dir_lookup (port, "", O_EXEC, 0, &doretry, retryname, &file)); diff --git a/sysdeps/mach/hurd/getlogin.c b/sysdeps/mach/hurd/getlogin.c index b3427b0fc0..d73c034373 100644 --- a/sysdeps/mach/hurd/getlogin.c +++ b/sysdeps/mach/hurd/getlogin.c @@ -25,7 +25,7 @@ char * getlogin (void) { - static char login[1024]; /* XXX */ + static string_t login; error_t err; if (err = __USEPORT (PROC, __proc_getlogin (port, login))) diff --git a/sysdeps/mach/hurd/readlinkat.c b/sysdeps/mach/hurd/readlinkat.c index e56764de54..dbbc528ffb 100644 --- a/sysdeps/mach/hurd/readlinkat.c +++ b/sysdeps/mach/hurd/readlinkat.c @@ -32,7 +32,7 @@ __readlinkat (int fd, const char *file_name, char *buf, size_t len) file_t file_stat; struct stat64 st; enum retry_type doretry; - char retryname[1024]; + string_t retryname; file_t file; char *rbuf = buf; mach_msg_type_number_t nread = len; diff --git a/sysdeps/mach/hurd/ttyname.c b/sysdeps/mach/hurd/ttyname.c index 62c3bf7615..1353fe8e1d 100644 --- a/sysdeps/mach/hurd/ttyname.c +++ b/sysdeps/mach/hurd/ttyname.c @@ -27,7 +27,7 @@ char * ttyname (int fd) { error_t err; - static char nodename[1024]; /* XXX */ + static string_t nodename; if (err = HURD_DPORT_USE (fd, __term_get_nodename (port, nodename))) { diff --git a/sysdeps/mach/hurd/ttyname_r.c b/sysdeps/mach/hurd/ttyname_r.c index f0e3f65dbe..836ec6aca2 100644 --- a/sysdeps/mach/hurd/ttyname_r.c +++ b/sysdeps/mach/hurd/ttyname_r.c @@ -28,7 +28,7 @@ int __ttyname_r (int fd, char *buf, size_t buflen) { error_t err; - char nodename[1024]; /* XXX */ + string_t nodename; size_t len; if (err = HURD_DPORT_USE (fd, __term_get_nodename (port, nodename)))