From patchwork Mon Feb 10 19:28:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 106304 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 48FF83858420 for ; Mon, 10 Feb 2025 19:29:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 48FF83858420 X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by sourceware.org (Postfix) with ESMTPS id 4B3C13858288 for ; Mon, 10 Feb 2025 19:28:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4B3C13858288 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bounce.ens-lyon.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4B3C13858288 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.77.166.138 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739215721; cv=none; b=AfuV853e8BH6QHudZwrRC+QCb5sg34tjs+yYRZqLS1VqyKGPjlGzED+q5pNb3sJvEFfyfdblK8TJeE3dWMFFV24GtFHoixnmoF4T1BjR3hg9s9Pp2nFSlbEvPfYPq6EnLV1XQGYpJhXqQsJwUkGP71RfLBiGxO/WWJq/E6epLxM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739215721; c=relaxed/simple; bh=s2eRzKGAsFLQR8uqeD9Qk6mgEzKMU2E0Egb/2bcmLb8=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=v5DzlKXfnJ5zfnvmuXUrXuuBATyrA2kWUXDvvkeo/3/JSlZW1d2XCVdZws0bTfjdZwo5JZ4/r8IZ0yyRou0FKBmBrrdzzA9J1OIkksnfh+z1qLJunulwjRg/P585ewPBj6KJSnJxQsMInleWM/KXxvidXxtM2PwArTcFsu8uEWo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4B3C13858288 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id EB000A5E50; Mon, 10 Feb 2025 20:28:39 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GYUXrlvdZcYQ; Mon, 10 Feb 2025 20:28:39 +0100 (CET) Received: from begin.home (aamiens-653-1-40-48.w83-192.abo.wanadoo.fr [83.192.199.48]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 724F3A1BD9; Mon, 10 Feb 2025 20:28:39 +0100 (CET) Received: from samy by begin.home with local (Exim 4.98) (envelope-from ) id 1thZSR-00000004iJV-02cx; Mon, 10 Feb 2025 20:28:39 +0100 From: Samuel Thibault To: libc-alpha@sourceware.org Cc: Samuel Thibault , commit-hurd@gnu.org Subject: [hurd,commited] hurd: Drop useless buffer initialization in ttyname* Date: Mon, 10 Feb 2025 20:28:38 +0100 Message-ID: <20250210192838.1123646-1-samuel.thibault@ens-lyon.org> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org The RPC stub will write a string anyway. --- sysdeps/mach/hurd/ttyname.c | 1 - sysdeps/mach/hurd/ttyname_r.c | 1 - 2 files changed, 2 deletions(-) diff --git a/sysdeps/mach/hurd/ttyname.c b/sysdeps/mach/hurd/ttyname.c index 4c51492311..62c3bf7615 100644 --- a/sysdeps/mach/hurd/ttyname.c +++ b/sysdeps/mach/hurd/ttyname.c @@ -29,7 +29,6 @@ ttyname (int fd) error_t err; static char nodename[1024]; /* XXX */ - nodename[0] = '\0'; if (err = HURD_DPORT_USE (fd, __term_get_nodename (port, nodename))) { if (err == MIG_BAD_ID || err == EOPNOTSUPP) diff --git a/sysdeps/mach/hurd/ttyname_r.c b/sysdeps/mach/hurd/ttyname_r.c index 4abceb6adc..f0e3f65dbe 100644 --- a/sysdeps/mach/hurd/ttyname_r.c +++ b/sysdeps/mach/hurd/ttyname_r.c @@ -31,7 +31,6 @@ __ttyname_r (int fd, char *buf, size_t buflen) char nodename[1024]; /* XXX */ size_t len; - nodename[0] = '\0'; if (err = HURD_DPORT_USE (fd, __term_get_nodename (port, nodename))) { if (err == MIG_BAD_ID || err == EOPNOTSUPP)